27285 2009-07-14 18:24:05 -0700 [Qt] New window created by clicking a link is not visible 2009-11-16 09:52:25 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned hausmann vestbo oldest_to_newest 131782 0 yael 2009-07-14 18:24:05 -0700 When clicking a link with a specified target attribute, a new window is created. That new window is not visible though. This is not a problem when opening a new window from JavaScript. Loading the following content in QtLauncher can show the problem: <html> <body> <a target="_blank" href="#">click me</a><br> </body></html> 131786 1 32757 yael 2009-07-14 18:32:43 -0700 Created attachment 32757 Force the new window to be visible This is similar to calling ChromeClientQt::show(), when opening a new window from JavaScript. 131848 2 32757 manyoso 2009-07-15 04:30:19 -0700 Comment on attachment 32757 Force the new window to be visible I believe this is incorrect. Arora, which is based on QtWebKit has no problem showing windows when a link is clicked. In fact, there is a setting in Arora to control the behavior so that opening the "new window" is done in a tab instead. The QWebPage|QWebFrame::createWindow(...) function is virtual and allows the client application to create the "new window" in the manner that it prefers. The default implementation does nothing, thus this will have no effect on the default implementation. It seems that if the client is responsible for constructing the "new window" in the manner that it deems fit, then it can be responsible for showing it too. 131896 3 32786 yael 2009-07-15 08:22:13 -0700 Created attachment 32786 Make the change only for QtLauncher As suggested in comment #2, each client is responsible for showing its own window. Thus moving the change to QtLauncher. 131902 4 32786 hausmann 2009-07-15 08:41:22 -0700 Comment on attachment 32786 Make the change only for QtLauncher r=me, thanks :) 131904 5 hausmann 2009-07-15 08:42:09 -0700 Landed in r45913 164013 6 yael 2009-11-16 09:52:25 -0800 *** Bug 29598 has been marked as a duplicate of this bug. *** 32757 2009-07-14 18:32:43 -0700 2009-07-15 08:22:13 -0700 Force the new window to be visible window.patch text/plain 1249 yael SW5kZXg6IFdlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRR dC5jcHAJKHJldmlzaW9uIDQ1ODYzKQorKysgV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1l TG9hZGVyQ2xpZW50UXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NzMsNiArODczLDggQEAKICAg ICBRV2ViUGFnZSAqbmV3UGFnZSA9IG1fd2ViRnJhbWUtPnBhZ2UoKS0+Y3JlYXRlV2luZG93KFFX ZWJQYWdlOjpXZWJCcm93c2VyV2luZG93KTsKICAgICBpZiAoIW5ld1BhZ2UpCiAgICAgICAgIHJl dHVybiAwOworICAgIGlmIChuZXdQYWdlLT52aWV3KCkpCisgICAgICAgIG5ld1BhZ2UtPnZpZXco KS0+dG9wTGV2ZWxXaWRnZXQoKS0+c2hvdygpOwogICAgIHJldHVybiBuZXdQYWdlLT5tYWluRnJh bWUoKS0+ZC0+ZnJhbWU7CiB9CiAKSW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0L3F0L0NoYW5nZUxvZwkocmV2aXNpb24gNDU4NjMpCisrKyBXZWJLaXQvcXQv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMTQgIFlh ZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNzI4NQorCisgICAgICAgIFdoZW4gb3BlbmluZyBhIG5ldyB3aW5kb3cgYnkg Y2xpY2tpbmcgb24gYW4gYW5jaG9yIHRhZyB3aXRoIGEgdGFyZ2V0IGF0dHJpYnV0ZSwgdGhhdCBu ZXcgd2luZG93IGlzIG5vdCAKKyAgICAgICAgdmlzaWJsZS4gVGhlIG5ldyB3aW5kb3cgc2hvdWxk IGJlIG1hZGUgdmlzaWJsZS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVy Q2xpZW50UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJDbGllbnRRdDo6ZGlz cGF0Y2hDcmVhdGVQYWdlKToKKwogMjAwOS0wNy0xNCAgQWRhbSBUcmVhdCAgPGFkYW0udHJlYXRA dG9yY2htb2JpbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFphY2sgUnVzaW4uCg== 32786 2009-07-15 08:22:13 -0700 2009-07-15 08:41:22 -0700 Make the change only for QtLauncher window.patch text/plain 1035 yael SW5kZXg6IFdlYktpdC9xdC9RdExhdW5jaGVyL21haW4uY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC9xdC9RdExhdW5jaGVyL21haW4uY3BwCShyZXZpc2lvbiA0NTkwOCkKKysrIFdlYktpdC9xdC9R dExhdW5jaGVyL21haW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMTAsNiArMzEwLDcgQEAKIFFX ZWJQYWdlICpXZWJQYWdlOjpjcmVhdGVXaW5kb3coUVdlYlBhZ2U6OldlYldpbmRvd1R5cGUpCiB7 CiAgICAgTWFpbldpbmRvdyAqbXcgPSBuZXcgTWFpbldpbmRvdzsKKyAgICBtdy0+c2hvdygpOwog ICAgIHJldHVybiBtdy0+d2ViUGFnZSgpOwogfQogCkluZGV4OiBXZWJLaXQvcXQvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ1OTEwKQorKysg V2ViS2l0L3F0L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDA5 LTA3LTE1ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjcyODUKKworICAgICAgICBXaGVuIHRoZSB1c2VyIGNsaWNr cyBhIGxpbmsgd2l0aCBhIHRhcmdldCBhdHRyaWJ1dGUsIHRoZSBuZXdseSBjcmVhdGVkIHdpbmRv dyBzaG91bGQgYmUgdmlzaWJsZS4KKyAgICAgICAgTWFrZSBuZXcgd2luZG93cyBjcmVhdGVkIGlu IFF0bGF1bmNoZXIgdmlzaWJsZS4KKworICAgICAgICAqIFF0TGF1bmNoZXIvbWFpbi5jcHA6Cisg ICAgICAgIChXZWJQYWdlOjpjcmVhdGVXaW5kb3cpOgorCiAyMDA5LTA3LTE0ICBBZGFtIFRyZWF0 ICA8YWRhbS50cmVhdEB0b3JjaG1vYmlsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWmFj ayBSdXNpbi4K