27284 2009-07-14 18:04:18 -0700 HTMLMediaElement::supportsFullscreen() should return false 2009-07-14 22:41:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pdherbemont pdherbemont oldest_to_newest 131776 0 pdherbemont 2009-07-14 18:04:18 -0700 But we should let HTMLMediaElement::supportsFullscreen() returns false, and be eventually overridden by the HTMLVideoElement. 131802 1 pdherbemont 2009-07-14 20:21:53 -0700 This was introduced by r45875. 131803 2 32764 pdherbemont 2009-07-14 20:30:20 -0700 Created attachment 32764 2009-07-14 Pierre d'Herbemont <pdherbemont@apple.com> Reviewed by NOBODY (OOPS!). HTMLMediaElement::supportsFullscreen() should return false https://bugs.webkit.org/show_bug.cgi?id=27284 (Reverting a part of 45875) HTMLVideoElement::supportsFullscreen() will properly do the job to check if the backend supports fullscreen. HTMLVideoElement is the only subclass to support fullscreen (conditionnaly). HTMLAudioElement fullscreen is not supported and is a different kind of fullscreen, if it comes to be wanted. No test can be done currently given that none of the backend supports fullscreen. * html/HTMLMediaElement.cpp: * html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::supportsFullscreen): --- 3 files changed, 26 insertions(+), 7 deletions(-) 131810 3 32764 oliver 2009-07-14 22:22:17 -0700 Comment on attachment 32764 2009-07-14 Pierre d'Herbemont <pdherbemont@apple.com> r=me 131813 4 pdherbemont 2009-07-14 22:41:02 -0700 r45894 32764 2009-07-14 20:30:20 -0700 2009-07-14 22:22:16 -0700 2009-07-14 Pierre d'Herbemont <pdherbemont@apple.com> bug-27284-20090714203019.patch text/plain 2117 pdherbemont ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDY3MDUzMy4uZDNhYTM5NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAwOS0wNy0xNCAgUGllcnJlIGQnSGVy YmVtb250ICA8cGRoZXJiZW1vbnRAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEhUTUxNZWRpYUVsZW1lbnQ6OnN1cHBvcnRzRnVsbHNj cmVlbigpIHNob3VsZCByZXR1cm4gZmFsc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI3Mjg0CisKKyAgICAgICAgKFJldmVydGluZyBhIHBhcnQgb2Yg NDU4NzUpCisKKyAgICAgICAgSFRNTFZpZGVvRWxlbWVudDo6c3VwcG9ydHNGdWxsc2NyZWVuKCkg d2lsbCBwcm9wZXJseSBkbyB0aGUKKyAgICAgICAgam9iIHRvIGNoZWNrIGlmIHRoZSBiYWNrZW5k IHN1cHBvcnRzIGZ1bGxzY3JlZW4uCisKKyAgICAgICAgSFRNTFZpZGVvRWxlbWVudCBpcyB0aGUg b25seSBzdWJjbGFzcyB0byBzdXBwb3J0IGZ1bGxzY3JlZW4KKyAgICAgICAgKGNvbmRpdGlvbm5h bHkpLiBIVE1MQXVkaW9FbGVtZW50IGZ1bGxzY3JlZW4gaXMgbm90IHN1cHBvcnRlZAorICAgICAg ICBhbmQgaXMgYSBkaWZmZXJlbnQga2luZCBvZiBmdWxsc2NyZWVuLCBpZiBpdCBjb21lcyB0byBi ZSB3YW50ZWQuCisKKyAgICAgICAgTm8gdGVzdCBjYW4gYmUgZG9uZSBjdXJyZW50bHkgZ2l2ZW4g dGhhdCBub25lIG9mIHRoZSBiYWNrZW5kCisgICAgICAgIHN1cHBvcnRzIGZ1bGxzY3JlZW4uCisK KyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAqIGh0bWwvSFRN TE1lZGlhRWxlbWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6c3Vw cG9ydHNGdWxsc2NyZWVuKToKKwogMjAwOS0wNy0xNCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAZ29v Z2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1MTWVk aWFFbGVtZW50LmNwcAppbmRleCAwZmE1ZDJlLi43Y2RhM2ZiIDEwMDY0NAotLS0gYS9XZWJDb3Jl L2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVs ZW1lbnQuY3BwCkBAIC04NDksMTEgKzg0OSw2IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6cmV0 dXJuVG9SZWFsdGltZSgpCiAgICAgc2V0Q3VycmVudFRpbWUobWF4VGltZVNlZWthYmxlKCksIGUp OwogfSAgCiAKLWJvb2wgSFRNTE1lZGlhRWxlbWVudDo6c3VwcG9ydHNGdWxsc2NyZWVuKCkgY29u c3QKLXsKLSAgICByZXR1cm4gbV9wbGF5ZXIgPyBtX3BsYXllci0+c3VwcG9ydHNGdWxsc2NyZWVu KCkgOiBmYWxzZTsKLX0KLQogYm9vbCBIVE1MTWVkaWFFbGVtZW50OjpzdXBwb3J0c1NhdmUoKSBj b25zdAogewogICAgIHJldHVybiBtX3BsYXllciA/IG1fcGxheWVyLT5zdXBwb3J0c1NhdmUoKSA6 IGZhbHNlOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaCBiL1dl YkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKaW5kZXggM2NkNGM0MC4uMjdiNDhlYSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaAorKysgYi9XZWJDb3JlL2h0 bWwvSFRNTE1lZGlhRWxlbWVudC5oCkBAIC02OCw4ICs2OCw5IEBAIHB1YmxpYzoKIAogICAgIHZv aWQgcmV3aW5kKGZsb2F0IHRpbWVEZWx0YSk7CiAgICAgdm9pZCByZXR1cm5Ub1JlYWx0aW1lKCk7 Ci0gICAgCi0gICAgdmlydHVhbCBib29sIHN1cHBvcnRzRnVsbHNjcmVlbigpIGNvbnN0OworCisg ICAgLy8gRXZlbnR1YWxseSBvdmVybG9hZGVkIGluIEhUTUxWaWRlb0VsZW1lbnQKKyAgICB2aXJ0 dWFsIGJvb2wgc3VwcG9ydHNGdWxsc2NyZWVuKCkgY29uc3QgeyByZXR1cm4gZmFsc2U7IH07CiAg ICAgdmlydHVhbCBib29sIHN1cHBvcnRzU2F2ZSgpIGNvbnN0OwogCiAgICAgdm9pZCBzY2hlZHVs ZUxvYWQoKTs=