27273 2009-07-14 14:43:16 -0700 [V8] Implement Reflect and ReflectURL attribute support 2009-07-14 15:00:52 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 25425 1 dglazkov dglazkov abarth darin oldest_to_newest 131680 0 dglazkov 2009-07-14 14:43:16 -0700 This is a mirror change to bug 25425 for V8 bindings. 131682 1 32736 dglazkov 2009-07-14 14:46:00 -0700 Created attachment 32736 Implement Reflect attribute support, v1. WebCore/ChangeLog | 9 ++++ WebCore/bindings/scripts/CodeGeneratorV8.pm | 62 +++++++++++++++++---------- 2 files changed, 48 insertions(+), 23 deletions(-) 131691 2 32736 abarth 2009-07-14 14:58:07 -0700 Comment on attachment 32736 Implement Reflect attribute support, v1. Will help from Dimitri, I now understand this patch. I for one welcome our new getAttribute overlords. 131692 3 dglazkov 2009-07-14 15:00:52 -0700 Landed as http://trac.webkit.org/changeset/45874. 32736 2009-07-14 14:46:00 -0700 2009-07-14 14:58:07 -0700 Implement Reflect attribute support, v1. Implement-Reflect-attribute-support-v1..patch text/plain 4860 dglazkov ZDZlNWQyNzVlMWEyODExMjE4ZWZlOTIxY2Q0YTNkMDMzOWRmMDZjMwpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMTNjYzViLi4wZDI5MWFj IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEyIEBACisyMDA5LTA3LTE0ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW1Y4XSBJbXBsZW1lbnQgUmVmbGVjdCBhbmQgUmVmbGVjdFVSTCBhdHRyaWJ1dGUgc3Vw cG9ydC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3 MjczCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbTogQWRk ZWQgc3VwcG9ydCBmb3IgUmVmbGVjdCBhbmQgUmVmbGVjdFVSTCBhdHRyaWJ1dGVzLgorCiAyMDA5 LTA3LTE0ICBEbWl0cnkgVGl0b3YgIDxkaW1pY2hAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yVjgucG0KaW5kZXggYjYyZjMyYy4uZGJmMDhhNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC01NDcsMzkgKzU0Nyw0NiBAQCBFTkQKIAog ICAgIG15ICRnZXR0ZXJTdHJpbmc7CiAgICAgaWYgKCRnZXR0ZXJTdHJpbmdVc2VzSW1wKSB7Ci0g ICAgICAgICRnZXR0ZXJTdHJpbmcgPSAiaW1wLT4kZ2V0dGVyRnVuYygiOworICAgICAgICBteSAk cmVmbGVjdCA9ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IlJl ZmxlY3QifTsKKyAgICAgICAgbXkgJHJlZmxlY3RVUkwgPSAkYXR0cmlidXRlLT5zaWduYXR1cmUt PmV4dGVuZGVkQXR0cmlidXRlcy0+eyJSZWZsZWN0VVJMIn07CisgICAgICAgIGlmICgkcmVmbGVj dCB8fCAkcmVmbGVjdFVSTCkgeworICAgICAgICAgICAgJGltcGxJbmNsdWRlc3siSFRNTE5hbWVz LmgifSA9IDE7CisgICAgICAgICAgICBteSAkY29udGVudEF0dHJpYnV0ZU5hbWUgPSAoJHJlZmxl Y3QgfHwgJHJlZmxlY3RVUkwpIGVxICIxIiA/ICRhdHRyTmFtZSA6ICgkcmVmbGVjdCB8fCAkcmVm bGVjdFVSTCk7CisgICAgICAgICAgICBteSAkZ2V0QXR0cmlidXRlRnVuY3Rpb25OYW1lID0gJHJl ZmxlY3RVUkwgPyAiZ2V0VVJMQXR0cmlidXRlIiA6ICJnZXRBdHRyaWJ1dGUiOworICAgICAgICAg ICAgJGdldHRlclN0cmluZyA9ICJpbXAtPiRnZXRBdHRyaWJ1dGVGdW5jdGlvbk5hbWUoSFRNTE5h bWVzOjoke2NvbnRlbnRBdHRyaWJ1dGVOYW1lfUF0dHIiOworICAgICAgICB9IGVsc2UgeworICAg ICAgICAgICAgJGdldHRlclN0cmluZyA9ICJpbXAtPiRnZXR0ZXJGdW5jKCI7CisgICAgICAgIH0K ICAgICAgICAgJGdldHRlclN0cmluZyAuPSAiZWMiIGlmICR1c2VFeGNlcHRpb25zOwogICAgICAg ICAkZ2V0dGVyU3RyaW5nIC49ICIpIjsKICAgICAgICAgaWYgKElzUmVmUHRyVHlwZSgkcmV0dXJu VHlwZSkpIHsKICAgICAgICAgICAgICRpbXBsSW5jbHVkZXN7Ind0Zi9HZXRQdHIuaCJ9ID0gMTsK ICAgICAgICAgICAgICRnZXR0ZXJTdHJpbmcgPSAiV1RGOjpnZXRQdHIoIiAuICRnZXR0ZXJTdHJp bmcgLiAiKSI7CiAgICAgICAgIH0KLSAgICAgICAgaWYgKCRuYXRpdmVUeXBlIGVxICJpbnQiIGFu ZAotICAgICAgICAgICAgJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMt PnsiQ29udmVydEZyb21TdHJpbmcifSkgewotICAgICAgICAgICAgICAgICRnZXR0ZXJTdHJpbmcg Lj0gIi50b0ludCgpIjsKLSAgICAgICAgICAgIH0KLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAg ICAgICRnZXR0ZXJTdHJpbmcgPSAiaW1wX2luc3RhbmNlIjsKLSAgICAgICAgfQotICAgICAgICBp ZiAoJG5hdGl2ZVR5cGUgZXEgIlN0cmluZyIpIHsKLSAgICAgICAgICAgICRnZXR0ZXJTdHJpbmcg PSAidG9TdHJpbmcoJGdldHRlclN0cmluZykiOworICAgICAgICBpZiAoJG5hdGl2ZVR5cGUgZXEg ImludCIgYW5kICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkNv bnZlcnRGcm9tU3RyaW5nIn0pIHsKKyAgICAgICAgICAgICRnZXR0ZXJTdHJpbmcgLj0gIi50b0lu dCgpIjsKICAgICAgICAgfQorICAgIH0gZWxzZSB7CisgICAgICAgICRnZXR0ZXJTdHJpbmcgPSAi aW1wX2luc3RhbmNlIjsKKyAgICB9CiAKLSAgICAgICAgbXkgJHJlc3VsdDsKLSAgICAgICAgbXkg JHdyYXBwZXI7CisgICAgaWYgKCRuYXRpdmVUeXBlIGVxICJTdHJpbmciKSB7CisgICAgICAgICRn ZXR0ZXJTdHJpbmcgPSAidG9TdHJpbmcoJGdldHRlclN0cmluZykiOworICAgIH0KIAotICAgICAg ICBpZiAoJGF0dHJJc1BvZFR5cGUpIHsKLSAgICAgICAgICAgICRpbXBsSW5jbHVkZXN7IlY4U1ZH UE9EVHlwZVdyYXBwZXIuaCJ9ID0gMTsKKyAgICBteSAkcmVzdWx0OworICAgIG15ICR3cmFwcGVy OwogCi0gICAgICAgICAgICBteSAkZ2V0dGVyID0gJGdldHRlclN0cmluZzsKLSAgICAgICAgICAg ICRnZXR0ZXIgPX4gcy9pbXAtPi8vOwotICAgICAgICAgICAgJGdldHRlciA9fiBzL1woXCkvLzsK LSAgICAgICAgICAgIG15ICRzZXR0ZXIgPSAic2V0IiAuIFdLX3VjZmlyc3QoJGdldHRlcik7Cisg ICAgaWYgKCRhdHRySXNQb2RUeXBlKSB7CisgICAgICAgICRpbXBsSW5jbHVkZXN7IlY4U1ZHUE9E VHlwZVdyYXBwZXIuaCJ9ID0gMTsKIAotICAgICAgICAgICAgbXkgJGltcGxDbGFzc0lzQW5pbWF0 ZWRUeXBlID0gJGNvZGVHZW5lcmF0b3ItPklzU1ZHQW5pbWF0ZWRUeXBlKCRpbXBsQ2xhc3NOYW1l KTsKLSAgICAgICAgICAgIGlmIChub3QgJGltcGxDbGFzc0lzQW5pbWF0ZWRUeXBlCi0gICAgICAg ICAgICAgICAgYW5kICRjb2RlR2VuZXJhdG9yLT5Jc1BvZFR5cGVXaXRoV3JpdGVhYmxlUHJvcGVy dGllcygkYXR0clR5cGUpCi0gICAgICAgICAgICAgICAgYW5kIG5vdCBkZWZpbmVkICRhdHRyaWJ1 dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkltbXV0YWJsZSJ9KSB7CisgICAg ICAgIG15ICRnZXR0ZXIgPSAkZ2V0dGVyU3RyaW5nOworICAgICAgICAkZ2V0dGVyID1+IHMvaW1w LT4vLzsKKyAgICAgICAgJGdldHRlciA9fiBzL1woXCkvLzsKKyAgICAgICAgbXkgJHNldHRlciA9 ICJzZXQiIC4gV0tfdWNmaXJzdCgkZ2V0dGVyKTsKKworICAgICAgICBteSAkaW1wbENsYXNzSXNB bmltYXRlZFR5cGUgPSAkY29kZUdlbmVyYXRvci0+SXNTVkdBbmltYXRlZFR5cGUoJGltcGxDbGFz c05hbWUpOworICAgICAgICBpZiAobm90ICRpbXBsQ2xhc3NJc0FuaW1hdGVkVHlwZSBhbmQgJGNv ZGVHZW5lcmF0b3ItPklzUG9kVHlwZVdpdGhXcml0ZWFibGVQcm9wZXJ0aWVzKCRhdHRyVHlwZSkg YW5kIG5vdCBkZWZpbmVkICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVz LT57IkltbXV0YWJsZSJ9KSB7CiAgICAgICAgICAgICBpZiAoSXNQb2RUeXBlKCRpbXBsQ2xhc3NO YW1lKSkgewogICAgICAgICAgICAgICAgICR3cmFwcGVyID0gIm5ldyBWOFNWR1N0YXRpY1BPRFR5 cGVXcmFwcGVyV2l0aFBPRFR5cGVQYXJlbnQ8JG5hdGl2ZVR5cGUsICRpbXBsQ2xhc3NOYW1lPigk Z2V0dGVyU3RyaW5nLCBpbXBfd3JhcHBlcikiOwogICAgICAgICAgICAgfSBlbHNlIHsKQEAgLTcx OCw3ICs3MjUsMTYgQEAgRU5ECiAgICAgaWYgKCRpbXBsQ2xhc3NOYW1lIGVxICJkb3VibGUiKSB7 CiAgICAgICAgIHB1c2goQGltcGxDb250ZW50RGVjbHMsICIgICAgKmltcCA9ICRyZXN1bHQ7XG4i KTsKICAgICB9IGVsc2UgewotICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCAiICAgIGlt cC0+c2V0IiAuIFdLX3VjZmlyc3QoJGF0dHJOYW1lKSAuICIoIiAuICRyZXN1bHQpOworICAgICAg ICBteSAkaW1wbFNldHRlckZ1bmN0aW9uTmFtZSA9IFdLX3VjZmlyc3QoJGF0dHJOYW1lKTsKKyAg ICAgICAgbXkgJHJlZmxlY3QgPSAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmli dXRlcy0+eyJSZWZsZWN0In07CisgICAgICAgIG15ICRyZWZsZWN0VVJMID0gJGF0dHJpYnV0ZS0+ c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiUmVmbGVjdFVSTCJ9OworICAgICAgICBp ZiAoJHJlZmxlY3QgfHwgJHJlZmxlY3RVUkwpIHsKKyAgICAgICAgICAgICRpbXBsSW5jbHVkZXN7 IkhUTUxOYW1lcy5oIn0gPSAxOworICAgICAgICAgICAgbXkgJGNvbnRlbnRBdHRyaWJ1dGVOYW1l ID0gKCRyZWZsZWN0IHx8ICRyZWZsZWN0VVJMKSBlcSAiMSIgPyAkYXR0ck5hbWUgOiAoJHJlZmxl Y3QgfHwgJHJlZmxlY3RVUkwpOworICAgICAgICAgICAgcHVzaChAaW1wbENvbnRlbnREZWNscywg IiAgICBpbXAtPnNldEF0dHJpYnV0ZShIVE1MTmFtZXM6OiR7Y29udGVudEF0dHJpYnV0ZU5hbWV9 QXR0ciwgJHJlc3VsdCIpOworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgcHVzaChAaW1w bENvbnRlbnREZWNscywgIiAgICBpbXAtPnNldCRpbXBsU2V0dGVyRnVuY3Rpb25OYW1lKCIgLiAk cmVzdWx0KTsKKyAgICAgICAgfQogICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCAiLCBl YyIpIGlmICR1c2VFeGNlcHRpb25zOwogICAgICAgICBwdXNoKEBpbXBsQ29udGVudERlY2xzLCAi KTtcbiIpOwogICAgIH0K