27271 2009-07-14 12:26:45 -0700 [V8] Fix isolated world wrappers for Nodes 2009-07-14 16:37:42 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth abarth aa dglazkov oldest_to_newest 131633 0 abarth 2009-07-14 12:26:45 -0700 We're getting the wrong wrappers for nodes because the DOMMap is stored on V8Proxy, subverting the branch in V8DOMMap.cpp. Patch forthcoming. 131635 1 32728 abarth 2009-07-14 12:34:15 -0700 Created attachment 32728 patch By the way, you can see the test suite I'm working from here: http://codereview.chromium.org/149193 Once I get these tests in reasonable shape, I can turn on the feature and land the tests. 131636 2 32728 dglazkov 2009-07-14 12:37:10 -0700 Comment on attachment 32728 patch Fix _and_ prettify. I like it. 131643 3 abarth 2009-07-14 12:44:41 -0700 Thanks. I'm working on a bunch of related changes in a git branch. I'll try to land them roughly together. 131747 4 abarth 2009-07-14 16:37:42 -0700 Sending WebCore/ChangeLog Sending WebCore/bindings/v8/V8DOMWrapper.cpp Sending WebCore/bindings/v8/V8Proxy.h Transmitting file data ... Committed revision 45882. http://trac.webkit.org/changeset/45882 32728 2009-07-14 12:34:15 -0700 2009-07-14 12:37:10 -0700 patch node-wrapper.patch text/plain 2707 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTg2MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMDktMDctMTQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbVjhd IEZpeCBpc29sYXRlZCB3b3JsZCB3cmFwcGVycyBmb3IgTm9kZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3MjcxCisKKyAgICAgICAgUHJldmlvdXNs eSwgd2Uga2VlcHkgYSBwb2ludGVyIHRvIHRoZSBET01NYXAgb24gVjhQcm94eSwgYnV0IHRoaXMK KyAgICAgICAgY2F1c2VkIHVzIHRvIG1pc3MgdGhlIGJyYW5jaCBpbiBWOERPTU1hcC5jcHAgZm9y IGlzb2xhdGVkIHdvcmxkcy4KKworICAgICAgICBJIGhhdmUgdGVzdHMsIGJ1dCBJIGNhbid0IGxh bmQgdGhlbSB1bnRpbCBJIGdldCB0aGlzIGZlYXR1cmUgdW5kZXIKKyAgICAgICAgY29udHJvbC4K KworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpWOERPTVdyYXBwZXI6OmNvbnZlcnROb2RlVG9WOE9iamVjdCk6CisgICAgICAgICogYmlu ZGluZ3MvdjgvVjhQcm94eS5oOgorICAgICAgICAoV2ViQ29yZTo6VjhQcm94eTo6VjhQcm94eSk6 CisKIDIwMDktMDctMTQgIEFkYW0gVHJlYXQgIDxhZGFtLnRyZWF0QHRvcmNobW9iaWxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBIeWF0dC4KSW5kZXg6IFdlYkNvcmUvYmluZGlu Z3MvdjgvVjhET01XcmFwcGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4RE9NV3JhcHBlci5jcHAJKHJldmlzaW9uIDQ1ODU0KQorKysgV2ViQ29yZS9iaW5kaW5ncy92 OC9WOERPTVdyYXBwZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDg3LDcgKzEwODcsNyBAQCB2 ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhET01XcmFwcGVyOjpjb252CiAgICAgICAgICAgICBwcm94 eS0+aW5pdENvbnRleHRJZk5lZWRlZCgpOwogICAgIH0KIAotICAgIERPTVdyYXBwZXJNYXA8Tm9k ZT4mIGRvbU5vZGVNYXAgPSBwcm94eSA/IHByb3h5LT5kb21Ob2RlTWFwKCkgOiBnZXRET01Ob2Rl TWFwKCk7CisgICAgRE9NV3JhcHBlck1hcDxOb2RlPiYgZG9tTm9kZU1hcCA9IGdldERPTU5vZGVN YXAoKTsKICAgICB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IHdyYXBwZXIgPSBkb21Ob2RlTWFwLmdl dChub2RlKTsKICAgICBpZiAoIXdyYXBwZXIuSXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gd3Jh cHBlcjsKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCShyZXZpc2lvbiA0NTg1NCkKKysrIFdlYkNv cmUvYmluZGluZ3MvdjgvVjhQcm94eS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNTgsNyArMTU4LDcg QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAgR2VuZXJhbEVycm9yCiAgICAgICAg IH07CiAKLSAgICAgICAgZXhwbGljaXQgVjhQcm94eShGcmFtZSogZnJhbWUpIDogbV9mcmFtZShm cmFtZSksIG1fZG9tTm9kZU1hcChnZXRET01Ob2RlTWFwKCkpLCBtX2lubGluZUNvZGUoZmFsc2Up LCBtX3RpbWVyQ2FsbGJhY2soZmFsc2UpLCBtX3JlY3Vyc2lvbigwKSB7IH0KKyAgICAgICAgZXhw bGljaXQgVjhQcm94eShGcmFtZSogZnJhbWUpIDogbV9mcmFtZShmcmFtZSksIG1faW5saW5lQ29k ZShmYWxzZSksIG1fdGltZXJDYWxsYmFjayhmYWxzZSksIG1fcmVjdXJzaW9uKDApIHsgfQogCiAg ICAgICAgIH5WOFByb3h5KCk7CiAKQEAgLTM2MCw3ICszNjAsNiBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAgICAgICAgIGJvb2wgaW5zdGFsbERPTVdpbmRvdyh2ODo6SGFuZGxlPHY4OjpDb250ZXh0 PiBjb250ZXh0LCBET01XaW5kb3cqIHdpbmRvdyk7CiAKICAgICAgICAgdm9pZCBpbml0Q29udGV4 dElmTmVlZGVkKCk7Ci0gICAgICAgIERPTVdyYXBwZXJNYXA8Tm9kZT4mIGRvbU5vZGVNYXAoKSB7 IHJldHVybiBtX2RvbU5vZGVNYXA7IH0KICAgICAgICAgdm9pZCB1cGRhdGVEb2N1bWVudFdyYXBw ZXIodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHdyYXBwZXIpOwogCiAgICAgcHJpdmF0ZToKQEAgLTQx OSw4ICs0MTgsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHY4OjpQZXJzaXN0ZW50 PHY4OjpPYmplY3Q+IG1fZ2xvYmFsOwogICAgICAgICB2ODo6UGVyc2lzdGVudDx2ODo6VmFsdWU+ IG1fZG9jdW1lbnQ7CiAKLSAgICAgICAgRE9NV3JhcHBlck1hcDxOb2RlPiYgbV9kb21Ob2RlTWFw OwotCiAgICAgICAgIC8vIFV0aWxpdHkgY29udGV4dCBob2xkaW5nIEphdmFTY3JpcHQgZnVuY3Rp b25zIHVzZWQgaW50ZXJuYWxseS4KICAgICAgICAgc3RhdGljIHY4OjpQZXJzaXN0ZW50PHY4OjpD b250ZXh0PiBtX3V0aWxpdHlDb250ZXh0OwogCg==