27268 2009-07-14 11:20:02 -0700 [V8] Fix isolated world crash on getting window.location 2009-07-14 16:09:24 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth abarth aa abarth dglazkov oldest_to_newest 131617 0 abarth 2009-07-14 11:20:02 -0700 The isolated world crashes it tries to get window.location. We shouldn't crash. Patch forthcoming. 131619 1 32723 abarth 2009-07-14 11:27:14 -0700 Created attachment 32723 patch 131674 2 32723 dglazkov 2009-07-14 14:31:34 -0700 Comment on attachment 32723 patch ok. 131677 3 abarth 2009-07-14 14:36:16 -0700 Assigned to myself for landing. 131736 4 abarth 2009-07-14 16:09:24 -0700 Sending WebCore/ChangeLog Sending WebCore/bindings/v8/V8DOMWrapper.cpp Sending WebCore/bindings/v8/V8IsolatedWorld.h Transmitting file data ... Committed revision 45880. http://trac.webkit.org/changeset/45880 32723 2009-07-14 11:27:14 -0700 2009-07-14 14:31:34 -0700 patch location-crash.patch text/plain 2030 abarth SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTg2MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDctMTQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbVjhd IEZpeCBpc29sYXRlZCB3b3JsZCBjcmFzaCBvbiBnZXR0aW5nIHdpbmRvdy5sb2NhdGlvbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjcyNjgKKworICAg ICAgICBJIGhhdmUgYSB0ZXN0IGZvciB0aGlzIGxvY2FsbHksIGJ1dCBpdCByZXF1aXJlcyBhIGNv bXBpbGUtdGltZSBoYWNrIHRvCisgICAgICAgIHJ1bi4gIE9uY2UgSSBnZXQgdGhlIGZlYXR1cmUn cyBzdGFiaWxpdHkgdW5kZXIgY29udHJvbCwgd2UgY2FuIHR1cm4gdGhlCisgICAgICAgIGZlYXR1 cmUgb24gYW5kIGFkZCB0aGUgdGVzdHMuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdy YXBwZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhET01XcmFwcGVyOjpzZXRIaWRkZW5XaW5k b3dSZWZlcmVuY2UpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4SXNvbGF0ZWRXb3JsZC5oOgor ICAgICAgICAoV2ViQ29yZTo6VjhJc29sYXRlZFdvcmxkOjpjb250ZXh0KToKKwogMjAwOS0wNy0x NCAgQWRhbSBUcmVhdCAgPGFkYW0udHJlYXRAdG9yY2htb2JpbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhdmlkIEh5YXR0LgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdy YXBwZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVy LmNwcAkocmV2aXNpb24gNDU4NTQpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBl ci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU4Miw2ICs1ODIsMTIgQEAgdm9pZCBWOERPTVdyYXBw ZXI6OnNldEhpZGRlbldpbmRvd1JlZmVyZQogICAgIGlmICh2OENvbnRleHQuSXNFbXB0eSgpKQog ICAgICAgICByZXR1cm47CiAKKyAgICBpZiAoVjhJc29sYXRlZFdvcmxkKiB3b3JsZCA9IFY4SXNv bGF0ZWRXb3JsZDo6Z2V0RW50ZXJlZCgpKSB7CisgICAgICAgdjhDb250ZXh0ID0gd29ybGQtPmNv bnRleHQoKTsKKyAgICAgICBpZiAoZnJhbWUgIT0gVjhQcm94eTo6cmV0cmlldmVGcmFtZSh2OENv bnRleHQpKQorICAgICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgQVNTRVJUKGludGVybmFs SW5kZXggPCBWOEN1c3RvbTo6a0RPTVdpbmRvd0ludGVybmFsRmllbGRDb3VudCk7CiAKICAgICB2 ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGdsb2JhbCA9IHY4Q29udGV4dC0+R2xvYmFsKCk7CkluZGV4 OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SXNvbGF0ZWRXb3JsZC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvYmluZGluZ3MvdjgvVjhJc29sYXRlZFdvcmxkLmgJKHJldmlzaW9uIDQ1ODU0KQorKysg V2ViQ29yZS9iaW5kaW5ncy92OC9WOElzb2xhdGVkV29ybGQuaAkod29ya2luZyBjb3B5KQpAQCAt NzMsNiArNzMsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIC8vCiAgICAgICAgIHN0 YXRpYyBWOElzb2xhdGVkV29ybGQqIGdldEVudGVyZWQoKTsKIAorICAgICAgICB2ODo6SGFuZGxl PHY4OjpDb250ZXh0PiBjb250ZXh0KCkgeyByZXR1cm4gbV9jb250ZXh0OyB9CisKICAgICAgICAg RE9NRGF0YVN0b3JlKiBnZXRET01EYXRhU3RvcmUoKSBjb25zdCB7IHJldHVybiBtX2RvbURhdGFT dG9yZS5nZXRTdG9yZSgpOyB9CiAKICAgICBwcml2YXRlOgo=