27267 2009-07-14 10:33:07 -0700 HTTP Accept header gives preference of XML over HTML 2024-08-09 11:40:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED http://newmediacampaigns.com/page/webkit-team-admits-accept-header-error P2 Normal --- 1 krisjordan webkit-unassigned ap cascardo commit-queue james-nospam matt mike mjs ssp-web t.tom warlocketdingoal yustin.knows oldest_to_newest 131606 0 krisjordan 2009-07-14 10:33:07 -0700 For developers wanting to use the HTTP protocol to implement RESTful content negotiation where resources can be represented as HTML or XML WebKit unhelpfully prefers XML over HTML. Marciej has acknowledged this error: "Most WebKit-based browsers (and Safari in particular) would probably do a better job rendering HTML than XHTML or generic XML, if only because the code paths are much better tested. So the Accept header is somewhat in error." Here is a demo URL that will be opened in XML in WebKit and HTML in Firefox 3+: http://recessframework.org/demo/content-negotiation/tweet The accept header appears to be defined on line 200 of WebCore/loader/FrameLoader.cpp I recommend two alternatives: Copy Firefox 3.5's: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8 or Simplify: text/html,*/* For more background information please see: http://newmediacampaigns.com/page/browser-rest-http-accept-headers http://newmediacampaigns.com/page/webkit-team-admits-accept-header-error Thanks! 131634 1 mrowe 2009-07-14 12:30:57 -0700 This could be considered to be a duplicate of bug 12296. 131745 2 mjs 2009-07-14 16:31:41 -0700 bug 12296 made a specific proposal for how to change Accept, but I think following the lead of Firefox 3.5 would be better than the suggested header in that bug. So not quite a duplicate. 135744 3 matt 2009-07-29 17:15:52 -0700 FWIW, here are some other default ACCEPT headers: IE8: image/gif, image/jpeg, image/pjpeg, image/pjpeg, application/x-shockwave-flash, application/xaml+xml, application/vnd.ms-xpsdocument, application/x-ms-xbap, application/x-ms-application, application/vnd.ms-excel, application/vnd.ms-powerpoint, application/msword, application/x-silverlight, */* Opera: text/html, application/xml;q=0.9, application/xhtml+xml, image/png, image/jpeg, image/gif, image/x-xbitmap, */*;q=0.1 Chrome: application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5 218382 4 ssp-web 2010-04-28 07:10:17 -0700 I had troubles with Safari on author URLs at the arXiv preprint server: e.g. http://arxiv.org/a/bahns_d_1 While this works perfectly in Firefox (returning and displaying HTML content, presumably because it has text/html as its first accept header), it gives a poor experience in Safari because the server takes the application/xml Accept header as a hint that we'd really prefer prefer XML/Atom format content and then redirects to the Atom feed. That, in turn, causes Safari to not display the page at all on my machine but to launch my separate RSS reader and open it there. I.e. it results in rather annoying behaviour. Just in case you needed another example where the difference in Accept headers causes real-world differences in the results seen by the user. 249152 5 ap 2010-07-09 11:47:49 -0700 *** Bug 41914 has been marked as a duplicate of this bug. *** 351182 6 yustin.knows 2011-02-15 03:30:31 -0800 This bug has been around quite a while and has last been updated half a year ago. Since I as a backend developer ran into the same problem lately and had to do some seriously ugly hacks, that change the accept header, reciefed from a webkit request to something more desent on my server... Has there been any progress in this problem. Are there any plans to implement a better accept-header in webkit in the near future? Regards, Yustin 351389 7 ap 2011-02-15 10:28:13 -0800 I think that there is consensus about making the Accept string match Firefox again (the current one matches an older version). Someone just needs to do the work: <http://www.webkit.org/coding/contributing.html>. 351424 8 krisjordan 2011-02-15 11:17:58 -0800 I'll take a stab here shortly. (In reply to comment #7) > I think that there is consensus about making the Accept string match Firefox again (the current one matches an older version). Someone just needs to do the work: <http://www.webkit.org/coding/contributing.html>. 351491 9 82505 krisjordan 2011-02-15 12:37:47 -0800 Created attachment 82505 Patch to fix the bug with solution described in bug thread. The default accept header now mirror's FireFox'. The meaningful change is that 'text/html' is now preferred over 'application/xml'. 351496 10 james-nospam 2011-02-15 12:44:04 -0800 Thanks for taking this on Kris. The file LayoutTests/http/tests/misc/xhtml-expected.txt will need to be changed as well. This test calls xhtml.php, which echos the accept header back to the client. It needs to match the file above to pass the test. 351499 11 ap 2011-02-15 12:46:01 -0800 The link I gave above (<http://www.webkit.org/coding/contributing.html>) mentions running layout tests, as well as some other necessary steps. 351503 12 82508 krisjordan 2011-02-15 12:53:24 -0800 Created attachment 82508 Patch with Tests The expected result of the xhtml test is now included in the patch. 365202 13 yustin.knows 2011-03-10 08:28:43 -0800 So there is a patch now. good. :) Any chance of getting this patch into an official release anytime soon? The bug is still in the 'NEW' Status. 365225 14 ap 2011-03-10 08:58:22 -0800 Please mark the patch for review by clicking Details link to the right of it. Otherwise, looks fine at a first glance. 365236 15 krisjordan 2011-03-10 09:16:49 -0800 Marked for review (I believe). Let me know if I did not do that correctly. 365260 16 ap 2011-03-10 09:55:20 -0800 It should be r?, not r+. 365265 17 krisjordan 2011-03-10 10:00:01 -0800 That makes sense- sorry, first time through. Updated accordingly. 365271 18 82508 ap 2011-03-10 10:08:54 -0800 Comment on attachment 82508 Patch with Tests I don't understand the change in XHTMLMP case. Why downgrade application/xml, but not application/xhtml+xml? I suggest leaving XHTMLMP unchanged, for people who care about it (if any) to consider consequences of changing the Accept string. 365305 19 james-nospam 2011-03-10 10:46:08 -0800 My understanding is that XHTMLMP is not used in any products, so this is pure theoretical and I only post this as an FYI. According to http://www.passani.it/gap/#MIME_TYPE application/xml is not a recommended content-type for mobile. It also says application/xhtml+xml is a better choice than text/html. The current patch (id= 82508) is consistent with best practices as of April 2010. 365320 20 krisjordan 2011-03-10 11:02:45 -0800 (In reply to comment #18) > (From update of attachment 82508 [details]) > I don't understand the change in XHTMLMP case. Why downgrade application/xml, but not application/xhtml+xml? Two motivations: 1) The heart of this issue is making sure application/xml is downgraded below text/html. How text/html and application/xhtml+xml are arranged is, relatively, inconsequential. I did not want to change any more than was necessary to resolve the fundamental issue of this ticket. 2) (This is *much* more nit picking and *much* less important.) 'application/xhtml+xml;profile='http://www.wapforum.org/xhtml' is not equivalent to 'application/xhtml'. It implies the server should only serve application/xhtml+xml if it can do so with that specific WAP profile. Technically, by the HTTP spec, the XHTMLMP accept header prioritizes a generic 'application/xhtml' below 'application/xml' because it falls under the expansion of */*. In practice, servers often ignore the profile parameter. > I suggest leaving XHTMLMP unchanged, for people who care about it (if any) to consider consequences of changing the Accept string. I don't know who or what uses the XHTMLMP case, and I don't have a problem leaving it alone, but I do believe it is a win to get HTML > XML in any case. Let me know if you need me to resubmit sans the XHTMLMP change for this to continue making progress. 365332 21 82508 ap 2011-03-10 11:16:36 -0800 Comment on attachment 82508 Patch with Tests OK. 365592 22 82508 commit-queue 2011-03-10 15:44:06 -0800 Comment on attachment 82508 Patch with Tests Clearing flags on attachment: 82508 Committed r80776: <http://trac.webkit.org/changeset/80776> 365593 23 commit-queue 2011-03-10 15:44:10 -0800 All reviewed patches have been landed. Closing bug. 365680 24 krisjordan 2011-03-10 17:05:31 -0800 Thanks for reviewing and getting it in the commit queue Alexey! Great to see this ticket resolved. 82505 2011-02-15 12:37:47 -0800 2011-02-15 12:53:24 -0800 Patch to fix the bug with solution described in bug thread. BugFix27267.txt text/plain 2067 krisjordan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NjAxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMTUgIEtyaXMgSm9y ZGFuICA8a3Jpc2pvcmRhbkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSW1wcm92ZSBkZWZhdWx0IEFjY2VwdCBoZWFkZXIgdG8gZ2l2 ZSBwcmVmZXJlbmNlIHRvIEhUTUwgb3ZlciBYTUwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzI2NworCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9h ZGVyLmNwcDpDaGFuZ2VkIGRlZmF1bHQgYWNjZXB0IGhlYWRlciB0byBtYXRjaAorICAgICAgICBG aXJlRm94JyBhcyBwZXIgYnVnIDI3MjY3LgorCiAyMDExLTAyLTE1ICBBbmRyZWFzIEtsaW5nICA8 a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNpb24gNzg1OTIpCisr KyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC00LDYgKzQsNyBAQAogICogQ29weXJpZ2h0IChDKSAyMDA4LCAyMDA5IFRvcmNoIE1vYmlsZSBJ bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuIChodHRwOi8vd3d3LnRvcmNobW9iaWxlLmNvbS8pCiAg KiBDb3B5cmlnaHQgKEMpIDIwMDggQWxwIFRva2VyIDxhbHBAYXRva2VyLmNvbT4KICAqIENvcHly aWdodCAoQykgUmVzZWFyY2ggSW4gTW90aW9uIExpbWl0ZWQgMjAwOS4gQWxsIHJpZ2h0cyByZXNl cnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMSBLcmlzIEpvcmRhbiA8a3Jpc2pvcmRhbkBnbWFp bC5jb20+CiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFy eSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQg cHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTEyNSw5ICsxMjYsOSBA QCB1c2luZyBuYW1lc3BhY2UgU1ZHTmFtZXM7CiAjZW5kaWYKIAogI2lmIEVOQUJMRShYSFRNTE1Q KQotc3RhdGljIGNvbnN0IGNoYXIgZGVmYXVsdEFjY2VwdEhlYWRlcltdID0gImFwcGxpY2F0aW9u L3htbCxhcHBsaWNhdGlvbi92bmQud2FwLnhodG1sK3htbCxhcHBsaWNhdGlvbi94aHRtbCt4bWw7 cHJvZmlsZT0naHR0cDovL3d3dy53YXBmb3J1bS5vcmcveGh0bWwnLHRleHQvaHRtbDtxPTAuOSx0 ZXh0L3BsYWluO3E9MC44LGltYWdlL3BuZywqLyo7cT0wLjUiOworc3RhdGljIGNvbnN0IGNoYXIg ZGVmYXVsdEFjY2VwdEhlYWRlcltdID0gImFwcGxpY2F0aW9uL3ZuZC53YXAueGh0bWwreG1sLGFw cGxpY2F0aW9uL3hodG1sK3htbDtwcm9maWxlPSdodHRwOi8vd3d3LndhcGZvcnVtLm9yZy94aHRt bCcsdGV4dC9odG1sLGFwcGxpY2F0aW9uL3htbDtxPTAuOSwqLyo7cT0wLjgiOwogI2Vsc2UKLXN0 YXRpYyBjb25zdCBjaGFyIGRlZmF1bHRBY2NlcHRIZWFkZXJbXSA9ICJhcHBsaWNhdGlvbi94bWws YXBwbGljYXRpb24veGh0bWwreG1sLHRleHQvaHRtbDtxPTAuOSx0ZXh0L3BsYWluO3E9MC44LGlt YWdlL3BuZywqLyo7cT0wLjUiOworc3RhdGljIGNvbnN0IGNoYXIgZGVmYXVsdEFjY2VwdEhlYWRl cltdID0gInRleHQvaHRtbCxhcHBsaWNhdGlvbi94aHRtbCt4bWwsYXBwbGljYXRpb24veG1sO3E9 MC45LCovKjtxPTAuOCI7CiAjZW5kaWYKIAogc3RhdGljIGRvdWJsZSBzdG9yZWRUaW1lT2ZMYXN0 Q29tcGxldGVkTG9hZDsK 82508 2011-02-15 12:53:24 -0800 2011-03-10 15:44:06 -0800 Patch with Tests BugFix27267.txt text/plain 3156 krisjordan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NjAxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDItMTUgIEtyaXMgSm9y ZGFuICA8a3Jpc2pvcmRhbkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSW1wcm92ZSBkZWZhdWx0IEFjY2VwdCBoZWFkZXIgdG8gZ2l2 ZSBwcmVmZXJlbmNlIHRvIEhUTUwgb3ZlciBYTUwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzI2NworCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9h ZGVyLmNwcDpDaGFuZ2VkIGRlZmF1bHQgYWNjZXB0IGhlYWRlciB0byBtYXRjaAorICAgICAgICBG aXJlRm94JyBhcyBwZXIgYnVnIDI3MjY3LgorCiAyMDExLTAyLTE1ICBBbmRyZWFzIEtsaW5nICA8 a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNpb24gNzg1OTIpCisr KyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC00LDYgKzQsNyBAQAogICogQ29weXJpZ2h0IChDKSAyMDA4LCAyMDA5IFRvcmNoIE1vYmlsZSBJ bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuIChodHRwOi8vd3d3LnRvcmNobW9iaWxlLmNvbS8pCiAg KiBDb3B5cmlnaHQgKEMpIDIwMDggQWxwIFRva2VyIDxhbHBAYXRva2VyLmNvbT4KICAqIENvcHly aWdodCAoQykgUmVzZWFyY2ggSW4gTW90aW9uIExpbWl0ZWQgMjAwOS4gQWxsIHJpZ2h0cyByZXNl cnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMSBLcmlzIEpvcmRhbiA8a3Jpc2pvcmRhbkBnbWFp bC5jb20+CiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFy eSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQg cHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTEyNSw5ICsxMjYsOSBA QCB1c2luZyBuYW1lc3BhY2UgU1ZHTmFtZXM7CiAjZW5kaWYKIAogI2lmIEVOQUJMRShYSFRNTE1Q KQotc3RhdGljIGNvbnN0IGNoYXIgZGVmYXVsdEFjY2VwdEhlYWRlcltdID0gImFwcGxpY2F0aW9u L3htbCxhcHBsaWNhdGlvbi92bmQud2FwLnhodG1sK3htbCxhcHBsaWNhdGlvbi94aHRtbCt4bWw7 cHJvZmlsZT0naHR0cDovL3d3dy53YXBmb3J1bS5vcmcveGh0bWwnLHRleHQvaHRtbDtxPTAuOSx0 ZXh0L3BsYWluO3E9MC44LGltYWdlL3BuZywqLyo7cT0wLjUiOworc3RhdGljIGNvbnN0IGNoYXIg ZGVmYXVsdEFjY2VwdEhlYWRlcltdID0gImFwcGxpY2F0aW9uL3ZuZC53YXAueGh0bWwreG1sLGFw cGxpY2F0aW9uL3hodG1sK3htbDtwcm9maWxlPSdodHRwOi8vd3d3LndhcGZvcnVtLm9yZy94aHRt bCcsdGV4dC9odG1sLGFwcGxpY2F0aW9uL3htbDtxPTAuOSwqLyo7cT0wLjgiOwogI2Vsc2UKLXN0 YXRpYyBjb25zdCBjaGFyIGRlZmF1bHRBY2NlcHRIZWFkZXJbXSA9ICJhcHBsaWNhdGlvbi94bWws YXBwbGljYXRpb24veGh0bWwreG1sLHRleHQvaHRtbDtxPTAuOSx0ZXh0L3BsYWluO3E9MC44LGlt YWdlL3BuZywqLyo7cT0wLjUiOworc3RhdGljIGNvbnN0IGNoYXIgZGVmYXVsdEFjY2VwdEhlYWRl cltdID0gInRleHQvaHRtbCxhcHBsaWNhdGlvbi94aHRtbCt4bWwsYXBwbGljYXRpb24veG1sO3E9 MC45LCovKjtxPTAuOCI7CiAjZW5kaWYKIAogc3RhdGljIGRvdWJsZSBzdG9yZWRUaW1lT2ZMYXN0 Q29tcGxldGVkTG9hZDsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDc4NjAzKQorKysgTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDItMTUgIEty aXMgSm9yZGFuICA8a3Jpc2pvcmRhbkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdGluZyB0aGUgaW1wcm92ZWQgQWNjZXB0IGhl YWRlciBhcyBwZXIgYnVnIDI3MjY3LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjcyNjcKKworICAgICAgICAqIGh0dHAvdGVzdHMvbWlzYy94aHRtbC1l eHBlY3RlZC50eHQ6IFRlc3RzIGFnYWluc3QgaW1wcm92ZWQgQWNjZXB0IGhlYWRlci4KKwogMjAx MS0wMi0xNSAgU3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkOyBuZXcgQ2hyb21pdW0vTGludXggdGVzdCBiYXNlbGluZXMuCkluZGV4 OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MveGh0bWwtZXhwZWN0ZWQudHh0Cj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy94aHRtbC1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDc4NTkyKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL3hodG1sLWV4cGVj dGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMgQEAKLUFjY2VwdDogYXBwbGljYXRp b24veG1sLGFwcGxpY2F0aW9uL3hodG1sK3htbCx0ZXh0L2h0bWw7cT0wLjksdGV4dC9wbGFpbjtx PTAuOCxpbWFnZS9wbmcsKi8qO3E9MC41CitBY2NlcHQ6IHRleHQvaHRtbCxhcHBsaWNhdGlvbi94 aHRtbCt4bWwsYXBwbGljYXRpb24veG1sO3E9MC45LCovKjtxPTAuOAogCiBQQVNTOiBUaGUgYnJv d3NlciBhc2tzIGZvciBYSFRNTC4K