27262 2009-07-14 08:13:17 -0700 Chromium: HTML exported isn't marked as being UTF-8 2009-07-14 15:54:42 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 0 avi webkit-unassigned fishd jshin oldest_to_newest 131565 0 avi 2009-07-14 08:13:17 -0700 When exporting HTML for the clipboard or drag/drop, the charset isn't indicated. The Windows clipboard format is explicitly documented as being UTF-8, and all Linux apps assume UTF-8. On the Mac, though, unless otherwise indicated, ISO/IEC 8859-1 is assumed, which is wrong. 131566 1 32713 avi 2009-07-14 08:14:52 -0700 Created attachment 32713 Patch to mark clipboard HTML as UTF-8 This is corresponding to http://codereview.chromium.org/149414 131590 2 32713 fishd 2009-07-14 09:38:26 -0700 Comment on attachment 32713 Patch to mark clipboard HTML as UTF-8 > Index: WebCore/ChangeLog ... > +2009-07-14 Avi Drissman <avi@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Explicitly mark the HTML generated for the Mac as being UTF-8 encoded. > + The Windows clipboard format is explicitly documented as being UTF-8, > + and all Linux apps assume UTF-8. On the Mac, though, unless otherwise > + indicated, ISO/IEC 8859-1 is assumed, which is wrong. nit: Your ChangeLog should include a link to this bug. Otherwise, R=me 131595 3 32718 avi 2009-07-14 09:41:28 -0700 Created attachment 32718 Links to the bug now; no other changes 131603 4 jshin 2009-07-14 10:23:50 -0700 nit: a bit of change in the comment and the bug description is necessary. Judging from the way it's broken without your patch, what's assumed is not ISO-8859-1 nor MacRoman but windows-1252 (it's a bit odd to see that on Mac OS X :-)). For instance, U+2018 (Left Single Quotation Mark) whose UTF-8 representation is "0xE2, 0x80, 0x98" is converted to "U+00E2, U+20AC, U+02DC". If it's interpreted as ISO-8859-1, it would be converted to "U+00E2, U+0080, U+0098". 131612 5 32718 fishd 2009-07-14 10:48:44 -0700 Comment on attachment 32718 Links to the bug now; no other changes r- for revised changelog per feedback from jshin. i'll commit the next patch. -darin 131620 6 32724 avi 2009-07-14 11:33:52 -0700 Created attachment 32724 New version; addresses jshin's comments 131718 7 fishd 2009-07-14 15:51:14 -0700 Landed as: http://trac.webkit.org/changeset/45878 (The patch didn't apply cleanly... hand-editing in the ChangeLog portion of the diff?) 131720 8 avi 2009-07-14 15:54:42 -0700 (In reply to comment #7) > (The patch didn't apply cleanly... hand-editing in the ChangeLog portion of the > diff?) Yes, that's the precise reason. Bad me; I'll not do that next time. 32713 2009-07-14 08:14:52 -0700 2009-07-14 09:41:28 -0700 Patch to mark clipboard HTML as UTF-8 utf8.patch text/plain 2243 avi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTg1NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDctMTQgIEF2aSBEcmlzc21hbiAgPGF2aUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhw bGljaXRseSBtYXJrIHRoZSBIVE1MIGdlbmVyYXRlZCBmb3IgdGhlIE1hYyBhcyBiZWluZyBVVEYt OCBlbmNvZGVkLgorICAgICAgICBUaGUgV2luZG93cyBjbGlwYm9hcmQgZm9ybWF0IGlzIGV4cGxp Y2l0bHkgZG9jdW1lbnRlZCBhcyBiZWluZyBVVEYtOCwKKyAgICAgICAgYW5kIGFsbCBMaW51eCBh cHBzIGFzc3VtZSBVVEYtOC4gT24gdGhlIE1hYywgdGhvdWdoLCB1bmxlc3Mgb3RoZXJ3aXNlCisg ICAgICAgIGluZGljYXRlZCwgSVNPL0lFQyA4ODU5LTEgaXMgYXNzdW1lZCwgd2hpY2ggaXMgd3Jv bmcuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21p dW0vQ2xpcGJvYXJkQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2xpcGJvYXJkQ2hy b21pdW06OndyaXRlUmFuZ2UpOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Bhc3RlYm9h cmRDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXN0ZWJvYXJkOjp3cml0ZVNlbGVj dGlvbik6CisKIDIwMDktMDctMTMgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpJbmRleDogV2ViQ29y ZS9wbGF0Zm9ybS9jaHJvbWl1bS9DbGlwYm9hcmRDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DbGlwYm9hcmRDaHJvbWl1bS5jcHAJKHJldmlzaW9u IDQ1ODU2KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DbGlwYm9hcmRDaHJvbWl1bS5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTMzNCw2ICszMzQsOSBAQCB2b2lkIENsaXBib2FyZENocm9t aXVtOjp3cml0ZVJhbmdlKFJhbmdlCiAKICAgICBtX2RhdGFPYmplY3QtPnRleHRIdG1sID0gY3Jl YXRlTWFya3VwKHNlbGVjdGVkUmFuZ2UsIDAsCiAgICAgICAgIEFubm90YXRlRm9ySW50ZXJjaGFu Z2UpOworI2lmIFBMQVRGT1JNKERBUldJTikKKyAgICBtX2RhdGFPYmplY3QtPnRleHRIdG1sID0g U3RyaW5nKCI8bWV0YSBjaGFyc2V0PSd1dGYtOCc+IikgKyBtX2RhdGFPYmplY3QtPnRleHRIdG1s OworI2VuZGlmCiAgICAgbV9kYXRhT2JqZWN0LT5odG1sQmFzZVVybCA9IGZyYW1lLT5kb2N1bWVu dCgpLT51cmwoKTsKIAogICAgIFN0cmluZyBzdHIgPSBmcmFtZS0+c2VsZWN0ZWRUZXh0KCk7Cklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Bhc3RlYm9hcmRDaHJvbWl1bS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QYXN0ZWJvYXJkQ2hyb21pdW0u Y3BwCShyZXZpc2lvbiA0NTg1NikKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUGFzdGVi b2FyZENocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzEsNiArNzEsOSBAQCB2b2lkIFBh c3RlYm9hcmQ6OmNsZWFyKCkKIHZvaWQgUGFzdGVib2FyZDo6d3JpdGVTZWxlY3Rpb24oUmFuZ2Uq IHNlbGVjdGVkUmFuZ2UsIGJvb2wgY2FuU21hcnRDb3B5T3JEZWxldGUsIEZyYW1lKiBmcmFtZSkK IHsKICAgICBTdHJpbmcgaHRtbCA9IGNyZWF0ZU1hcmt1cChzZWxlY3RlZFJhbmdlLCAwLCBBbm5v dGF0ZUZvckludGVyY2hhbmdlKTsKKyNpZiBQTEFURk9STShEQVJXSU4pCisgICAgaHRtbCA9IFN0 cmluZygiPG1ldGEgY2hhcnNldD0ndXRmLTgnPiIpICsgaHRtbDsKKyNlbmRpZgogICAgIEV4Y2Vw dGlvbkNvZGUgZWMgPSAwOwogICAgIEtVUkwgdXJsID0gc2VsZWN0ZWRSYW5nZS0+c3RhcnRDb250 YWluZXIoZWMpLT5kb2N1bWVudCgpLT51cmwoKTsKICAgICBTdHJpbmcgcGxhaW5UZXh0ID0gZnJh bWUtPnNlbGVjdGVkVGV4dCgpOwo= 32718 2009-07-14 09:41:28 -0700 2009-07-14 11:33:52 -0700 Links to the bug now; no other changes utf8.patch text/plain 2305 avi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTg1NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDctMTQgIEF2aSBEcmlzc21hbiAgPGF2aUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhw bGljaXRseSBtYXJrIHRoZSBIVE1MIGdlbmVyYXRlZCBmb3IgdGhlIE1hYyBhcyBiZWluZyBVVEYt OCBlbmNvZGVkLgorICAgICAgICBUaGUgV2luZG93cyBjbGlwYm9hcmQgZm9ybWF0IGlzIGV4cGxp Y2l0bHkgZG9jdW1lbnRlZCBhcyBiZWluZyBVVEYtOCwKKyAgICAgICAgYW5kIGFsbCBMaW51eCBh cHBzIGFzc3VtZSBVVEYtOC4gT24gdGhlIE1hYywgdGhvdWdoLCB1bmxlc3Mgb3RoZXJ3aXNlCisg ICAgICAgIGluZGljYXRlZCwgSVNPL0lFQyA4ODU5LTEgaXMgYXNzdW1lZCwgd2hpY2ggaXMgd3Jv bmcuCisKKyAgICAgICAgQnVnOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjcyNjIKKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9j aHJvbWl1bS9DbGlwYm9hcmRDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDbGlwYm9h cmRDaHJvbWl1bTo6d3JpdGVSYW5nZSk6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vUGFz dGVib2FyZENocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhc3RlYm9hcmQ6OndyaXRl U2VsZWN0aW9uKToKKwogMjAwOS0wNy0xMyAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCkluZGV4OiBX ZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0NsaXBib2FyZENocm9taXVtLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0NsaXBib2FyZENocm9taXVtLmNwcAkocmV2 aXNpb24gNDU4NTYpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0NsaXBib2FyZENocm9t aXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzM0LDYgKzMzNCw5IEBAIHZvaWQgQ2xpcGJvYXJk Q2hyb21pdW06OndyaXRlUmFuZ2UoUmFuZ2UKIAogICAgIG1fZGF0YU9iamVjdC0+dGV4dEh0bWwg PSBjcmVhdGVNYXJrdXAoc2VsZWN0ZWRSYW5nZSwgMCwKICAgICAgICAgQW5ub3RhdGVGb3JJbnRl cmNoYW5nZSk7CisjaWYgUExBVEZPUk0oREFSV0lOKQorICAgIG1fZGF0YU9iamVjdC0+dGV4dEh0 bWwgPSBTdHJpbmcoIjxtZXRhIGNoYXJzZXQ9J3V0Zi04Jz4iKSArIG1fZGF0YU9iamVjdC0+dGV4 dEh0bWw7CisjZW5kaWYKICAgICBtX2RhdGFPYmplY3QtPmh0bWxCYXNlVXJsID0gZnJhbWUtPmRv Y3VtZW50KCktPnVybCgpOwogCiAgICAgU3RyaW5nIHN0ciA9IGZyYW1lLT5zZWxlY3RlZFRleHQo KTsKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUGFzdGVib2FyZENocm9taXVtLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Bhc3RlYm9hcmRDaHJv bWl1bS5jcHAJKHJldmlzaW9uIDQ1ODU2KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Q YXN0ZWJvYXJkQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MSw2ICs3MSw5IEBAIHZv aWQgUGFzdGVib2FyZDo6Y2xlYXIoKQogdm9pZCBQYXN0ZWJvYXJkOjp3cml0ZVNlbGVjdGlvbihS YW5nZSogc2VsZWN0ZWRSYW5nZSwgYm9vbCBjYW5TbWFydENvcHlPckRlbGV0ZSwgRnJhbWUqIGZy YW1lKQogewogICAgIFN0cmluZyBodG1sID0gY3JlYXRlTWFya3VwKHNlbGVjdGVkUmFuZ2UsIDAs IEFubm90YXRlRm9ySW50ZXJjaGFuZ2UpOworI2lmIFBMQVRGT1JNKERBUldJTikKKyAgICBodG1s ID0gU3RyaW5nKCI8bWV0YSBjaGFyc2V0PSd1dGYtOCc+IikgKyBodG1sOworI2VuZGlmCiAgICAg RXhjZXB0aW9uQ29kZSBlYyA9IDA7CiAgICAgS1VSTCB1cmwgPSBzZWxlY3RlZFJhbmdlLT5zdGFy dENvbnRhaW5lcihlYyktPmRvY3VtZW50KCktPnVybCgpOwogICAgIFN0cmluZyBwbGFpblRleHQg PSBmcmFtZS0+c2VsZWN0ZWRUZXh0KCk7Cg== 32724 2009-07-14 11:33:52 -0700 2009-07-14 15:45:16 -0700 New version; addresses jshin's comments utf8.patch text/plain 2303 avi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTg1NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDctMTQgIEF2aSBEcmlzc21hbiAgPGF2aUBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhw bGljaXRseSBtYXJrIHRoZSBIVE1MIGdlbmVyYXRlZCBmb3IgdGhlIE1hYyBhcyBiZWluZyBVVEYt OCBlbmNvZGVkLgorICAgICAgICBUaGUgV2luZG93cyBjbGlwYm9hcmQgZm9ybWF0IGlzIGV4cGxp Y2l0bHkgZG9jdW1lbnRlZCBhcyBiZWluZyBVVEYtOCwKKyAgICAgICAgYW5kIGFsbCBMaW51eCBh cHBzIGFzc3VtZSBVVEYtOC4gT24gdGhlIE1hYywgdGhvdWdoLCB1bmxlc3Mgb3RoZXJ3aXNlCisg ICAgICAgIGluZGljYXRlZCwgV2luZG93cy0xMjUyIGlzIGFzc3VtZWQsIHdoaWNoIGlzIHdyb25n LgorCisgICAgICAgIEJ1ZzogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTI3MjYyCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0vQ2xpcGJvYXJkQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2xpcGJvYXJk Q2hyb21pdW06OndyaXRlUmFuZ2UpOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1Bhc3Rl Ym9hcmRDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYXN0ZWJvYXJkOjp3cml0ZVNl bGVjdGlvbik6CisKIDIwMDktMDctMTMgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgpJbmRleDogV2Vi Q29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DbGlwYm9hcmRDaHJvbWl1bS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DbGlwYm9hcmRDaHJvbWl1bS5jcHAJKHJldmlz aW9uIDQ1ODU2KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9DbGlwYm9hcmRDaHJvbWl1 bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzNCw2ICszMzQsOSBAQCB2b2lkIENsaXBib2FyZENo cm9taXVtOjp3cml0ZVJhbmdlKFJhbmdlCiAKICAgICBtX2RhdGFPYmplY3QtPnRleHRIdG1sID0g Y3JlYXRlTWFya3VwKHNlbGVjdGVkUmFuZ2UsIDAsCiAgICAgICAgIEFubm90YXRlRm9ySW50ZXJj aGFuZ2UpOworI2lmIFBMQVRGT1JNKERBUldJTikKKyAgICBtX2RhdGFPYmplY3QtPnRleHRIdG1s ID0gU3RyaW5nKCI8bWV0YSBjaGFyc2V0PSd1dGYtOCc+IikgKyBtX2RhdGFPYmplY3QtPnRleHRI dG1sOworI2VuZGlmCiAgICAgbV9kYXRhT2JqZWN0LT5odG1sQmFzZVVybCA9IGZyYW1lLT5kb2N1 bWVudCgpLT51cmwoKTsKIAogICAgIFN0cmluZyBzdHIgPSBmcmFtZS0+c2VsZWN0ZWRUZXh0KCk7 CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Bhc3RlYm9hcmRDaHJvbWl1bS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QYXN0ZWJvYXJkQ2hyb21p dW0uY3BwCShyZXZpc2lvbiA0NTg1NikKKysrIFdlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUGFz dGVib2FyZENocm9taXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzEsNiArNzEsOSBAQCB2b2lk IFBhc3RlYm9hcmQ6OmNsZWFyKCkKIHZvaWQgUGFzdGVib2FyZDo6d3JpdGVTZWxlY3Rpb24oUmFu Z2UqIHNlbGVjdGVkUmFuZ2UsIGJvb2wgY2FuU21hcnRDb3B5T3JEZWxldGUsIEZyYW1lKiBmcmFt ZSkKIHsKICAgICBTdHJpbmcgaHRtbCA9IGNyZWF0ZU1hcmt1cChzZWxlY3RlZFJhbmdlLCAwLCBB bm5vdGF0ZUZvckludGVyY2hhbmdlKTsKKyNpZiBQTEFURk9STShEQVJXSU4pCisgICAgaHRtbCA9 IFN0cmluZygiPG1ldGEgY2hhcnNldD0ndXRmLTgnPiIpICsgaHRtbDsKKyNlbmRpZgogICAgIEV4 Y2VwdGlvbkNvZGUgZWMgPSAwOwogICAgIEtVUkwgdXJsID0gc2VsZWN0ZWRSYW5nZS0+c3RhcnRD b250YWluZXIoZWMpLT5kb2N1bWVudCgpLT51cmwoKTsKICAgICBTdHJpbmcgcGxhaW5UZXh0ID0g ZnJhbWUtPnNlbGVjdGVkVGV4dCgpOwo=