<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>27248</bug_id>
          
          <creation_ts>2009-07-14 02:32:39 -0700</creation_ts>
          <short_desc>Change JSCell&apos;s superclass to NoncopyableCustomAllocated</short_desc>
          <delta_ts>2009-07-15 10:05:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>27225</dependson>
    
    <dependson>27228</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zoltan Horvath">zoltan</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bfulgham</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>131506</commentid>
    <comment_count>0</comment_count>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-07-14 02:32:39 -0700</bug_when>
    <thetext>JSCell class customizes operator new, since Noncopyable will be inherited from FastAllocBase, NoncopyableCustomAllocated has to be used.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>131507</commentid>
    <comment_count>1</comment_count>
      <attachid>32702</attachid>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-07-14 02:35:26 -0700</bug_when>
    <thetext>Created attachment 32702
proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>131931</commentid>
    <comment_count>2</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2009-07-15 10:05:50 -0700</bug_when>
    <thetext>Landed in http://trac.webkit.org/changeset/45897.

Note:  Somehow the ChangeLog entry was lost (perhaps resolve-ChangeLogs isn&apos;t quite perfect yet!)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32702</attachid>
            <date>2009-07-14 02:35:26 -0700</date>
            <delta_ts>2009-07-14 09:30:54 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>JSCell.patch</filename>
            <type>text/plain</type>
            <size>1176</size>
            <attacher name="Zoltan Horvath">zoltan</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ1ODU1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDctMTQgIFpvbHRhbiBI
b3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIEpTQ2VsbCdzIHN1cGVyY2xhc3MgdG8g
Tm9uY29weWFibGVDdXN0b21BbGxvY2F0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTI3MjQ4CisKKyAgICAgICAgSlNDZWxsIGNsYXNzIGN1c3RvbWl6
ZXMgb3BlcmF0b3IgbmV3LCBzaW5jZSBOb25jb3B5YWJsZSB3aWxsIGJlIAorICAgICAgICBpbmhl
cml0ZWQgZnJvbSBGYXN0QWxsb2NCYXNlLCBOb25jb3B5YWJsZUN1c3RvbUFsbG9jYXRlZCBoYXMg
CisgICAgICAgIHRvIGJlIHVzZWQuCisKKyAgICAgICAgKiBydW50aW1lL0pTQ2VsbC5oOgorCiAy
MDA5LTA3LTEzICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFi
b3JhLmNvLnVrPgogCiAgICAgICAgIFVucmV2aWV3ZWQgbWFrZSBkaXN0IGJ1aWxkIGZpeC4KSW5k
ZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDZWxsLmgKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNj
cmlwdENvcmUvcnVudGltZS9KU0NlbGwuaAkocmV2aXNpb24gNDU4NTUpCisrKyBKYXZhU2NyaXB0
Q29yZS9ydW50aW1lL0pTQ2VsbC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw3ICszMSw3IEBACiAK
IG5hbWVzcGFjZSBKU0MgewogCi0gICAgY2xhc3MgSlNDZWxsIDogcHVibGljIE5vbmNvcHlhYmxl
IHsKKyAgICBjbGFzcyBKU0NlbGwgOiBwdWJsaWMgTm9uY29weWFibGVDdXN0b21BbGxvY2F0ZWQg
ewogICAgICAgICBmcmllbmQgY2xhc3MgR2V0dGVyU2V0dGVyOwogICAgICAgICBmcmllbmQgY2xh
c3MgSGVhcDsKICAgICAgICAgZnJpZW5kIGNsYXNzIEpJVDsK
</data>
<flag name="review"
          id="17082"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>