27241 2009-07-13 17:46:42 -0700 bugzilla-tool post-commits silently fails with bad args 2009-07-16 10:26:46 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned ddkilzer oldest_to_newest 131452 0 eric 2009-07-13 17:46:42 -0700 bugzilla-tool post-commits silently fails with bad args I tried: bugzilla-tool post-commits --no-review 27088 head Which used to be the syntax. That just exited 0, and gave no indication of failure. :( 131453 1 eric 2009-07-13 17:47:49 -0700 Sigh. Also: bugzilla-tool post-commits --no-review -b 27088 trunk Doesn't work as I expected it to. git-send-bugzilla used to make that into trunk...HEAD. Now it just posted "trunk". I guess it's just assuming a --cherry-pick arg. Maybe the new way is more intuitive? donno. 131454 2 eric 2009-07-13 17:48:12 -0700 The new behavior will certainly confuse git-send-bugzilla users. :) But maybe that's OK. 131480 3 ddkilzer 2009-07-13 21:00:42 -0700 (In reply to comment #2) > The new behavior will certainly confuse git-send-bugzilla users. :) But maybe > that's OK. Sorry, I've never used git-send-bugzilla. I explained the reason for this change in Bug 27062 Comment #3 and Bug 27062 Comment #5. I'll look at the --no-review issue tomorrow. 132138 4 32833 ddkilzer 2009-07-15 21:50:56 -0700 Created attachment 32833 Patch v1 132141 5 32833 eric 2009-07-15 21:59:29 -0700 Comment on attachment 32833 Patch v1 You could probably re-use the self.argnames string (or wahtever it's called). Instead of re-typing "COMMITTISH". I probably woudl have written "'%s' is not a COMMITISH" as "unable to parse commit is from %s". What you have is fine. Or with one or more of the modifications suggested above. Thanks! 132293 6 ddkilzer 2009-07-16 10:26:46 -0700 $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/bugzilla-tool Committed r45978 http://trac.webkit.org/changeset/45978 32833 2009-07-15 21:50:56 -0700 2009-07-15 21:59:28 -0700 Patch v1 bug-27241-20090715215100.patch text/plain 1668 ddkilzer ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0OTM1MzVjLi42NWQ0NjI5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDct MTUgIERhdmlkIEQuIEtpbHplciAgPGRka2lsemVyQHdlYmtpdC5vcmc+CisKKyAgICAgICAgPGh0 dHA6Ly93ZWJraXQub3JnL2IvMjcyNDE+IGJ1Z3ppbGxhLXRvb2wgcG9zdC1jb21taXRzIHNpbGVu dGx5IGZhaWxzIHdpdGggYmFkIGFyZ3MKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvYnVnemlsbGEtdG9vbDoKKyAgICAgICAgKFBvc3RD b21taXRzQXNQYXRjaGVzVG9CdWcuZXhlY3V0ZSk6IEFkZGVkIG1vcmUgZXJyb3IgY2hlY2tpbmcK KyAgICAgICAgd2hlbiBjb25zdW1pbmcgYXJndW1lbnRzLgorCiAyMDA5LTA3LTE1ICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICAqIFNjcmlwdHMvZG8td2ViY29yZS1y ZW5hbWU6IENoZWNrIGluIHRoZSB2ZXJzaW9uIHVzZWQgdG8KZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbCBiL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEt dG9vbAppbmRleCBiNWUwOWFiLi5lNjE5OTUxIDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3Jp cHRzL2J1Z3ppbGxhLXRvb2wKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29s CkBAIC00MTUsNyArNDE1LDE1IEBAIGNsYXNzIFBvc3RDb21taXRzQXNQYXRjaGVzVG9CdWcoQ29t bWFuZCk6CiAgICAgICAgIENvbW1hbmQuX19pbml0X18oc2VsZiwgJ0F0dGFjaGVzIGEgcmFuZ2Ug b2YgbG9jYWwgY29tbWl0cyB0byBidWdzIGFzIHBhdGNoIGZpbGVzLicsICdDT01NSVRJU0gnLCBv cHRpb25zPW9wdGlvbnMsIHJlcXVpcmVzX2xvY2FsX2NvbW1pdHM9VHJ1ZSkKIAogICAgIGRlZiBl eGVjdXRlKHNlbGYsIG9wdGlvbnMsIGFyZ3MsIHRvb2wpOgotICAgICAgICBjb21taXRfaWRzID0g dG9vbC5zY20oKS5jb21taXRfaWRzX2Zyb21fcmFuZ2VfYXJndW1lbnRzKGFyZ3MsIGNoZXJyeV9w aWNrPVRydWUpCisgICAgICAgIGlmIG5vdCBhcmdzOgorICAgICAgICAgICAgZXJyb3IoIkNPTU1J VElTSCBhcmd1bWVudCBpcyByZXF1aXJlZCIpCisKKyAgICAgICAgY29tbWl0X2lkcyA9IFtdCisg ICAgICAgIGZvciBjb21taXRpc2ggaW4gYXJnczoKKyAgICAgICAgICAgIHJlc3VsdHMgPSB0b29s LnNjbSgpLmNvbW1pdF9pZHNfZnJvbV9yYW5nZV9hcmd1bWVudHMoW2NvbW1pdGlzaF0sIGNoZXJy eV9waWNrPVRydWUpCisgICAgICAgICAgICBpZiBub3QgcmVzdWx0cyBvciBsZW4ocmVzdWx0cykg PCAxOgorICAgICAgICAgICAgICAgIGVycm9yKCInJXMnIGlzIG5vdCBhIENPTU1JVElTSCIgJSBj b21taXRpc2gpCisgICAgICAgICAgICBjb21taXRfaWRzICs9IHJlc3VsdHMKIAogICAgICAgICBp ZiBsZW4oY29tbWl0X2lkcykgPiAxMDoKICAgICAgICAgICAgIGVycm9yKCJBcmUgeW91IHN1cmUg eW91IHdhbnQgdG8gYXR0YWNoICVzIHBhdGNoZXM/IiAlIChwbHVyYWxpemUoJ3BhdGNoJywgbGVu KGNvbW1pdF9pZHMpKSkp