27232 2009-07-13 12:32:35 -0700 Add RefCountedCustomAllocated to RefCounted.h 2009-07-14 17:48:13 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 27228 27249 1 zoltan webkit-unassigned bfulgham darin oldest_to_newest 131383 0 zoltan 2009-07-13 12:32:35 -0700 The RefCounted inheritance need to be changed a little bit to avoid double inheritance and RefCountedCustomAllocated class need to be added to RefCounted.h, the reason is the same like in the case of NoncopyableCustomAllocated, bug #27228. (Some classes which customizes operator new are inherited from RefCounted, RefCounted is inherited from Noncopyable, but Noncopyable will be inherited from FastAllocBase. Conflicts need to be resolved.) 131385 1 32671 zoltan 2009-07-13 12:40:55 -0700 Created attachment 32671 proposed patch 131774 2 bfulgham 2009-07-14 17:48:13 -0700 Landed in http://trac.webkit.org/changeset/45885. 32671 2009-07-13 12:40:55 -0700 2009-07-13 12:49:40 -0700 proposed patch RefCounted.patch text/plain 2222 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ1ODMzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMDctMTMgIFpvbHRhbiBI b3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIFJlZkNvdW50ZWRDdXN0b21BbGxvY2F0ZWQg dG8gUmVmQ291bnRlZC5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNzIzMgorCisgICAgICAgIFNvbWUgY2xhc3Mgd2hpY2ggYXJlIGluaGVyaXRlZCBm cm9tIFJlZkNvdW50ZWQgY3VzdG9taXplCisgICAgICAgIG9wZXJhdG9yIG5ldywgYnV0IFJlZkNv dW50ZWQgaXMgaW5oZXJpdGVkIGZyb20gTm9uY29weWFibGUKKyAgICAgICAgd2hpY2ggd2lsbCBi ZSBpbmhlcml0ZWQgZnJvbSBGYXN0QWxsb2NCYXNlLiBUbyBhdm9pZAorICAgICAgICBjb25mbGlj dHMgTm9uY29weWFibGUgaW5oZXJpdGluZyB3YXMgbW92ZWQgZG93biB0byBSZWZDb3VudGVkCisg ICAgICAgIGFuZCB0byBhdm9pZCBkb3VibGUgaW5oZXJpdGFuY2UgdGhpcyBjbGFzcyBoYXMgYmVl biBhZGRlZC4KKworICAgICAgICAqIHd0Zi9SZWZDb3VudGVkLmg6CisgICAgICAgIChXVEY6OlJl ZkNvdW50ZWRDdXN0b21BbGxvY2F0ZWQ6OmRlcmVmKToKKyAgICAgICAgKFdURjo6UmVmQ291bnRl ZEN1c3RvbUFsbG9jYXRlZDo6flJlZkNvdW50ZWRDdXN0b21BbGxvY2F0ZWQpOgorCiAyMDA5LTA3 LTEzICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNv LnVrPgogCiAgICAgICAgIFVucmV2aWV3ZWQgbWFrZSBkaXN0IGJ1aWxkIGZpeC4KSW5kZXg6IEph dmFTY3JpcHRDb3JlL3d0Zi9SZWZDb3VudGVkLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENv cmUvd3RmL1JlZkNvdW50ZWQuaAkocmV2aXNpb24gNDU4MzApCisrKyBKYXZhU2NyaXB0Q29yZS93 dGYvUmVmQ291bnRlZC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOSw3ICsyOSw3IEBAIG5hbWVzcGFj ZSBXVEYgewogLy8gVGhpcyBiYXNlIGNsYXNzIGhvbGRzIHRoZSBub24tdGVtcGxhdGUgbWV0aG9k cyBhbmQgYXR0cmlidXRlcy4KIC8vIFRoZSBSZWZDb3VudGVkIGNsYXNzIGluaGVyaXRzIGZyb20g aXQgcmVkdWNpbmcgdGhlIHRlbXBsYXRlIGJsb2F0CiAvLyBnZW5lcmF0ZWQgYnkgdGhlIGNvbXBp bGVyICh0ZWNobmlxdWUgY2FsbGVkIHRlbXBsYXRlIGhvaXN0aW5nKS4KLWNsYXNzIFJlZkNvdW50 ZWRCYXNlIDogTm9uY29weWFibGUgeworY2xhc3MgUmVmQ291bnRlZEJhc2UgewogcHVibGljOgog ICAgIHZvaWQgcmVmKCkKICAgICB7CkBAIC0xMDEsNyArMTAxLDcgQEAgcHJpdmF0ZToKIH07CiAK IAotdGVtcGxhdGU8Y2xhc3MgVD4gY2xhc3MgUmVmQ291bnRlZCA6IHB1YmxpYyBSZWZDb3VudGVk QmFzZSB7Cit0ZW1wbGF0ZTxjbGFzcyBUPiBjbGFzcyBSZWZDb3VudGVkIDogcHVibGljIFJlZkNv dW50ZWRCYXNlLCBwdWJsaWMgTm9uY29weWFibGUgewogcHVibGljOgogICAgIHZvaWQgZGVyZWYo KQogICAgIHsKQEAgLTExNSw4ICsxMTUsMjMgQEAgcHJvdGVjdGVkOgogICAgIH0KIH07CiAKK3Rl bXBsYXRlPGNsYXNzIFQ+IGNsYXNzIFJlZkNvdW50ZWRDdXN0b21BbGxvY2F0ZWQgOiBwdWJsaWMg UmVmQ291bnRlZEJhc2UsIHB1YmxpYyBOb25jb3B5YWJsZUN1c3RvbUFsbG9jYXRlZCB7CitwdWJs aWM6CisgICAgdm9pZCBkZXJlZigpCisgICAgeworICAgICAgICBpZiAoZGVyZWZCYXNlKCkpCisg ICAgICAgICAgICBkZWxldGUgc3RhdGljX2Nhc3Q8VCo+KHRoaXMpOworICAgIH0KKworcHJvdGVj dGVkOgorICAgIH5SZWZDb3VudGVkQ3VzdG9tQWxsb2NhdGVkKCkKKyAgICB7CisgICAgfQorfTsK KwogfSAvLyBuYW1lc3BhY2UgV1RGCiAKIHVzaW5nIFdURjo6UmVmQ291bnRlZDsKK3VzaW5nIFdU Rjo6UmVmQ291bnRlZEN1c3RvbUFsbG9jYXRlZDsKIAogI2VuZGlmIC8vIFJlZkNvdW50ZWRfaAo=