27231 2009-07-13 12:27:47 -0700 REGRESSION: Clicking on nodes in the console should take you to the element in the DOM 2009-10-21 12:36:21 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=14368 Regression P2 Normal --- 1 a webkit-unassigned aroben commit-queue joepeck timothy oldest_to_newest 131381 0 a 2009-07-13 12:27:47 -0700 Clicking on any of the child nodes should take you to the DOM view and select the clicked child. 131382 1 aroben 2009-07-13 12:32:01 -0700 This used to work. I think it broke in r41404: <http://trac.webkit.org/changeset/41404>. 156559 2 41584 keishi 2009-10-21 11:17:16 -0700 Created attachment 41584 proposed patch Clicking on a node in the console will select the node in the Elements panel. 156564 3 41584 timothy 2009-10-21 11:22:52 -0700 Comment on attachment 41584 proposed patch > + if (this.showInElementsPanel) This can just be: if (this.treeOutline.showInElementsPanelEnabled) Then you don't need all the propagation code. > + WebInspector.panels.elements.focusedDOMNode = this.representedObject; We should switch to the Elements panel if it isn't visible too. 156575 4 41591 keishi 2009-10-21 11:36:38 -0700 Created attachment 41591 proposed patch 2 I fixed the issues. 156610 5 41591 commit-queue 2009-10-21 12:36:18 -0700 Comment on attachment 41591 proposed patch 2 Clearing flags on attachment: 41591 Committed r49917: <http://trac.webkit.org/changeset/49917> 156611 6 commit-queue 2009-10-21 12:36:21 -0700 All reviewed patches have been landed. Closing bug. 41584 2009-10-21 11:17:16 -0700 2009-10-21 11:36:38 -0700 proposed patch shownode.diff text/plain 4288 keishi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTkwNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMTAtMjEgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0dG9y aUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUkVHUkVTU0lPTjogQ2xpY2tpbmcgb24gbm9kZXMgaW4gdGhlIGNvbnNvbGUgc2hvdWxk IHRha2UgeW91IHRvIHRoZSBlbGVtZW50IGluIHRoZSBET00KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3MjMxCisKKyAgICAgICAgKiBpbnNwZWN0b3Iv ZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVW aWV3LnByb3RvdHlwZS5fZm9ybWF0bm9kZSk6IFR1cm5zIG9uIEVsZW1lbnRzVHJlZU91dGxpbmUu c2hvd0luRWxlbWVudHNQYW5lbEVuYWJsZWQKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L0VsZW1lbnRzVHJlZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNU cmVlT3V0bGluZSk6IEFkZGVkIEVsZW1lbnRzVHJlZU91dGxpbmUuc2hvd0luRWxlbWVudHNQYW5l bEVuYWJsZWQKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVPdXRsaW5lLnByb3Rv dHlwZS51cGRhdGUpOiAKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50 LnByb3RvdHlwZS5fdXBkYXRlQ2hpbGRyZW4udXBkYXRlQ2hpbGRyZW5PZk5vZGUpOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlLl91cGRhdGVDaGls ZHJlbik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVudC5wcm90b3R5 cGUub25tb3VzZWRvd24pOiBSZXZlYWxzIHRoZSBub2RlIGluIHRoZSBFbGVtZW50cyBwYW5lbCBp ZiAKKyAgICAgICAgRWxlbWVudHNUcmVlRWxlbWVudC5zaG93SW5FbGVtZW50c1BhbmVsIGlzIHRy dWUuCisKIDIwMDktMTAtMjEgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2aWVycy5j b20+CiAKICAgICAgICAgd3hNYWMgMTAuNCBidWlsZCBmaXgsIG1ha2Ugc3VyZSB3ZSBzcGVjaWZ5 IHRoZSBTcWxpdGUzIGRlcGVuZGVuY3kgY29ycmVjdGx5IGFzIG90aGVyd2lzZQpJbmRleDogV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcwkocmV2aXNpb24gNDk5MDUp CisrKyBXZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMJKHdvcmtpbmcg Y29weSkKQEAgLTUzOSw2ICs1MzksNyBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90 eXBlID0gewogICAgICAgICAgICAgaWYgKCFub2RlSWQpCiAgICAgICAgICAgICAgICAgcmV0dXJu OwogICAgICAgICAgICAgdmFyIHRyZWVPdXRsaW5lID0gbmV3IFdlYkluc3BlY3Rvci5FbGVtZW50 c1RyZWVPdXRsaW5lKCk7CisgICAgICAgICAgICB0cmVlT3V0bGluZS5zaG93SW5FbGVtZW50c1Bh bmVsRW5hYmxlZCA9IHRydWU7CiAgICAgICAgICAgICB0cmVlT3V0bGluZS5yb290RE9NTm9kZSA9 IFdlYkluc3BlY3Rvci5kb21BZ2VudC5ub2RlRm9ySWQobm9kZUlkKTsKICAgICAgICAgICAgIHRy ZWVPdXRsaW5lLmVsZW1lbnQuYWRkU3R5bGVDbGFzcygib3V0bGluZS1kaXNjbG9zdXJlIik7CiAg ICAgICAgICAgICBpZiAoIXRyZWVPdXRsaW5lLmNoaWxkcmVuWzBdLmhhc0NoaWxkcmVuKQpJbmRl eDogV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxp bmUuanMJKHJldmlzaW9uIDQ5OTA1KQorKysgV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Vs ZW1lbnRzVHJlZU91dGxpbmUuanMJKHdvcmtpbmcgY29weSkKQEAgLTM4LDYgKzM4LDcgQEAgV2Vi SW5zcGVjdG9yLkVsZW1lbnRzVHJlZU91dGxpbmUgPSBmdW5jdAogCiAgICAgdGhpcy5pbmNsdWRl Um9vdERPTU5vZGUgPSB0cnVlOwogICAgIHRoaXMuc2VsZWN0RW5hYmxlZCA9IGZhbHNlOworICAg IHRoaXMuc2hvd0luRWxlbWVudHNQYW5lbEVuYWJsZWQgPSBmYWxzZTsKICAgICB0aGlzLnJvb3RE T01Ob2RlID0gbnVsbDsKICAgICB0aGlzLmZvY3VzZWRET01Ob2RlID0gbnVsbDsKIH0KQEAgLTEx Miw2ICsxMTMsNyBAQCBXZWJJbnNwZWN0b3IuRWxlbWVudHNUcmVlT3V0bGluZS5wcm90b3R5CiAg ICAgICAgIGlmICh0aGlzLmluY2x1ZGVSb290RE9NTm9kZSkgewogICAgICAgICAgICAgdHJlZUVs ZW1lbnQgPSBuZXcgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQodGhpcy5yb290RE9N Tm9kZSk7CiAgICAgICAgICAgICB0cmVlRWxlbWVudC5zZWxlY3RhYmxlID0gdGhpcy5zZWxlY3RF bmFibGVkOworICAgICAgICAgICAgdHJlZUVsZW1lbnQuc2hvd0luRWxlbWVudHNQYW5lbCA9IHRo aXMuc2hvd0luRWxlbWVudHNQYW5lbEVuYWJsZWQ7CiAgICAgICAgICAgICB0aGlzLmFwcGVuZENo aWxkKHRyZWVFbGVtZW50KTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIC8vIEZJWE1F OiB0aGlzIGNvdWxkIHVzZSBmaW5kVHJlZUVsZW1lbnQgdG8gcmV1c2UgYSB0cmVlIGVsZW1lbnQg aWYgaXQgYWxyZWFkeSBleGlzdHMKQEAgLTExOSw2ICsxMjEsNyBAQCBXZWJJbnNwZWN0b3IuRWxl bWVudHNUcmVlT3V0bGluZS5wcm90b3R5CiAgICAgICAgICAgICB3aGlsZSAobm9kZSkgewogICAg ICAgICAgICAgICAgIHRyZWVFbGVtZW50ID0gbmV3IFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVF bGVtZW50KG5vZGUpOwogICAgICAgICAgICAgICAgIHRyZWVFbGVtZW50LnNlbGVjdGFibGUgPSB0 aGlzLnNlbGVjdEVuYWJsZWQ7CisgICAgICAgICAgICAgICAgdHJlZUVsZW1lbnQuc2hvd0luRWxl bWVudHNQYW5lbCA9IHRoaXMuc2hvd0luRWxlbWVudHNQYW5lbEVuYWJsZWQ7CiAgICAgICAgICAg ICAgICAgdGhpcy5hcHBlbmRDaGlsZCh0cmVlRWxlbWVudCk7CiAgICAgICAgICAgICAgICAgbm9k ZSA9IG5vZGUubmV4dFNpYmxpbmc7CiAgICAgICAgICAgICB9CkBAIC00NDIsNiArNDQ1LDcgQEAg V2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eQogICAgICAgICAgICAgICAg ICAgICAgICAgLy8gTm8gZXhpc3RpbmcgZWxlbWVudCBmb3VuZCwgaW5zZXJ0IGEgbmV3IGVsZW1l bnQuCiAgICAgICAgICAgICAgICAgICAgICAgICB2YXIgbmV3RWxlbWVudCA9IG5ldyBXZWJJbnNw ZWN0b3IuRWxlbWVudHNUcmVlRWxlbWVudChjaGlsZCk7CiAgICAgICAgICAgICAgICAgICAgICAg ICBuZXdFbGVtZW50LnNlbGVjdGFibGUgPSB0cmVlT3V0bGluZS5zZWxlY3RFbmFibGVkOworICAg ICAgICAgICAgICAgICAgICAgICAgbmV3RWxlbWVudC5zaG93SW5FbGVtZW50c1BhbmVsID0gdHJl ZU91dGxpbmUuc2hvd0luRWxlbWVudHNQYW5lbEVuYWJsZWQ7CiAgICAgICAgICAgICAgICAgICAg ICAgICB0cmVlRWxlbWVudC5pbnNlcnRDaGlsZChuZXdFbGVtZW50LCB0cmVlQ2hpbGRJbmRleCk7 CiAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICB9CkBAIC01MDksNiArNTEz LDkgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eQogICAgICAgICBp ZiAodGhpcy5fZWRpdGluZykKICAgICAgICAgICAgIHJldHVybjsKIAorICAgICAgICBpZiAodGhp cy5zaG93SW5FbGVtZW50c1BhbmVsKQorICAgICAgICAgICAgV2ViSW5zcGVjdG9yLnBhbmVscy5l bGVtZW50cy5mb2N1c2VkRE9NTm9kZSA9IHRoaXMucmVwcmVzZW50ZWRPYmplY3Q7CisKICAgICAg ICAgLy8gUHJldmVudCBzZWxlY3RpbmcgdGhlIG5lYXJlc3Qgd29yZCBvbiBkb3VibGUgY2xpY2su CiAgICAgICAgIGlmIChldmVudC5kZXRhaWwgPj0gMikKICAgICAgICAgICAgIGV2ZW50LnByZXZl bnREZWZhdWx0KCk7Cg== 41591 2009-10-21 11:36:38 -0700 2009-10-21 12:36:17 -0700 proposed patch 2 shownode.diff text/plain 2658 keishi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTkxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTAtMjEgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0dG9y aUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgUkVHUkVTU0lPTjogQ2xpY2tpbmcgb24gbm9kZXMgaW4gdGhlIGNvbnNvbGUgc2hvdWxk IHRha2UgeW91IHRvIHRoZSBlbGVtZW50IGluIHRoZSBET00KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3MjMxCisKKyAgICAgICAgKiBpbnNwZWN0b3Iv ZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVW aWV3LnByb3RvdHlwZS5fZm9ybWF0bm9kZSk6IFR1cm5zIG9uIEVsZW1lbnRzVHJlZU91dGxpbmUu c2hvd0luRWxlbWVudHNQYW5lbEVuYWJsZWQKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5k L0VsZW1lbnRzVHJlZU91dGxpbmUuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNU cmVlT3V0bGluZSk6IEFkZGVkIEVsZW1lbnRzVHJlZU91dGxpbmUuc2hvd0luRWxlbWVudHNQYW5l bEVuYWJsZWQKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVtZW50LnByb3Rv dHlwZS5vbm1vdXNlZG93bik6IFJldmVhbHMgdGhlIG5vZGUgaW4gdGhlIEVsZW1lbnRzIHBhbmVs IGlmIAorICAgICAgICB0cmVlT3V0bGluZS5zaG93SW5FbGVtZW50c1BhbmVsRW5hYmxlZCBpcyB0 cnVlLgorCiAyMDA5LTEwLTIxICBEbWl0cnkgVGl0b3YgIDxkaW1pY2hAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcwkocmV2aXNpb24gNDk5MDUpCisrKyBXZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMJKHdvcmtpbmcgY29weSkKQEAgLTUz OSw2ICs1MzksNyBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogICAg ICAgICAgICAgaWYgKCFub2RlSWQpCiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAg ICAgdmFyIHRyZWVPdXRsaW5lID0gbmV3IFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVPdXRsaW5l KCk7CisgICAgICAgICAgICB0cmVlT3V0bGluZS5zaG93SW5FbGVtZW50c1BhbmVsRW5hYmxlZCA9 IHRydWU7CiAgICAgICAgICAgICB0cmVlT3V0bGluZS5yb290RE9NTm9kZSA9IFdlYkluc3BlY3Rv ci5kb21BZ2VudC5ub2RlRm9ySWQobm9kZUlkKTsKICAgICAgICAgICAgIHRyZWVPdXRsaW5lLmVs ZW1lbnQuYWRkU3R5bGVDbGFzcygib3V0bGluZS1kaXNjbG9zdXJlIik7CiAgICAgICAgICAgICBp ZiAoIXRyZWVPdXRsaW5lLmNoaWxkcmVuWzBdLmhhc0NoaWxkcmVuKQpJbmRleDogV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91dGxpbmUuanMJKHJldmlz aW9uIDQ5OTA1KQorKysgV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzVHJlZU91 dGxpbmUuanMJKHdvcmtpbmcgY29weSkKQEAgLTM4LDYgKzM4LDcgQEAgV2ViSW5zcGVjdG9yLkVs ZW1lbnRzVHJlZU91dGxpbmUgPSBmdW5jdAogCiAgICAgdGhpcy5pbmNsdWRlUm9vdERPTU5vZGUg PSB0cnVlOwogICAgIHRoaXMuc2VsZWN0RW5hYmxlZCA9IGZhbHNlOworICAgIHRoaXMuc2hvd0lu RWxlbWVudHNQYW5lbEVuYWJsZWQgPSBmYWxzZTsKICAgICB0aGlzLnJvb3RET01Ob2RlID0gbnVs bDsKICAgICB0aGlzLmZvY3VzZWRET01Ob2RlID0gbnVsbDsKIH0KQEAgLTUwOSw2ICs1MTAsMTEg QEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eQogICAgICAgICBpZiAo dGhpcy5fZWRpdGluZykKICAgICAgICAgICAgIHJldHVybjsKIAorICAgICAgICBpZiAodGhpcy50 cmVlT3V0bGluZS5zaG93SW5FbGVtZW50c1BhbmVsRW5hYmxlZCkgeyAgICAKKyAgICAgICAgICAg IFdlYkluc3BlY3Rvci5zaG93RWxlbWVudHNQYW5lbCgpOworICAgICAgICAgICAgV2ViSW5zcGVj dG9yLnBhbmVscy5lbGVtZW50cy5mb2N1c2VkRE9NTm9kZSA9IHRoaXMucmVwcmVzZW50ZWRPYmpl Y3Q7CisgICAgICAgIH0KKwogICAgICAgICAvLyBQcmV2ZW50IHNlbGVjdGluZyB0aGUgbmVhcmVz dCB3b3JkIG9uIGRvdWJsZSBjbGljay4KICAgICAgICAgaWYgKGV2ZW50LmRldGFpbCA+PSAyKQog ICAgICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsK