27230 2009-07-13 12:21:59 -0700 [Gtk] soup/ResourceHandleSoup.cpp:533: error: 'g_mapped_file_free' was not declared in this scope 2009-07-18 16:14:29 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Blocker --- 1 David.Ronis webkit-unassigned gustavo jmalonzo oldest_to_newest 131378 0 David.Ronis 2009-07-13 12:21:59 -0700 I just tried upgrading webkitgtk+ form 1.1.10 to 1.1.11; I get the compile-time error given in the summary. I'm using gtk+-2.17.2 and the git-master of libsoup (built today). I'm using gcc-4.4.0, on a slackware-12.2. box 131384 1 David.Ronis 2009-07-13 12:34:02 -0700 Grepped the include dir for the definition: Here's what I see in glib-2.0/glib/gmappedfile.h: #ifndef G_DISABLE_DEPRECATED void g_mapped_file_free (GMappedFile *file); #endif Looks like this is being phased out. In any event, I manually added the declaration to the webkit file and am resuming the compilation. 131559 2 David.Ronis 2009-07-14 07:58:27 -0700 Manually adding the declaration, while allowing thing to compile, doesn't work. Things die linking. Bacially it's not in glib. 131564 3 David.Ronis 2009-07-14 08:09:58 -0700 It seems that g_mapped_file_free needs to be replaced by g_mapped_file_unref. Doing so lets the compile finish. 132830 4 33002 jmalonzo 2009-07-17 19:34:47 -0700 Created attachment 33002 Use g_mapped_file_unref for GLIB version 2.22 onwards. 132958 5 33002 gustavo 2009-07-18 16:12:46 -0700 Comment on attachment 33002 Use g_mapped_file_unref for GLIB version 2.22 onwards. yep! r=me 132959 6 jmalonzo 2009-07-18 16:14:29 -0700 (In reply to comment #5) > (From update of attachment 33002 [details]) > yep! r=me Landed as http://trac.webkit.org/changeset/46101 33002 2009-07-17 19:34:47 -0700 2009-07-18 16:12:45 -0700 Use g_mapped_file_unref for GLIB version 2.22 onwards. bug-27230-20090718123444.patch text/plain 2015 jmalonzo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDE2MmY2MC4uYjRmYmQ5YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNy0xNyAgSmFuIE1pY2hhZWwg QWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBzb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHA6 NTMzOiBlcnJvcjogJ2dfbWFwcGVkX2ZpbGVfZnJlZScgd2FzIG5vdCBkZWNsYXJlZCBpbiB0aGlz IHNjb3BlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y NzIzMAorCisgICAgICAgIFVzZSBnX21hcHBlZF9maWxlX3VucmVmIGZvciBHTElCIHZlcnNpb24g Mi4yMiBvbndhcmRzLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNl SGFuZGxlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZTo6c3RhcnRI dHRwKToKKwogMjAwOS0wNy0xNyAgQW50b24gTXVoaW4gIDxhbnRvbm1AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgYi9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCmluZGV4IDYxM2Y2 OTMuLmZhMjg0MGIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jl c291cmNlSGFuZGxlU291cC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv UmVzb3VyY2VIYW5kbGVTb3VwLmNwcApAQCAtNTI3LDEwICs1MjcsMTUgQEAgYm9vbCBSZXNvdXJj ZUhhbmRsZTo6c3RhcnRIdHRwKFN0cmluZyB1cmxTdHJpbmcpCiAKICAgICAgICAgICAgICAgICAg ICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgICAgICAgICAgICAgfQotCisjaWYgR0xJQl9D SEVDS19WRVJTSU9OKDIsIDIyLCAwKQorICAgICAgICAgICAgICAgICAgICBTb3VwQnVmZmVyKiBz b3VwQnVmZmVyID0gc291cF9idWZmZXJfbmV3X3dpdGhfb3duZXIoZ19tYXBwZWRfZmlsZV9nZXRf Y29udGVudHMoZmlsZU1hcHBpbmcpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ19tYXBwZWRfZmlsZV9nZXRf bGVuZ3RoKGZpbGVNYXBwaW5nKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZpbGVNYXBwaW5nLCByZWludGVy cHJldF9jYXN0PEdEZXN0cm95Tm90aWZ5PihnX21hcHBlZF9maWxlX3VucmVmKSk7CisjZWxzZQog ICAgICAgICAgICAgICAgICAgICBTb3VwQnVmZmVyKiBzb3VwQnVmZmVyID0gc291cF9idWZmZXJf bmV3X3dpdGhfb3duZXIoZ19tYXBwZWRfZmlsZV9nZXRfY29udGVudHMoZmlsZU1hcHBpbmcpLAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZ19tYXBwZWRfZmlsZV9nZXRfbGVuZ3RoKGZpbGVNYXBwaW5nKSwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGZpbGVNYXBwaW5nLCByZWludGVycHJldF9jYXN0PEdEZXN0cm95Tm90aWZ5 PihnX21hcHBlZF9maWxlX2ZyZWUpKTsKKyNlbmRpZgogICAgICAgICAgICAgICAgICAgICBzb3Vw X21lc3NhZ2VfYm9keV9hcHBlbmRfYnVmZmVyKGQtPm1fbXNnLT5yZXF1ZXN0X2JvZHksIHNvdXBC dWZmZXIpOwogICAgICAgICAgICAgICAgICAgICBzb3VwX2J1ZmZlcl9mcmVlKHNvdXBCdWZmZXIp OwogICAgICAgICAgICAgICAgIH0=