<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>27205</bug_id>
          
          <creation_ts>2009-07-12 23:00:47 -0700</creation_ts>
          <short_desc>[Qt] Buildfix for QtWebKit on Win</short_desc>
          <delta_ts>2009-07-13 07:55:08 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Laszlo Gombos">laszlo.gombos</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>vestbo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>131249</commentid>
    <comment_count>0</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-07-12 23:00:47 -0700</bug_when>
    <thetext>On Windows the target binary filename includes the major QtWebKit version number (e.g. QtWebKit4.lib, libQtWebKit4.a, QtWebKit4.dll).
The version number needs to be included in the filename when linking against QtWebkit on win (e.g. when building QtLauncher) otherwise the linker will not find the library.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>131254</commentid>
    <comment_count>1</comment_count>
      <attachid>32647</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-07-12 23:41:57 -0700</bug_when>
    <thetext>Created attachment 32647
Proposed patch.

Tested on win32-msvc2005.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>131312</commentid>
    <comment_count>2</comment_count>
      <attachid>32647</attachid>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2009-07-13 07:47:59 -0700</bug_when>
    <thetext>Comment on attachment 32647
Proposed patch.

Looks good, thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>131315</commentid>
    <comment_count>3</comment_count>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2009-07-13 07:55:08 -0700</bug_when>
    <thetext>Landed in r45821 = 1c014fef133212af762efdf187b54bfe1be4dcf2 (svn/trunk)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>32647</attachid>
            <date>2009-07-12 23:41:57 -0700</date>
            <delta_ts>2009-07-13 07:47:59 -0700</delta_ts>
            <desc>Proposed patch.</desc>
            <filename>patch_27205.txt</filename>
            <type>text/plain</type>
            <size>1113</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ1Nzg5
KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDct
MTIgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQnVpbGQgZml4IGZv
ciBRdFdlYktpdCBvbiBXaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTI3MjA1CisKKyAgICAgICAgKiBXZWJLaXQucHJpOiBJbmNsdWRlIHRoZSBtYWpv
ciB2ZXJzaW9uIG51bWJlciBpbiB0aGUgUXRXZWJLaXQKKyAgICAgICAgbGlicmFyeSBmaWxlIGZv
ciBXaW4uCisKIDIwMDktMDctMTIgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAg
ICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYS4KSW5kZXg6IFdlYktpdC5wcmkKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gV2ViS2l0LnByaQkocmV2aXNpb24gNDU3NTgpCisrKyBXZWJLaXQucHJpCSh3
b3JraW5nIGNvcHkpCkBAIC0yMSw3ICsyMSwxMSBAQCBidWlsZGluZy1saWJzIHsKICAgICAgICAg
ICAgIExJQlMgKz0gLWZyYW1ld29yayBRdFdlYktpdAogICAgICAgICAgICAgUU1BS0VfRlJBTUVX
T1JLUEFUSCA9ICQkT1VUUFVUX0RJUi9saWIgJCRRTUFLRV9GUkFNRVdPUktQQVRICiAgICAgICAg
IH0gZWxzZSB7Ci0gICAgICAgICAgICBMSUJTICs9IC1sUXRXZWJLaXQKKyAgICAgICAgICAgIHdp
bjMyLSp8d2luY2UqIHsKKyAgICAgICAgICAgICAgICBMSUJTICs9IC1sUXRXZWJLaXQkJHtRVF9N
QUpPUl9WRVJTSU9OfQorICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICAgICBMSUJT
ICs9IC1sUXRXZWJLaXQKKyAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KICAgICBERVBF
TkRQQVRIICs9ICQkUFdEL1dlYktpdC9xdC9BcGkK
</data>
<flag name="review"
          id="17042"
          type_id="1"
          status="+"
          setter="vestbo"
    />
          </attachment>
      

    </bug>

</bugzilla>