271993 2024-04-01 13:51:09 -0700 CheckedPtr should require FastMalloc, Part 2 2024-04-04 08:23:14 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren dpino dpino webkit-bug-importer oldest_to_newest 2025200 0 ggaren 2024-04-01 13:51:09 -0700 ... 2025201 1 webkit-bug-importer 2024-04-01 13:51:21 -0700 <rdar://problem/125737157> 2025225 2 ggaren 2024-04-01 14:41:37 -0700 Pull request: https://github.com/WebKit/WebKit/pull/26701 2025785 3 ews-feeder 2024-04-03 12:52:54 -0700 Committed 277020@main (8b7d41505065): <https://commits.webkit.org/277020@main> Reviewed commits have been landed. Closing PR #26701 and removing active labels. 2025923 4 dpino 2024-04-04 01:31:26 -0700 After this change, the build for GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 is failing with the following build error: https://build.webkit.org/#/builders/30/builds/8885 ``` FAILED: In file included from ../../../Source/WebCore/platform/mediastream/libwebrtc/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:23, from WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-72.cpp:7: ../../../Source/WebCore/platform/mediastream/libwebrtc/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h: In static member function ‘static WTF::Ref<WebCore::RealtimeOutgoingAudioSourceLibWebRTC> WebCore::RealtimeOutgoingAudioSourceLibWebRTC::create(WTF::Ref<WebCore::MediaStreamTrackPrivate>&&)’: ../../../Source/WebCore/platform/mediastream/libwebrtc/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h:36:93: error: invalid new-expression of abstract class type ‘WebCore::RealtimeOutgoingAudioSourceLibWebRTC’ 36 | return adoptRef(*new RealtimeOutgoingAudioSourceLibWebRTC(WTFMove(audioTrackPrivate))); | ^ ../../../Source/WebCore/platform/mediastream/libwebrtc/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h:32:7: note: because the following virtual functions are pure within ‘WebCore::RealtimeOutgoingAudioSourceLibWebRTC’: 32 | class RealtimeOutgoingAudioSourceLibWebRTC final : public RealtimeOutgoingAudioSource { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from ../../../Source/WebCore/platform/mediastream/RealtimeIncomingAudioSource.h:36, from ../../../Source/WebCore/platform/mediastream/libwebrtc/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.h:32, from ../../../Source/WebCore/platform/mediastream/libwebrtc/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.cpp:31, from WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-72.cpp:5: ../../../Source/WebCore/platform/mediastream/RealtimeMediaSource.h:115:26: note: ‘virtual uint32_t WebCore::RealtimeMediaSource::AudioSampleObserver::ptrCount() const’ 115 | virtual uint32_t ptrCount() const = 0; | ^~~~~~~~ ../../../Source/WebCore/platform/mediastream/RealtimeMediaSource.h:116:22: note: ‘virtual void WebCore::RealtimeMediaSource::AudioSampleObserver::incrementPtrCount() const’ 116 | virtual void incrementPtrCount() const = 0; | ^~~~~~~~~~~~~~~~~ ../../../Source/WebCore/platform/mediastream/RealtimeMediaSource.h:117:22: note: ‘virtual void WebCore::RealtimeMediaSource::AudioSampleObserver::decrementPtrCount() const’ 117 | virtual void decrementPtrCount() const = 0; | ^~~~~~~~~~~~~~~~~ GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 and WPE-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 are the only bots that build WebKitGTK and WPE, respectively, with LibWebRTC, that's why this build error was not caught by the EWS bots. 2025924 5 dpino 2024-04-04 01:32:04 -0700 Re-opening for pull request https://github.com/webkit/webkit/pull/26836 2025983 6 ews-feeder 2024-04-04 08:23:12 -0700 Committed 277053@main (cd9be0fded51): <https://commits.webkit.org/277053@main> Reviewed commits have been landed. Closing PR #26836 and removing active labels.