<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>271977</bug_id>
          
          <creation_ts>2024-04-01 11:43:27 -0700</creation_ts>
          <short_desc>REGRESSION (276827@main): When drawing a pattern, get the oriented image frame only if the orientation is not TopLeft</short_desc>
          <delta_ts>2024-04-01 14:36:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Images</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=265363</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>265363</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Said Abou-Hallawa">sabouhallawa</reporter>
          <assigned_to name="Said Abou-Hallawa">sabouhallawa</assigned_to>
          <cc>sabouhallawa</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2025140</commentid>
    <comment_count>0</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2024-04-01 11:43:27 -0700</bug_when>
    <thetext>BitmapImage::drawPattern() uses ImageOrientation::Orientation::FromImage when using the current ImageFrame to draw the pattern. We end up calling BitmapImageSource::preTransformedNativeImageAtIndex() via other calls. After 276827@main, this function checks

if (orientation == ImageOrientation::Orientation::None &amp;&amp; size == sourceSize)
    return nativeImage;

Before resolving the orientation if FromImage is passed. We then resolve the image orientation.

if (orientation == ImageOrientation::Orientation::FromImage)
    orientation = frameOrientationAtIndex(index);

We then draw the current ImageFrame to a temporary ImageBuffer then we sink the drawn the ImageBuffer to a new NativeImage. This step is not needed if image orientation is TopLeft. We can just return the original image frame.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2025151</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-04-01 12:10:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/125731142&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2025160</commentid>
    <comment_count>2</comment_count>
    <who name="Said Abou-Hallawa">sabouhallawa</who>
    <bug_when>2024-04-01 12:28:33 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/26688</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2025220</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-04-01 14:36:15 -0700</bug_when>
    <thetext>Committed 276902@main (34d1f9aabb7b): &lt;https://commits.webkit.org/276902@main&gt;

Reviewed commits have been landed. Closing PR #26688 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>