271729 2024-03-26 14:31:51 -0700 Rename *widthFor* functions 2024-03-26 17:10:55 -0700 1 1 1 Unclassified WebKit Text Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 vitor.roriz webkit-unassigned fantasai.bugs fujii vitor.roriz webkit-bug-importer oldest_to_newest 2024020 0 vitor.roriz 2024-03-26 14:31:51 -0700 We currently have: 1. widthForSimpleText 2. floatWidthForSimpleText 3. floatWidthForComplexText These functions all do something similar but their names are a bit confusing, specially by the different meanings of the word "simple" here. As previously described by @zallan with other words, the 3 function scale in level of complexity. 1. widthForSimpleText: does not use any width iterator, but has to pass "computeCanUseSimplifiedTextMeasuring" to be used. 2. floatWidthForSimpleText: It is used when we have a CodePath::Simple (calculated on FontCascade). It uses iterator WidthIterator 3. floatWidthForComplexText: It is used when we have a CodePath::Complex (calculated on FontCascade). It uses the ComplexTextControler, a more complete and slower iterator (supports kerning and ligaments, for example, which are currently not supported by WidthIterator). We could probably have more explicit names for avoiding the confusion. 2024021 1 webkit-bug-importer 2024-03-26 14:32:14 -0700 <rdar://problem/125440731> 2024026 2 vitor.roriz 2024-03-26 14:43:07 -0700 Pull request: https://github.com/WebKit/WebKit/pull/26483 2024050 3 ews-feeder 2024-03-26 17:01:00 -0700 Committed 276716@main (31aadb040e32): <https://commits.webkit.org/276716@main> Reviewed commits have been landed. Closing PR #26483 and removing active labels.