271716 2024-03-26 11:11:39 -0700 Port.default_child_processes is totally ignored for second-and-later device_types, even when zero 2024-04-19 13:13:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=261175 InRadar P2 Normal --- 1 gsnedders gsnedders jbedard ryanhaddad webkit-bug-importer oldest_to_newest 2023964 0 gsnedders 2024-03-26 11:11:39 -0700 After bug 261175, 267745@main, due to explicitly setting `child_processes_option_value` the minimum value we set self._options.child_processes to is now zero, which means the below conditional can only ever evaluate to True on the first iteration. This is almost certainly unintended. 2023971 1 gsnedders 2024-03-26 12:06:33 -0700 I guess this only actually has broken anything when Port.default_child_processes() is zero and Port.max_child_processes() is not, which I think never actually happens for any existing Port. Regardless, it adds very much a confusing edge-case in our code flow, and the comment is misleading: it has no impact on retries (we already hardcoded num_workers=1 in _run_test_subset). 2023973 2 gsnedders 2024-03-26 12:23:38 -0700 Pull request: https://github.com/WebKit/WebKit/pull/26475 2025445 3 webkit-bug-importer 2024-04-02 11:12:14 -0700 <rdar://problem/125793341> 2029936 4 ews-feeder 2024-04-19 13:13:15 -0700 Committed 277755@main (0de43f2ad98a): <https://commits.webkit.org/277755@main> Reviewed commits have been landed. Closing PR #26475 and removing active labels.