27171 2009-07-10 19:56:31 -0700 [Gtk] REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html 2009-07-13 03:12:21 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 jmalonzo webkit-unassigned oldest_to_newest 131052 0 jmalonzo 2009-07-10 19:56:31 -0700 Changeset: http://trac.webkit.org/changeset/45440 Test: fast/events/frame-programmatic-focus.html Test diff: <input> focused <input> blurred main frame blurred -iframe focused <input> in iframe focused <input> in frame blurred iframe blurred -main frame focused <input> focused The fix in http://trac.webkit.org/changeset/45470 is incomplete. focus-in and focus-out events seem to only happen when there's user interaction. The fix is to implement grab_focus in the WebView as well so it will work when focus is set programmatically. Patch coming... 131054 1 32605 jmalonzo 2009-07-10 20:04:39 -0700 Created attachment 32605 implement grab-focus 131168 2 32605 gustavo 2009-07-12 04:40:57 -0700 Comment on attachment 32605 implement grab-focus > - core(webView)->focusController()->setActive(frame); > - core(webView)->focusController()->setFocused(true); > + focusController->setActive(true); > + focusController->setFocused(true); The only change that makes me a bit nervous is going from frame to true here. I believe there might have been a reason to not set it unconditionally? r=me, but please either revert this specific change, or add a comment here on the bug so that we have a way of tracking this down. 131287 3 jmalonzo 2009-07-13 03:12:21 -0700 (In reply to comment #2) > (From update of attachment 32605 [details]) > > - core(webView)->focusController()->setActive(frame); > > - core(webView)->focusController()->setFocused(true); > > + focusController->setActive(true); > > + focusController->setFocused(true); > > The only change that makes me a bit nervous is going from frame to true here. I > believe there might have been a reason to not set it unconditionally? r=me, but > please either revert this specific change, or add a comment here on the bug so > that we have a way of tracking this down. Thanks. I reverted the change and landed it in http://trac.webkit.org/changeset/45802. 32605 2009-07-10 20:04:39 -0700 2009-07-12 04:40:57 -0700 implement grab-focus programmaticfocus.patch text/plain 3196 jmalonzo ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNGMzMjk5Yy4uZWYxMDUwOCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0wNy0xMCAg SmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KKworICAgICAgICA8aHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3MTcxPiBbR3RrXQorICAgICAg ICBSRUdSRVNTSU9OIChyNDU0NDApOiBmYWlscyBhdCBmYXN0L2V2ZW50cy9mcmFtZS1wcm9ncmFt bWF0aWMtZm9jdXMuaHRtbAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGZvY3VzLWluIGFuZCBmb2N1cy1vdXQgZXZlbnRzIG9ubHkgZ2V0IHRyaWdnZXJl ZCB3aGVuIHRoZXJlJ3MgdXNlcgorICAgICAgICBpbnRlcmFjdGlvbiwgaGVuY2Ugc2V0Rm9jdXNl ZChib29sKSBuZXZlciBnZXRzIGNhbGxlZCB3aGVuCisgICAgICAgIGZvY3VzRXZlbnQgaXMgdHJp Z2dlcmVkIHdoZW4gcnVubmluZyB0aGUgbGF5b3V0IHRlc3RzLiBUaGUKKyAgICAgICAgc29sdXRp b24gc2VlbXMgdG8gYmUgdG8gaW1wbGVtZW50IGdyYWItZm9jdXMgdG9vIHNvIHdlIGNhbiBjYWxs CisgICAgICAgIHNldEZvY3VzZWQoYm9vbCkgd2hlbiBhIHdpZGdldCBoYXMgZm9jdXMuCisKKyAg ICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3Zp ZXdfZ3JhYl9mb2N1cyk6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfZm9jdXNfaW5fZXZlbnQp OgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQpOgorCiAyMDA5LTA3LTA5ICBC ZXRoIERha2luIGFuZCBKb24gSG9uZXljdXR0IDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93 ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmlu ZGV4IGM1MDc1N2YuLjE4NDE3NTggMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHdlYnZpZXcuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBA IC01NTksNiArNTU5LDE3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19zaXplX2FsbG9j YXRlKEd0a1dpZGdldCogd2lkZ2V0LCBHdGtBbGxvY2F0aW9uKiBhbGxvCiAgICAgZnJhbWUtPnZp ZXcoKS0+YWRqdXN0Vmlld1NpemUoKTsKIH0KIAorc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3 X2dyYWJfZm9jdXMoR3RrV2lkZ2V0KiB3aWRnZXQpCit7CisgICAgaWYgKEdUS19XSURHRVRfSVNf U0VOU0lUSVZFKHdpZGdldCkpIHsKKyAgICAgICAgV2ViS2l0V2ViVmlldyogd2ViVmlldyA9IFdF QktJVF9XRUJfVklFVyh3aWRnZXQpOworICAgICAgICBGb2N1c0NvbnRyb2xsZXIqIGZvY3VzQ29u dHJvbGxlciA9IGNvcmUod2ViVmlldyktPmZvY3VzQ29udHJvbGxlcigpOworICAgICAgICBjb3Jl KHdlYlZpZXcpLT5mb2N1c0NvbnRyb2xsZXIoKS0+c2V0Rm9jdXNlZCh0cnVlKTsKKyAgICB9CisK KyAgICByZXR1cm4gR1RLX1dJREdFVF9DTEFTUyh3ZWJraXRfd2ViX3ZpZXdfcGFyZW50X2NsYXNz KS0+Z3JhYl9mb2N1cyh3aWRnZXQpOworfQorCiBzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0X3dlYl92 aWV3X2ZvY3VzX2luX2V2ZW50KEd0a1dpZGdldCogd2lkZ2V0LCBHZGtFdmVudEZvY3VzKiBldmVu dCkKIHsKICAgICAvLyBUT0RPOiBJbXByb3ZlIGZvY3VzIGhhbmRsaW5nIGFzIHN1Z2dlc3RlZCBp bgpAQCAtNTY2LDEwICs1NzcsMTAgQEAgc3RhdGljIGdib29sZWFuIHdlYmtpdF93ZWJfdmlld19m b2N1c19pbl9ldmVudChHdGtXaWRnZXQqIHdpZGdldCwgR2RrRXZlbnRGb2N1cyoKICAgICBHdGtX aWRnZXQqIHRvcGxldmVsID0gZ3RrX3dpZGdldF9nZXRfdG9wbGV2ZWwod2lkZ2V0KTsKICAgICBp ZiAoR1RLX1dJREdFVF9UT1BMRVZFTCh0b3BsZXZlbCkgJiYgZ3RrX3dpbmRvd19oYXNfdG9wbGV2 ZWxfZm9jdXMoR1RLX1dJTkRPVyh0b3BsZXZlbCkpKSB7CiAgICAgICAgIFdlYktpdFdlYlZpZXcq IHdlYlZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcod2lkZ2V0KTsKKyAgICAgICAgRm9jdXNDb250cm9s bGVyKiBmb2N1c0NvbnRyb2xsZXIgPSBjb3JlKHdlYlZpZXcpLT5mb2N1c0NvbnRyb2xsZXIoKTsK IAotICAgICAgICBGcmFtZSogZnJhbWUgPSBjb3JlKHdlYlZpZXcpLT5tYWluRnJhbWUoKTsKLSAg ICAgICAgY29yZSh3ZWJWaWV3KS0+Zm9jdXNDb250cm9sbGVyKCktPnNldEFjdGl2ZShmcmFtZSk7 Ci0gICAgICAgIGNvcmUod2ViVmlldyktPmZvY3VzQ29udHJvbGxlcigpLT5zZXRGb2N1c2VkKHRy dWUpOworICAgICAgICBmb2N1c0NvbnRyb2xsZXItPnNldEFjdGl2ZSh0cnVlKTsKKyAgICAgICAg Zm9jdXNDb250cm9sbGVyLT5zZXRGb2N1c2VkKHRydWUpOwogICAgIH0KICAgICByZXR1cm4gR1RL X1dJREdFVF9DTEFTUyh3ZWJraXRfd2ViX3ZpZXdfcGFyZW50X2NsYXNzKS0+Zm9jdXNfaW5fZXZl bnQod2lkZ2V0LCBldmVudCk7CiB9CkBAIC0xNzQ5LDYgKzE3NjAsNyBAQCBzdGF0aWMgdm9pZCB3 ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFz cykKICAgICB3aWRnZXRDbGFzcy0+c2Nyb2xsX2V2ZW50ID0gd2Via2l0X3dlYl92aWV3X3Njcm9s bF9ldmVudDsKICAgICB3aWRnZXRDbGFzcy0+c2l6ZV9hbGxvY2F0ZSA9IHdlYmtpdF93ZWJfdmll d19zaXplX2FsbG9jYXRlOwogICAgIHdpZGdldENsYXNzLT5wb3B1cF9tZW51ID0gd2Via2l0X3dl Yl92aWV3X3BvcHVwX21lbnVfaGFuZGxlcjsKKyAgICB3aWRnZXRDbGFzcy0+Z3JhYl9mb2N1cyA9 IHdlYmtpdF93ZWJfdmlld19ncmFiX2ZvY3VzOwogICAgIHdpZGdldENsYXNzLT5mb2N1c19pbl9l dmVudCA9IHdlYmtpdF93ZWJfdmlld19mb2N1c19pbl9ldmVudDsKICAgICB3aWRnZXRDbGFzcy0+ Zm9jdXNfb3V0X2V2ZW50ID0gd2Via2l0X3dlYl92aWV3X2ZvY3VzX291dF9ldmVudDsKICAgICB3 aWRnZXRDbGFzcy0+Z2V0X2FjY2Vzc2libGUgPSB3ZWJraXRfd2ViX3ZpZXdfZ2V0X2FjY2Vzc2li bGU7Cg==