271696 2024-03-26 01:31:16 -0700 [LibWebRTC][Linux] Make PulseAudio support optional 2024-03-26 23:45:44 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 philn dpino dpino oldest_to_newest 2023873 0 philn 2024-03-26 01:31:16 -0700 ssia 2023874 1 pnormand 2024-03-26 01:35:19 -0700 Pull request: https://github.com/WebKit/WebKit/pull/26455 2023997 2 ews-feeder 2024-03-26 13:10:34 -0700 Committed 276708@main (b5a59471fd29): <https://commits.webkit.org/276708@main> Reviewed commits have been landed. Closing PR #26455 and removing active labels. 2024107 3 dpino 2024-03-26 23:12:55 -0700 After this change the GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004 bot was failing with the following build error: ``` CMake Error at Source/ThirdParty/libwebrtc/CMakeLists.txt:2172 (target_include_directories): Cannot specify include directories for target "webrtc" which is not built by this project. CMake Error at Source/ThirdParty/libwebrtc/CMakeLists.txt:2173 (target_compile_options): Cannot specify compile options for target "webrtc" which is not built by this project. ``` 'webrtc' is not defined yet at those lines, so they should be moved below in the file. 2024108 4 dpino 2024-03-26 23:13:30 -0700 Re-opening for pull request https://github.com/webkit/webkit/pull/26500 2024110 5 ews-feeder 2024-03-26 23:45:43 -0700 Committed 276724@main (b81583054864): <https://commits.webkit.org/276724@main> Reviewed commits have been landed. Closing PR #26500 and removing active labels.