27163 2009-07-10 16:33:12 -0700 Fix memory leak in V8 bindings 2009-07-13 02:33:11 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ager webkit-unassigned abarth dglazkov eric levin oldest_to_newest 131007 0 ager 2009-07-10 16:33:12 -0700 Reinitializing the context when clearing the V8 proxy for navigation makes us hold on to a context object per frame that we should not hold on to. Reinitialization is not necessary. When updating the document wrapper cache, we check that the global object handle is not empty, we should be checking the context. 131008 1 32591 ager 2009-07-10 16:34:15 -0700 Created attachment 32591 patch to avoid leaking contexts 131095 2 32591 abarth 2009-07-10 23:30:41 -0700 Comment on attachment 32591 patch to avoid leaking contexts These seem like two independent changes, but that's ok. I don't understand why calling initContextIfNeeded() in clearForNavigation() leads to a leak, but it makes sense that this isn't needed because all the other entry points are super excited about making sure the context is initialized before they use it. I'm r+ing this, but it would be helpful for Dimitri to give his opinion as well. 131109 3 dglazkov 2009-07-11 08:28:16 -0700 I am pretty sure this will work, but please make sure this doesn't break any layout tests. 131115 4 ager 2009-07-11 10:23:20 -0700 I ran all layout tests in both release and debug mode before uploading the patch and saw no new failures with this change. Adam, Dimitri, could one of you land this patch for me? 131117 5 abarth 2009-07-11 10:49:13 -0700 (In reply to comment #4) > Adam, Dimitri, could one of you land this patch for me? Sure, but we should wait for the canary to compile before landing this so we can see if there are regressions. 131279 6 levin 2009-07-13 02:18:50 -0700 A note for the future: Please make sure to put a link to the bug in the changelog. 131281 7 levin 2009-07-13 02:33:11 -0700 Committed as http://trac.webkit.org/changeset/45797 32591 2009-07-10 16:34:15 -0700 2009-07-10 23:30:41 -0700 patch to avoid leaking contexts context-leak.txt text/plain 1648 ager SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTczMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDctMTAgIE1hZHMgQWdlciAgPGFnZXJAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBt ZW1vcnkgbGVhayBpbiB0aGUgVjggYmluZGluZyBsYXllci4gUmVpbml0aWFsaXppbmcgdGhlCisg ICAgICAgIGNvbnRleHQgaXMgbm90IG5lY2Vzc2FyeSB3aGVuIGNsZWFyaW5nIHRoZSBwcm94eSBm b3IgbmF2aWdhdGlvbgorICAgICAgICBhbmQgaXQgd2lsbCBsZWFkIHVzIHRvIGhvbGQgb24gdG8g YW4gZW1wdHkgY29udGV4dCBmb3IgZWFjaCBmcmFtZS4KKworICAgICAgICBUZXN0IGZvciBlbXB0 eSBjb250ZXh0IGluc3RlYWQgb2YgZW1wdHkgZ2xvYmFsIG9iamVjdCBoYW5kbGUgd2hlbgorICAg ICAgICB1cGRhdGluZyB0aGUgZG9jdW1lbnQgZm9yIGEgY29udGV4dC4KKworICAgICAgICAqIGJp bmRpbmdzL3Y4L1Y4UHJveHkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhQcm94eTo6Y2xlYXJG b3JOYXZpZ2F0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlY4UHJveHk6OnVwZGF0ZURvY3VtZW50 KToKKwogMjAwOS0wNy0xMCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAg ICAgICAgVHJ5IHRvIHVuYnJlYWsgbm9uLU1hYyBidWlsZC4KSW5kZXg6IFdlYkNvcmUvYmluZGlu Z3MvdjgvVjhQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOFBy b3h5LmNwcAkocmV2aXNpb24gNDU3MzApCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHku Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC05OTQsMTAgKzk5NCw2IEBAIHZvaWQgVjhQcm94eTo6Y2xl YXJGb3JOYXZpZ2F0aW9uKCkKICAgICAgICAgbV9jb250ZXh0LT5EZXRhY2hHbG9iYWwoKTsKIAog ICAgICAgICBkaXNwb3NlQ29udGV4dEhhbmRsZXMoKTsKLQotICAgICAgICAvLyBSZWluaXRpYWxp emUgdGhlIGNvbnRleHQgc28gdGhlIGdsb2JhbCBvYmplY3QgcG9pbnRzIHRvCi0gICAgICAgIC8v IHRoZSBuZXcgRE9NIHdpbmRvdy4KLSAgICAgICAgaW5pdENvbnRleHRJZk5lZWRlZCgpOwogICAg IH0KIH0KIApAQCAtMTA0MSwxMCArMTAzNyw4IEBAIHZvaWQgVjhQcm94eTo6dXBkYXRlRG9jdW1l bnQoKQogICAgIGlmICghbV9mcmFtZS0+ZG9jdW1lbnQoKSkKICAgICAgICAgcmV0dXJuOwogCi0g ICAgaWYgKG1fZ2xvYmFsLklzRW1wdHkoKSkgewotICAgICAgICBBU1NFUlQobV9jb250ZXh0Lklz RW1wdHkoKSk7CisgICAgaWYgKG1fY29udGV4dC5Jc0VtcHR5KCkpIAogICAgICAgICByZXR1cm47 Ci0gICAgfQogCiAgICAgLy8gV2UgaGF2ZSBhIG5ldyBkb2N1bWVudCBhbmQgd2UgbmVlZCB0byB1 cGRhdGUgdGhlIGNhY2hlLgogICAgIHVwZGF0ZURvY3VtZW50V3JhcHBlckNhY2hlKCk7Cg==