27155 2009-07-10 13:21:02 -0700 bug in V8Custom invokeCallback which will crash on void callbacks 2009-07-13 02:34:27 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 johnnyg webkit-unassigned levin oldest_to_newest 130927 0 johnnyg 2009-07-10 13:21:02 -0700 There's an incorrect check for an empty result in V8CustomVoidCallback.cpp. 131001 1 32589 johnnyg 2009-07-10 16:05:33 -0700 Created attachment 32589 Fix the logic for computing the return value One-character fix to the logic for computing the return value. 131278 2 levin 2009-07-13 02:14:27 -0700 Note for the future: Please avoid TABs (in the changelog). 131282 3 levin 2009-07-13 02:34:27 -0700 Committed as http://trac.webkit.org/changeset/45796 32589 2009-07-10 16:05:33 -0700 2009-07-10 16:25:32 -0700 Fix the logic for computing the return value v8patch.diff text/plain 1278 johnnyg SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTczMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDctMTAgIEpvaG4gR3JlZ2cgIDxqb2hubnlnQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwlDb3JyZWN0IHRo ZSBsb2dpYyB0byBkZXRlcm1pbmUgaWYgYSBWOCBjYWxsYmFjayByZXR1cm5zIGEgdmFsdWUuCisJ aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3MTU1CisgICAgICAgIAor CSogYmluZGluZ3MvdjgvY3VzdG9tL1Y4Q3VzdG9tVm9pZENhbGxiYWNrLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Omludm9rZUNhbGxiYWNrKToKKwkgLSBEb24ndCBjcmFzaCBpZiByZXN1bHQuSXNF bXB0eSgpLgorCiAyMDA5LTA3LTEwICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KSW5kZXg6IFdlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4Q3VzdG9tVm9pZENhbGxiYWNrLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEN1c3RvbVZvaWRDYWxsYmFjay5jcHAJKHJldmlz aW9uIDQ1NzMxKQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhDdXN0b21Wb2lkQ2Fs bGJhY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04OSw3ICs4OSw3IEBAIGJvb2wgaW52b2tlQ2Fs bGJhY2sodjg6OlBlcnNpc3RlbnQ8djg6Ok8KIAogICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBy ZXN1bHQgPSBwcm94eS0+Y2FsbEZ1bmN0aW9uKGNhbGxiYWNrRnVuY3Rpb24sIHRoaXNPYmplY3Qs IGFyZ2MsIGFyZ3YpOwogCi0gICAgY2FsbGJhY2tSZXR1cm5WYWx1ZSA9IHJlc3VsdC5Jc0VtcHR5 KCkgJiYgcmVzdWx0LT5Jc0Jvb2xlYW4oKSAmJiByZXN1bHQtPkJvb2xlYW5WYWx1ZSgpOworICAg IGNhbGxiYWNrUmV0dXJuVmFsdWUgPSAhcmVzdWx0LklzRW1wdHkoKSAmJiByZXN1bHQtPklzQm9v bGVhbigpICYmIHJlc3VsdC0+Qm9vbGVhblZhbHVlKCk7CiAKICAgICByZXR1cm4gZXhjZXB0aW9u Q2F0Y2hlci5IYXNDYXVnaHQoKTsKIH0K