27150 2009-07-10 11:05:08 -0700 REGRESSION (r45647): prepare-ChangeLog -d puts non-diff lines into the diff 2009-07-10 12:19:24 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 aroben webkit-unassigned mjs oldest_to_newest 130892 0 aroben 2009-07-10 11:05:08 -0700 To reproduce: 1. echo foo >> WebCore/DerivedSources.make 2. prepare-ChangeLog -d WebCore > WebCoreChanges.diff WebCoreChanges.diff will contain the following lines at the beginning: -- Please remember to include a detailed description in your ChangeLog entry. -- -- See <http://webkit.org/coding/contributing.html> for more info -- Those lines should have been printed to the terminal (i.e., STDERR), not into the diff. 130895 1 32564 aroben 2009-07-10 11:18:11 -0700 Created attachment 32564 Print prepare-ChangeLog's reminders to the STDERR so they don't end up in the diff output 130905 2 32564 mjs 2009-07-10 11:48:34 -0700 Comment on attachment 32564 Print prepare-ChangeLog's reminders to the STDERR so they don't end up in the diff output r=me 130915 3 aroben 2009-07-10 12:19:24 -0700 Fixed in r45718 32564 2009-07-10 11:18:11 -0700 2009-07-10 11:48:33 -0700 Print prepare-ChangeLog's reminders to the STDERR so they don't end up in the diff output bug-27150-20090710141810.patch text/plain 1506 aroben ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiZjdlYzViLi4zNzc2ODAyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDct MTAgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgorCisgICAgICAgIFByaW50IHByZXBh cmUtQ2hhbmdlTG9nJ3MgcmVtaW5kZXJzIHRvIHRoZSBTVERFUlIgc28gdGhleSBkb24ndCBlbmQg dXAKKyAgICAgICAgaW4gdGhlIGRpZmYgb3V0cHV0CisKKyAgICAgICAgRml4ZXMgUkVHUkVTU0lP TiAocjQ1NjQ3KTogcHJlcGFyZS1DaGFuZ2VMb2cgLWQgcHV0cyBub24tZGlmZiBsaW5lcworICAg ICAgICBpbnRvIHRoZSBkaWZmCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjcxNTA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nOgorCiAyMDA5LTA3LTA4ICBB ZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgY2FzZS1pbnNlbnNp dGl2ZSBjb21wYXJpc29ucyB3aGVuIHNvcnRpbmcgWGNvZGUgcHJvamVjdCBmaWxlcwpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZyBiL1dlYktpdFRvb2xz L1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKaW5kZXggZTc4MWU4My4uNTViNjBjMCAxMDA3NTUK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZworKysgYi9XZWJLaXRU b29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCkBAIC0zNDAsNyArMzQwLDcgQEAgZm9yZWFj aCBteSAkcHJlZml4IChzb3J0IGtleXMgJWZpbGVzKSB7CiAgICAgcHJpbnQgQ0hBTkdFX0xPRyAi XG4iOwogCiAgICAgIyBXZSBjb3VsZCBwcmUtcG9wdWxhdGUgdGhpcyB3aXRoIHRoZSBnaXQgY29t bWl0IGxvZyBvciB3aXRoIHRoZSBidWcgZGVzY3JpcHRpb24uCi0gICAgcHJpbnQgKCItLSBQbGVh c2UgcmVtZW1iZXIgdG8gaW5jbHVkZSBhIGRldGFpbGVkIGRlc2NyaXB0aW9uIGluIHlvdXIgQ2hh bmdlTG9nIGVudHJ5LiAtLVxuLS0gU2VlIDxodHRwOi8vd2Via2l0Lm9yZy9jb2RpbmcvY29udHJp YnV0aW5nLmh0bWw+IGZvciBtb3JlIGluZm8gLS1cbiIpOworICAgIHByaW50IFNUREVSUiAiLS0g UGxlYXNlIHJlbWVtYmVyIHRvIGluY2x1ZGUgYSBkZXRhaWxlZCBkZXNjcmlwdGlvbiBpbiB5b3Vy IENoYW5nZUxvZyBlbnRyeS4gLS1cbi0tIFNlZSA8aHR0cDovL3dlYmtpdC5vcmcvY29kaW5nL2Nv bnRyaWJ1dGluZy5odG1sPiBmb3IgbW9yZSBpbmZvIC0tXG4iOwogCiAgICAgaWYgKCRwcmVmaXgg PX4gbS9XZWJDb3JlLyB8fCBgcHdkYCA9fiBtL1dlYkNvcmUvKSB7CiAgICAgICAgIGlmICgkZGlk Q2hhbmdlUmVncmVzc2lvblRlc3RzKSB7