27146 2009-07-10 01:59:38 -0700 JSDebugger crashes after reloading from a breakpoint 2009-10-19 20:00:05 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 oliver oliver eric timothy oldest_to_newest 130855 0 oliver 2009-07-10 01:59:38 -0700 In certain scenarios it is possible to end up with a dead callframe in the inspector, this leads to a crash in the debugger. 130857 1 32552 oliver 2009-07-10 02:08:03 -0700 Created attachment 32552 harden the debugger 130859 2 32552 oliver 2009-07-10 02:36:26 -0700 Comment on attachment 32552 harden the debugger despite fixing the crash weirdness happens in the debugger afterwards 146895 3 32552 commit-queue 2009-09-11 21:56:41 -0700 Comment on attachment 32552 harden the debugger Rejecting patch 32552 from commit-queue. This patch will require manual commit. Patch https://bugs.webkit.org/attachment.cgi?id=32552 from bug 27146 failed to download and apply. 147074 4 eric 2009-09-14 09:51:44 -0700 patching file WebCore/inspector/InspectorController.cpp Hunk #1 FAILED at 535. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/inspector/InspectorController.cpp.rej 148284 5 eric 2009-09-18 12:01:19 -0700 A quick git log search looks like this hasn't been landed yet. 152352 6 eric 2009-10-05 10:52:49 -0700 Ping? 155941 7 eric 2009-10-19 15:13:27 -0700 This patch has been chillin-like-a-villin in the to-be-committed list for over a month now. Is the patch still wanted? 156041 8 timothy 2009-10-19 20:00:05 -0700 This was actually fixed by: http://trac.webkit.org/changeset/45733 I don't think this full patch is needed, but I landed the parts that are still relevant. Landed the relevant parts in r49832. 32552 2009-07-10 02:08:03 -0700 2009-09-11 21:56:41 -0700 harden the debugger jsdebugger-crash.patch text/plain 3464 oliver ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGM1MmQwYi4uYTE4MDNjNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyOCBAQAorMjAwOS0wNy0xMCAgT2xpdmVyIEh1bnQg IDxvbGl2ZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MDIwNzU1PiBKU0RlYnVnZ2VyIGNyYXNoZXMg YWZ0ZXIgcmVsb2FkaW5nIGZyb20gYSBicmVha3BvaW50CisgICAgICAgIDxodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjcxNDY+CisKKyAgICAgICAgVGhlIGNyYXNoIGlz IGNhdXNlZCBieSBhIHBhZ2UgcmVsb2FkaW5nIHdoaWxlIHRoZSBpbnNwZWN0b3IgaXMgaG9sZGlu ZyBvbnRvCisgICAgICAgIGEgY2FsbGZyYW1lIG9iamVjdCwgdGhpcyBtZWFucyB0aGUgbmV4dCB0 aW1lIHRoZSBpbnNwZWN0b3IgYXR0ZW1wdHMgdG8gZ2V0IAorICAgICAgICB0aGUgZ2xvYmFsIGRh dGEgZnJvbSB0aGUgImN1cnJlbnQiIGNhbGwgZnJhbWUgaXQgZW5jb3VudGVycyBhIG51bGwgc2Nv cGUgY2hhaW4gCisgICAgICAgIGxlYWRpbmcgdG8gYSBjcmFzaC4gIFdoaWxlIHRoZSBpbnNwZWN0 b3Igc2hvdWxkIG5vdCBiZSBob2xkaW5nIG9udG8gdGhpcyBvbGQKKyAgICAgICAgY2FsbGZyYW1l IHdlIGNhbiBlYXNpbHkgaGFyZGVuIGFnYWluc3QgdGhpcyBzY2VuYXJpbyBzaW1wbHkgYnkgaW52 YWxpZGF0aW5nIHRoZQorICAgICAgICBjYWxsZnJhbWUgb2JqZWN0LgorCisgICAgICAgIFVuZm9y dHVuYXRlbHkgdGhlIGNvbWJpbmF0aW9uIG9mIGJvdGggYSBmdWxsIHBhZ2UgcmVsb2FkIGFuZCB0 aGUgamF2YXNjcmlwdAorICAgICAgICBkZWJ1Z2dlciBtYWtlcyB0aGlzIGltcG9zc2libGUgdG8g dGVzdCBhdXRvbWF0aWNhbGx5LiAKKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTSmF2YVNjcmlw dENhbGxGcmFtZUN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0phdmFTY3JpcHRDYWxs RnJhbWU6OnR5cGUpOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6Omluc3BlY3RlZFdpbmRv d1NjcmlwdE9iamVjdENsZWFyZWQpOgorICAgICAgICAqIGluc3BlY3Rvci9KYXZhU2NyaXB0Q2Fs bEZyYW1lLmg6CisgICAgICAgIChXZWJDb3JlOjpKYXZhU2NyaXB0Q2FsbEZyYW1lOjppbnZhbGlk YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkphdmFTY3JpcHRDYWxsRnJhbWU6OnVwZGF0ZSk6CisK IDIwMDktMDctMDkgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNKYXZhU2NyaXB0Q2FsbEZyYW1lQ3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNKYXZhU2NyaXB0Q2FsbEZyYW1lQ3VzdG9tLmNwcAppbmRleCAwOGVjZjJiLi44MzVlMzNk IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTSmF2YVNjcmlwdENhbGxGcmFtZUN1 c3RvbS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0phdmFTY3JpcHRDYWxsRnJhbWVD dXN0b20uY3BwCkBAIC01Myw2ICs1Myw4IEBAIEpTVmFsdWUgSlNKYXZhU2NyaXB0Q2FsbEZyYW1l Ojp0aGlzT2JqZWN0KEV4ZWNTdGF0ZSopIGNvbnN0CiAKIEpTVmFsdWUgSlNKYXZhU2NyaXB0Q2Fs bEZyYW1lOjp0eXBlKEV4ZWNTdGF0ZSogZXhlYykgY29uc3QKIHsKKyAgICBpZiAoIWltcGwoKS0+ aXNWYWxpZCgpKQorICAgICAgICByZXR1cm4ganNTdHJpbmcoZXhlYywgInByb2dyYW0iKTsKICAg ICBzd2l0Y2ggKGltcGwoKS0+dHlwZSgpKSB7CiAgICAgICAgIGNhc2UgRGVidWdnZXJDYWxsRnJh bWU6OkZ1bmN0aW9uVHlwZToKICAgICAgICAgICAgIHJldHVybiBqc1N0cmluZyhleGVjLCAiZnVu Y3Rpb24iKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xs ZXIuY3BwIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKaW5kZXgg N2UwY2YzMS4uMzY2MjQzYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9y Q29udHJvbGxlci5jcHAKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxl ci5jcHAKQEAgLTUzNSw2ICs1MzUsOCBAQCB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6Omluc3Bl Y3RlZFdpbmRvd1NjcmlwdE9iamVjdENsZWFyZWQoRnJhbWUqIGZyYW1lKQogICAgICAgICByZXR1 cm47CiAKICAgICBtX2Zyb250ZW5kLT5pbnNwZWN0ZWRXaW5kb3dTY3JpcHRPYmplY3RDbGVhcmVk KGZyYW1lKTsKKyAgICBpZiAoY3VycmVudENhbGxGcmFtZSgpKQorICAgICAgICBjdXJyZW50Q2Fs bEZyYW1lKCktPmludmFsaWRhdGUoKTsKIH0KIAogdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjp3 aW5kb3dTY3JpcHRPYmplY3RBdmFpbGFibGUoKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0 b3IvSmF2YVNjcmlwdENhbGxGcmFtZS5oIGIvV2ViQ29yZS9pbnNwZWN0b3IvSmF2YVNjcmlwdENh bGxGcmFtZS5oCmluZGV4IDlmMTkzZDguLmFkZmM1MmYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5z cGVjdG9yL0phdmFTY3JpcHRDYWxsRnJhbWUuaAorKysgYi9XZWJDb3JlL2luc3BlY3Rvci9KYXZh U2NyaXB0Q2FsbEZyYW1lLmgKQEAgLTQ0LDcgKzQ0LDEyIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK ICAgICAgICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgSmF2YVNjcmlwdENhbGxGcmFtZShkZWJ1 Z2dlckNhbGxGcmFtZSwgY2FsbGVyLCBzb3VyY2VJRCwgbGluZSkpOwogICAgICAgICB9CiAKLSAg ICAgICAgdm9pZCBpbnZhbGlkYXRlKCkgeyBtX2lzVmFsaWQgPSBmYWxzZTsgfQorICAgICAgICB2 b2lkIGludmFsaWRhdGUoKQorICAgICAgICB7CisgICAgICAgICAgICBtX2lzVmFsaWQgPSBmYWxz ZTsKKyAgICAgICAgICAgIG1fZGVidWdnZXJDYWxsRnJhbWUgPSAwOworICAgICAgICB9CisKICAg ICAgICAgYm9vbCBpc1ZhbGlkKCkgY29uc3QgeyByZXR1cm4gbV9pc1ZhbGlkOyB9CiAKICAgICAg ICAgSmF2YVNjcmlwdENhbGxGcmFtZSogY2FsbGVyKCk7CkBAIC01Niw2ICs2MSw3IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKICAgICAgICAgICAgIG1fZGVidWdnZXJDYWxsRnJhbWUgPSBkZWJ1Z2dl ckNhbGxGcmFtZTsKICAgICAgICAgICAgIG1fbGluZSA9IGxpbmU7CiAgICAgICAgICAgICBtX3Nv dXJjZUlEID0gc291cmNlSUQ7CisgICAgICAgICAgICBtX2lzVmFsaWQgPSB0cnVlOwogICAgICAg ICB9CiAKICAgICAgICAgU3RyaW5nIGZ1bmN0aW9uTmFtZSgpIGNvbnN0Owo=