27141 2009-07-09 20:52:26 -0700 Web Inspector should use Web Inspector preferences to remember attached/detached setting 2009-07-10 10:59:51 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Mac (Intel) OS X 10.5 RESOLVED FIXED P3 Normal --- 1 bweinstein bweinstein oldest_to_newest 130823 0 bweinstein 2009-07-09 20:52:26 -0700 Web Inspector should use Web Inspector preferences to remember attached/detached setting instead of NSUserDefaults it currently uses. 130825 1 32548 bweinstein 2009-07-09 20:59:04 -0700 Created attachment 32548 Use Web Inspector Preferences 130868 2 32548 timothy 2009-07-10 05:17:29 -0700 Comment on attachment 32548 Use Web Inspector Preferences Does this default to being attached the first time? 130887 3 bweinstein 2009-07-10 09:57:42 -0700 Which is the desired behavior? I can do either. Would you prefer it to default to attached or detached? 130891 4 bweinstein 2009-07-10 10:59:17 -0700 Committed in 45712. 32548 2009-07-09 20:59:04 -0700 2009-07-10 10:59:51 -0700 Use Web Inspector Preferences Inspector_attach_mac.patch text/plain 5200 bweinstein SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTY5NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTEgQEAKKzIwMDktMDctMDkgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFVwZGF0ZWQgV2ViQ29yZS5iYXNlLmV4cCB0byBhZGQgc29tZSBuZWVkZWQgZnVuY3Rpb25z LgorCisgICAgICAgICogV2ViQ29yZS5iYXNlLmV4cDoKKwogMjAwOS0wNy0wOSAgRHJldyBXaWxz b24gIDxhdHdpbHNvbkBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQ cm9za3VyeWFrb3YuCkluZGV4OiBXZWJDb3JlL1dlYkNvcmUuYmFzZS5leHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9XZWJDb3JlLmJhc2UuZXhwCShyZXZpc2lvbiA0NTY2OSkKKysrIFdlYkNvcmUv V2ViQ29yZS5iYXNlLmV4cAkod29ya2luZyBjb3B5KQpAQCAtMzk5LDYgKzM5OSw3IEBAIF9fWk43 V2ViQ29yZTE4aXNTdGFydE9mUGFyYWdyYXBoRVJLTlNfMTUKIF9fWk43V2ViQ29yZTE5QW5pbWF0 aW9uQ29udHJvbGxlcjIwcGF1c2VBbmltYXRpb25BdFRpbWVFUE5TXzEyUmVuZGVyT2JqZWN0RVJL TlNfNlN0cmluZ0VkCiBfX1pON1dlYkNvcmUxOUFuaW1hdGlvbkNvbnRyb2xsZXIyMXBhdXNlVHJh bnNpdGlvbkF0VGltZUVQTlNfMTJSZW5kZXJPYmplY3RFUktOU182U3RyaW5nRWQKIF9fWk43V2Vi Q29yZTE5Q1NTU3R5bGVEZWNsYXJhdGlvbjExc2V0UHJvcGVydHlFUktOU182U3RyaW5nRVMzX1Jp CitfX1pON1dlYkNvcmUxOUluc3BlY3RvckNvbnRyb2xsZXIxMHNldFNldHRpbmdFUktOU182U3Ry aW5nRVJLTlMwXzdTZXR0aW5nRQogX19aTjdXZWJDb3JlMTlJbnNwZWN0b3JDb250cm9sbGVyMTJh dHRhY2hXaW5kb3dFdgogX19aTjdXZWJDb3JlMTlJbnNwZWN0b3JDb250cm9sbGVyMTJkZXRhY2hX aW5kb3dFdgogX19aTjdXZWJDb3JlMTlJbnNwZWN0b3JDb250cm9sbGVyMTRlbmFibGVEZWJ1Z2dl ckV2CkBAIC04NDYsNiArODQ3LDcgQEAgX19aTks3V2ViQ29yZTE3UmVzb3VyY2VFcnJvckJhc2U4 bGF6eUluaQogX19aTks3V2ViQ29yZTE5QW5pbWF0aW9uQ29udHJvbGxlcjI0bnVtYmVyT2ZBY3Rp dmVBbmltYXRpb25zRXYKIF9fWk5LN1dlYkNvcmUxOUluc3BlY3RvckNvbnRyb2xsZXIxN2RyYXdO b2RlSGlnaGxpZ2h0RVJOU18xNUdyYXBoaWNzQ29udGV4dEUKIF9fWk5LN1dlYkNvcmUxOUluc3Bl Y3RvckNvbnRyb2xsZXI3ZW5hYmxlZEV2CitfX1pOSzdXZWJDb3JlMTlJbnNwZWN0b3JDb250cm9s bGVyN3NldHRpbmdFUktOU182U3RyaW5nRQogX19aTks3V2ViQ29yZTE5UmVzb3VyY2VSZXF1ZXN0 QmFzZTEwaHR0cE1ldGhvZEV2CiBfX1pOSzdXZWJDb3JlMTlSZXNvdXJjZVJlcXVlc3RCYXNlM3Vy bEV2CiBfX1pOSzdXZWJDb3JlMTlSZXNvdXJjZVJlcXVlc3RCYXNlN2lzRW1wdHlFdgpJbmRleDog V2ViS2l0L21hYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L21hYy9DaGFuZ2VMb2cJ KHJldmlzaW9uIDQ1Njk1KQorKysgV2ViS2l0L21hYy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxOCBAQAorMjAwOS0wNy0wOSAgQnJpYW4gV2VpbnN0ZWluICA8YndlaW5zdGVp bkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3MTQxCisgICAg ICAgIAorICAgICAgICBVcGRhdGVkIFdlYkluc3BlY3RvckNsaWVudCB0byB1c2UgV2ViIEluc3Bl Y3RvciBQcmVmZXJlbmNlcyB0byByZW1lbWJlciB3aGV0aGVyIG9yIG5vdCBpdCBzaG91bGQgYmUg CisgICAgICAgIGRvY2tlZCBvciBhIGZyZWUgd2luZG93IGluc3RlYWQgb2YgTlNVc2VyRGVmYXVs dHMgaXQgdXNlZCB0byBoYXZlLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVj dG9yQ2xpZW50Lm1tOgorICAgICAgICAoLVtXZWJJbnNwZWN0b3JXaW5kb3dDb250cm9sbGVyIGlu aXRdKToKKyAgICAgICAgKC1bV2ViSW5zcGVjdG9yV2luZG93Q29udHJvbGxlciBzaG93V2luZG93 Ol0pOgorICAgICAgICAoLVtXZWJJbnNwZWN0b3JXaW5kb3dDb250cm9sbGVyIGF0dGFjaF0pOgor ICAgICAgICAoLVtXZWJJbnNwZWN0b3JXaW5kb3dDb250cm9sbGVyIGRldGFjaF0pOgorCiAyMDA5 LTA3LTA5ICBEcmV3IFdpbHNvbiAgPGF0d2lsc29uQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KSW5kZXg6IFdlYktpdC9tYWMvV2ViQ29yZVN1 cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvV2Vi Q29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1tCShyZXZpc2lvbiA0NTY2OSkKKysrIFdl YktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50Lm1tCSh3b3JraW5nIGNv cHkpCkBAIC00Myw2ICs0Myw4IEBACiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCitzdGF0 aWMgY29uc3QgY2hhciogY29uc3QgaW5zcGVjdG9yU3RhcnRzQXR0YWNoZWROYW1lID0gImluc3Bl Y3RvclN0YXJ0c0F0dGFjaGVkIjsKKwogQGludGVyZmFjZSBXZWJJbnNwZWN0b3JXaW5kb3dDb250 cm9sbGVyIDogTlNXaW5kb3dDb250cm9sbGVyIDxOU1dpbmRvd0RlbGVnYXRlPiB7CiBAcHJpdmF0 ZQogICAgIFdlYlZpZXcgKl9pbnNwZWN0ZWRXZWJWaWV3OwpAQCAtMTkxLDEwICsxOTMsNiBAQCB2 b2lkIFdlYkluc3BlY3RvckNsaWVudDo6dXBkYXRlV2luZG93VGl0CiAKICAgICBbcHJlZmVyZW5j ZXMgcmVsZWFzZV07CiAKLSAgICBOU051bWJlciAqYXR0YWNoZWQgPSBbW05TVXNlckRlZmF1bHRz IHN0YW5kYXJkVXNlckRlZmF1bHRzXSBvYmplY3RGb3JLZXk6V2ViS2l0SW5zcGVjdG9yQXR0YWNo ZWRLZXldOwotICAgIEFTU0VSVCghYXR0YWNoZWQgfHwgW2F0dGFjaGVkIGlzS2luZE9mQ2xhc3M6 W05TTnVtYmVyIGNsYXNzXV0pOwotICAgIF9zaG91bGRBdHRhY2ggPSBhdHRhY2hlZCA/IFthdHRh Y2hlZCBib29sVmFsdWVdIDogWUVTOwotCiAgICAgTlNTdHJpbmcgKnBhdGggPSBbW05TQnVuZGxl IGJ1bmRsZVdpdGhJZGVudGlmaWVyOkAiY29tLmFwcGxlLldlYkNvcmUiXSBwYXRoRm9yUmVzb3Vy Y2U6QCJpbnNwZWN0b3IiIG9mVHlwZTpAImh0bWwiIGluRGlyZWN0b3J5OkAiaW5zcGVjdG9yIl07 CiAgICAgTlNVUkxSZXF1ZXN0ICpyZXF1ZXN0ID0gW1tOU1VSTFJlcXVlc3QgYWxsb2NdIGluaXRX aXRoVVJMOltOU1VSTCBmaWxlVVJMV2l0aFBhdGg6cGF0aF1dOwogICAgIFtbX3dlYlZpZXcgbWFp bkZyYW1lXSBsb2FkUmVxdWVzdDpyZXF1ZXN0XTsKQEAgLTMxOCw2ICszMTYsOSBAQCB2b2lkIFdl Ykluc3BlY3RvckNsaWVudDo6dXBkYXRlV2luZG93VGl0CiAgICAgfQogCiAgICAgX3Zpc2libGUg PSBZRVM7CisgICAgCisgICAgSW5zcGVjdG9yQ29udHJvbGxlcjo6U2V0dGluZyBzaG91bGRBdHRh Y2ggPSBbX2luc3BlY3RlZFdlYlZpZXcgcGFnZV0tPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+c2V0 dGluZyhpbnNwZWN0b3JTdGFydHNBdHRhY2hlZE5hbWUpOworICAgIF9zaG91bGRBdHRhY2ggPSAo c2hvdWxkQXR0YWNoLnR5cGUoKSA9PSBJbnNwZWN0b3JDb250cm9sbGVyOjpTZXR0aW5nOjpCb29s ZWFuVHlwZSkgPyBzaG91bGRBdHRhY2guYm9vbGVhblZhbHVlKCkgOiB0cnVlOwogCiAgICAgaWYg KF9zaG91bGRBdHRhY2gpIHsKICAgICAgICAgV2ViRnJhbWVWaWV3ICpmcmFtZVZpZXcgPSBbW19p bnNwZWN0ZWRXZWJWaWV3IG1haW5GcmFtZV0gZnJhbWVWaWV3XTsKQEAgLTM1MywxNSArMzU0LDEz IEBAIHZvaWQgV2ViSW5zcGVjdG9yQ2xpZW50Ojp1cGRhdGVXaW5kb3dUaXQKICAgICBpZiAoX2F0 dGFjaGVkVG9JbnNwZWN0ZWRXZWJWaWV3KQogICAgICAgICByZXR1cm47CiAKLSAgICBfc2hvdWxk QXR0YWNoID0gWUVTOworICAgIFtfaW5zcGVjdGVkV2ViVmlldyBwYWdlXS0+aW5zcGVjdG9yQ29u dHJvbGxlcigpLT5zZXRTZXR0aW5nKGluc3BlY3RvclN0YXJ0c0F0dGFjaGVkTmFtZSwgSW5zcGVj dG9yQ29udHJvbGxlcjo6U2V0dGluZyh0cnVlKSk7CiAgICAgX21vdmluZ1dpbmRvd3MgPSBZRVM7 CiAKICAgICBbc2VsZiBjbG9zZV07CiAgICAgW3NlbGYgc2hvd1dpbmRvdzpuaWxdOwogCiAgICAg X21vdmluZ1dpbmRvd3MgPSBOTzsKLQotICAgIFtbTlNVc2VyRGVmYXVsdHMgc3RhbmRhcmRVc2Vy RGVmYXVsdHNdIHNldEJvb2w6WUVTIGZvcktleTpXZWJLaXRJbnNwZWN0b3JBdHRhY2hlZEtleV07 CiB9CiAKIC0gKHZvaWQpZGV0YWNoCkBAIC0zNjksNyArMzY4LDcgQEAgdm9pZCBXZWJJbnNwZWN0 b3JDbGllbnQ6OnVwZGF0ZVdpbmRvd1RpdAogICAgIGlmICghX2F0dGFjaGVkVG9JbnNwZWN0ZWRX ZWJWaWV3KQogICAgICAgICByZXR1cm47CiAKLSAgICBfc2hvdWxkQXR0YWNoID0gTk87CisgICAg W19pbnNwZWN0ZWRXZWJWaWV3IHBhZ2VdLT5pbnNwZWN0b3JDb250cm9sbGVyKCktPnNldFNldHRp bmcoaW5zcGVjdG9yU3RhcnRzQXR0YWNoZWROYW1lLCBJbnNwZWN0b3JDb250cm9sbGVyOjpTZXR0 aW5nKGZhbHNlKSk7CiAgICAgX21vdmluZ1dpbmRvd3MgPSBZRVM7CiAKICAgICBbc2VsZiBjbG9z ZV07CkBAIC0zNzcsNyArMzc2LDYgQEAgdm9pZCBXZWJJbnNwZWN0b3JDbGllbnQ6OnVwZGF0ZVdp bmRvd1RpdAogCiAgICAgX21vdmluZ1dpbmRvd3MgPSBOTzsKIAotICAgIFtbTlNVc2VyRGVmYXVs dHMgc3RhbmRhcmRVc2VyRGVmYXVsdHNdIHNldEJvb2w6Tk8gZm9yS2V5OldlYktpdEluc3BlY3Rv ckF0dGFjaGVkS2V5XTsKIH0KIAogLSAodm9pZClzZXRBdHRhY2hlZFdpbmRvd0hlaWdodDoodW5z aWduZWQpaGVpZ2h0Cg==