271406 2024-03-21 13:02:24 -0700 AX: Crash with VoiceOver when focusing a PDF annotation. 2024-03-22 09:05:12 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 andresg_22 cfleizach tyler_w webkit-bug-importer oldest_to_newest 2022856 0 andresg_22 2024-03-21 13:02:24 -0700 Thread 1 Crashed:: com.apple.accessibility.secondary 0 WebCore 0x1a8ac37e8 WTFCrashWithInfo(int, char const*, char const*, int) + 20 1 WebCore 0x1aa8c8f20 WebCore::TimerBase::setNextFireTime(WTF::MonotonicTime) + 2572 2 WebCore 0x1aa089130 WebCore::Element::insertedIntoAncestor(WebCore::Node::InsertionType, WebCore::ContainerNode&) + 1256 3 WebCore 0x1aa2fe114 WebCore::HTMLFormControlElement::insertedIntoAncestor(WebCore::Node::InsertionType, WebCore::ContainerNode&) + 44 4 WebCore 0x1aa0044d4 WebCore::notifyNodeInsertedIntoDocument(WebCore::ContainerNode&, WebCore::Node&, WebCore::TreeScopeChange, WTF::Vector<WTF::Ref<WebCore::Node, WTF::RawPtrTraits<WebCore::Node>>, 11ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&) + 108 5 WebCore 0x1a9ffd8d8 WebCore::ContainerNode::appendChildWithoutPreInsertionValidityCheck(WebCore::Node&) + 1232 6 WebKit 0x1ac210f80 WebKit::PDFPluginAnnotation::attach(WebCore::Element*) + 868 7 WebKit 0x1ac20cdb4 WebKit::PDFPlugin::setActiveAnnotation(PDFAnnotation*) + 404 2022857 1 webkit-bug-importer 2024-03-21 13:02:48 -0700 <rdar://problem/125187438> 2022858 2 andresg_22 2024-03-21 13:08:18 -0700 rdar://124631171 2022859 3 470469 andresg_22 2024-03-21 13:09:44 -0700 Created attachment 470469 Patch 2022911 4 470469 tyler_w 2024-03-21 15:42:15 -0700 Comment on attachment 470469 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=470469&action=review > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1197 > + callOnMainRunLoop([annotation = WTFMove(annotation), this] { This should probably be callOnMainRunLoopAndWait, as callOnMainRunLoop is a change in behavior for non-AT users. https://github.com/WebKit/WebKit/commit/83013c6d19ebb5430aa94c4a813ceeebc71951e2 (written by me) caused a regression by doing this same thing (using callOnMainRunLoop instead of callOnMainRunLoopAndWait) where PDFs loaded half-way scrolled down the first page. 2022941 5 470471 andresg_22 2024-03-21 16:54:33 -0700 Created attachment 470471 Patch 2022942 6 andresg_22 2024-03-21 16:59:23 -0700 (In reply to Tyler Wilcock from comment #4) > Comment on attachment 470469 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=470469&action=review > > > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1197 > > + callOnMainRunLoop([annotation = WTFMove(annotation), this] { > > This should probably be callOnMainRunLoopAndWait, as callOnMainRunLoop is a > change in behavior for non-AT users. > https://github.com/WebKit/WebKit/commit/ > 83013c6d19ebb5430aa94c4a813ceeebc71951e2 (written by me) caused a regression > by doing this same thing (using callOnMainRunLoop instead of > callOnMainRunLoopAndWait) where PDFs loaded half-way scrolled down the first > page. I saw that and was pondering the possible impact, but not clear to me if it would have a side effect in setting focus as it did in scrolling. So taking the safer path and taking your suggestion. Thanks. 2022959 7 tyler_w 2024-03-21 17:31:54 -0700 (In reply to Andres Gonzalez from comment #6) > (In reply to Tyler Wilcock from comment #4) > > Comment on attachment 470469 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=470469&action=review > > > > > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1197 > > > + callOnMainRunLoop([annotation = WTFMove(annotation), this] { > > > > This should probably be callOnMainRunLoopAndWait, as callOnMainRunLoop is a > > change in behavior for non-AT users. > > https://github.com/WebKit/WebKit/commit/ > > 83013c6d19ebb5430aa94c4a813ceeebc71951e2 (written by me) caused a regression > > by doing this same thing (using callOnMainRunLoop instead of > > callOnMainRunLoopAndWait) where PDFs loaded half-way scrolled down the first > > page. > > I saw that and was pondering the possible impact, but not clear to me if it > would have a side effect in setting focus as it did in scrolling. So taking > the safer path and taking your suggestion. Thanks. TW: Yeah, certainly possible it would be OK here, but I thought the same thing with my last change :) Maybe in a future patch, we could consider using callOnMainRunLoop if ITM is enabled, or maybe if this request is specifically from an ITM-enabled AT, and use callOnMainRunLoopAndWait otherwise? We can brainstorm some more and maybe a better idea will come. 2023131 8 ews-feeder 2024-03-22 09:05:11 -0700 Committed 276548@main (648225124a2c): <https://commits.webkit.org/276548@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 470471. 470469 2024-03-21 13:09:44 -0700 2024-03-22 07:24:09 -0700 Patch bug-271406-20240321160943.patch text/plain 2845 andresg_22 RnJvbSAxNmUwMmIxZTA3Nzk4NjU5NjMwMTFjNTZmODdmYTM3MDIwNDc2YjU0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXMgR29uemFsZXogPGFuZHJlc2dfMjJAYXBwbGUuY29t PgpEYXRlOiBUaHUsIDIxIE1hciAyMDI0IDE1OjUyOjIxIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0g QVg6IENyYXNoIHdpdGggVm9pY2VPdmVyIHdoZW4gZm9jdXNpbmcgYSBQREYgYW5ub3RhdGlvbi4K IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzE0MDYgcmRhcjovLzEy NDYzMTE3MQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpQREZQbHVnaW46OnNldEFjdGl2 ZUFubm90YXRpb24gYWNjZXNzZXMgbWFpbiB0aHJlYWQtb25seSBvYmplY3RzIGFuZCB0aHVzIG5l ZWRzIHRvIGJlIGRpc3BhdGNoZWQgdG8gdGhlIG1haW4gcnVubG9vcC4KCiogU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbToKKFdlYktpdDo6UERGUGx1Z2lu OjpzZXRBY3RpdmVBbm5vdGF0aW9uKToKLS0tCiAuLi4vV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9Q REZQbHVnaW4ubW0gICAgICAgfCAzNSArKysrKysrKysrLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdl ZCwgMTkgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbSBiL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW0KaW5kZXggNDliMTk1MTZiMDc0 Li42MDgxYjkxOTkxNzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVn aW5zL1BERi9QREZQbHVnaW4ubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1BsdWdp bnMvUERGL1BERlBsdWdpbi5tbQpAQCAtMTE5MywyNSArMTE5MywyOCBAQCB2b2lkIFBERlBsdWdp bjo6aW52YWxpZGF0ZVNjcm9sbENvcm5lclJlY3QoY29uc3QgSW50UmVjdCYgcmVjdCkKIAogdm9p ZCBQREZQbHVnaW46OnNldEFjdGl2ZUFubm90YXRpb24oUmV0YWluUHRyPFBERkFubm90YXRpb24+ JiYgYW5ub3RhdGlvbikKIHsKLSAgICBpZiAoIXN1cHBvcnRzRm9ybXMoKSkKLSAgICAgICAgcmV0 dXJuOworICAgIC8vIFRoaXMgbWF5IGJlIGNhbGxlZCBvZmYgdGhlIG1haW4gdGhyZWFkIGlmIFZv aWNlT3ZlciBpcyBydW5uaW5nLCB0aHVzIGRpc3BhdGNoIHRvIHRoZSBtYWluIHJ1bmxvb3Agc2lu Y2UgaXQgaW52b2x2ZXMgbWFpbiB0aHJlYWQgb25seSBvYmplY3RzLgorICAgIGNhbGxPbk1haW5S dW5Mb29wKFthbm5vdGF0aW9uID0gV1RGTW92ZShhbm5vdGF0aW9uKSwgdGhpc10geworICAgICAg ICBpZiAoIXN1cHBvcnRzRm9ybXMoKSkKKyAgICAgICAgICAgIHJldHVybjsKIAotICAgIGlmICht X2FjdGl2ZUFubm90YXRpb24pCi0gICAgICAgIG1fYWN0aXZlQW5ub3RhdGlvbi0+Y29tbWl0KCk7 CisgICAgICAgIGlmIChtX2FjdGl2ZUFubm90YXRpb24pCisgICAgICAgICAgICBtX2FjdGl2ZUFu bm90YXRpb24tPmNvbW1pdCgpOwogCi0gICAgaWYgKGFubm90YXRpb24pIHsKLUFMTE9XX0RFUFJF Q0FURURfREVDTEFSQVRJT05TX0JFR0lOCi0gICAgICAgIGlmIChbYW5ub3RhdGlvbiBpc0tpbmRP ZkNsYXNzOmdldFBERkFubm90YXRpb25UZXh0V2lkZ2V0Q2xhc3MoKV0gJiYgc3RhdGljX2Nhc3Q8 UERGQW5ub3RhdGlvblRleHRXaWRnZXQgKj4oYW5ub3RhdGlvbikuaXNSZWFkT25seSkgewotICAg ICAgICAgICAgbV9hY3RpdmVBbm5vdGF0aW9uID0gbnVsbHB0cjsKLSAgICAgICAgICAgIHJldHVy bjsKLSAgICAgICAgfQotQUxMT1dfREVQUkVDQVRFRF9ERUNMQVJBVElPTlNfRU5ECisgICAgICAg IGlmIChhbm5vdGF0aW9uKSB7CisgICAgICAgICAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFU SU9OU19CRUdJTgorICAgICAgICAgICAgaWYgKFthbm5vdGF0aW9uIGlzS2luZE9mQ2xhc3M6Z2V0 UERGQW5ub3RhdGlvblRleHRXaWRnZXRDbGFzcygpXSAmJiBzdGF0aWNfY2FzdDxQREZBbm5vdGF0 aW9uVGV4dFdpZGdldCAqPihhbm5vdGF0aW9uKS5pc1JlYWRPbmx5KSB7CisgICAgICAgICAgICAg ICAgbV9hY3RpdmVBbm5vdGF0aW9uID0gbnVsbHB0cjsKKyAgICAgICAgICAgICAgICByZXR1cm47 CisgICAgICAgICAgICB9CisgICAgICAgICAgICBBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9O U19FTkQKIAotICAgICAgICBhdXRvIGFjdGl2ZUFubm90YXRpb24gPSBQREZQbHVnaW5Bbm5vdGF0 aW9uOjpjcmVhdGUoYW5ub3RhdGlvbi5nZXQoKSwgdGhpcyk7Ci0gICAgICAgIG1fYWN0aXZlQW5u b3RhdGlvbiA9IGFjdGl2ZUFubm90YXRpb24uZ2V0KCk7Ci0gICAgICAgIGFjdGl2ZUFubm90YXRp b24tPmF0dGFjaChtX2Fubm90YXRpb25Db250YWluZXIuZ2V0KCkpOwotICAgIH0gZWxzZQotICAg ICAgICBtX2FjdGl2ZUFubm90YXRpb24gPSBudWxscHRyOworICAgICAgICAgICAgYXV0byBhY3Rp dmVBbm5vdGF0aW9uID0gUERGUGx1Z2luQW5ub3RhdGlvbjo6Y3JlYXRlKGFubm90YXRpb24uZ2V0 KCksIHRoaXMpOworICAgICAgICAgICAgbV9hY3RpdmVBbm5vdGF0aW9uID0gYWN0aXZlQW5ub3Rh dGlvbi5nZXQoKTsKKyAgICAgICAgICAgIGFjdGl2ZUFubm90YXRpb24tPmF0dGFjaChtX2Fubm90 YXRpb25Db250YWluZXIuZ2V0KCkpOworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIG1fYWN0 aXZlQW5ub3RhdGlvbiA9IG51bGxwdHI7CisgICAgfSk7CiB9CiAKIHZvaWQgUERGUGx1Z2luOjpu b3RpZnlDb250ZW50U2NhbGVGYWN0b3JDaGFuZ2VkKENHRmxvYXQgc2NhbGVGYWN0b3IpCg== 470471 2024-03-21 16:54:33 -0700 2024-03-22 09:05:11 -0700 Patch bug-271406-20240321195432.patch text/plain 2852 andresg_22 RnJvbSA3YjgzY2IyMDEwYTEyYWUxNDBmODI2NDlmOTAyMGZmYWY1YWY1ZjIyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXMgR29uemFsZXogPGFuZHJlc2dfMjJAYXBwbGUuY29t PgpEYXRlOiBUaHUsIDIxIE1hciAyMDI0IDE1OjUyOjIxIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0g QVg6IENyYXNoIHdpdGggVm9pY2VPdmVyIHdoZW4gZm9jdXNpbmcgYSBQREYgYW5ub3RhdGlvbi4K IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzE0MDYgcmRhcjovLzEy NDYzMTE3MQoKUmV2aWV3ZWQgYnkgQ2hyaXMgRmxlaXphY2guCgpQREZQbHVnaW46OnNldEFjdGl2 ZUFubm90YXRpb24gYWNjZXNzZXMgbWFpbiB0aHJlYWQtb25seSBvYmplY3RzIGFuZCB0aHVzIG5l ZWRzIHRvIGJlIGRpc3BhdGNoZWQgdG8gdGhlIG1haW4gcnVubG9vcC4KCiogU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbToKKFdlYktpdDo6UERGUGx1Z2lu OjpzZXRBY3RpdmVBbm5vdGF0aW9uKToKLS0tCiAuLi4vV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9Q REZQbHVnaW4ubW0gICAgICAgfCAzNSArKysrKysrKysrLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdl ZCwgMTkgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbSBiL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW0KaW5kZXggNDliMTk1MTZiMDc0 Li5jOGMyMDg2NmFiNzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVn aW5zL1BERi9QREZQbHVnaW4ubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1BsdWdp bnMvUERGL1BERlBsdWdpbi5tbQpAQCAtMTE5MywyNSArMTE5MywyOCBAQCB2b2lkIFBERlBsdWdp bjo6aW52YWxpZGF0ZVNjcm9sbENvcm5lclJlY3QoY29uc3QgSW50UmVjdCYgcmVjdCkKIAogdm9p ZCBQREZQbHVnaW46OnNldEFjdGl2ZUFubm90YXRpb24oUmV0YWluUHRyPFBERkFubm90YXRpb24+ JiYgYW5ub3RhdGlvbikKIHsKLSAgICBpZiAoIXN1cHBvcnRzRm9ybXMoKSkKLSAgICAgICAgcmV0 dXJuOworICAgIC8vIFRoaXMgbWF5IGJlIGNhbGxlZCBvZmYgdGhlIG1haW4gdGhyZWFkIGlmIFZv aWNlT3ZlciBpcyBydW5uaW5nLCB0aHVzIGRpc3BhdGNoIHRvIHRoZSBtYWluIHJ1bmxvb3Agc2lu Y2UgaXQgaW52b2x2ZXMgbWFpbiB0aHJlYWQgb25seSBvYmplY3RzLgorICAgIGNhbGxPbk1haW5S dW5Mb29wQW5kV2FpdChbYW5ub3RhdGlvbiA9IFdURk1vdmUoYW5ub3RhdGlvbiksIHRoaXNdIHsK KyAgICAgICAgaWYgKCFzdXBwb3J0c0Zvcm1zKCkpCisgICAgICAgICAgICByZXR1cm47CiAKLSAg ICBpZiAobV9hY3RpdmVBbm5vdGF0aW9uKQotICAgICAgICBtX2FjdGl2ZUFubm90YXRpb24tPmNv bW1pdCgpOworICAgICAgICBpZiAobV9hY3RpdmVBbm5vdGF0aW9uKQorICAgICAgICAgICAgbV9h Y3RpdmVBbm5vdGF0aW9uLT5jb21taXQoKTsKIAotICAgIGlmIChhbm5vdGF0aW9uKSB7Ci1BTExP V19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19CRUdJTgotICAgICAgICBpZiAoW2Fubm90YXRpb24g aXNLaW5kT2ZDbGFzczpnZXRQREZBbm5vdGF0aW9uVGV4dFdpZGdldENsYXNzKCldICYmIHN0YXRp Y19jYXN0PFBERkFubm90YXRpb25UZXh0V2lkZ2V0ICo+KGFubm90YXRpb24pLmlzUmVhZE9ubHkp IHsKLSAgICAgICAgICAgIG1fYWN0aXZlQW5ub3RhdGlvbiA9IG51bGxwdHI7Ci0gICAgICAgICAg ICByZXR1cm47Ci0gICAgICAgIH0KLUFMTE9XX0RFUFJFQ0FURURfREVDTEFSQVRJT05TX0VORAor ICAgICAgICBpZiAoYW5ub3RhdGlvbikgeworICAgICAgICAgICAgQUxMT1dfREVQUkVDQVRFRF9E RUNMQVJBVElPTlNfQkVHSU4KKyAgICAgICAgICAgIGlmIChbYW5ub3RhdGlvbiBpc0tpbmRPZkNs YXNzOmdldFBERkFubm90YXRpb25UZXh0V2lkZ2V0Q2xhc3MoKV0gJiYgc3RhdGljX2Nhc3Q8UERG QW5ub3RhdGlvblRleHRXaWRnZXQgKj4oYW5ub3RhdGlvbikuaXNSZWFkT25seSkgeworICAgICAg ICAgICAgICAgIG1fYWN0aXZlQW5ub3RhdGlvbiA9IG51bGxwdHI7CisgICAgICAgICAgICAgICAg cmV0dXJuOworICAgICAgICAgICAgfQorICAgICAgICAgICAgQUxMT1dfREVQUkVDQVRFRF9ERUNM QVJBVElPTlNfRU5ECiAKLSAgICAgICAgYXV0byBhY3RpdmVBbm5vdGF0aW9uID0gUERGUGx1Z2lu QW5ub3RhdGlvbjo6Y3JlYXRlKGFubm90YXRpb24uZ2V0KCksIHRoaXMpOwotICAgICAgICBtX2Fj dGl2ZUFubm90YXRpb24gPSBhY3RpdmVBbm5vdGF0aW9uLmdldCgpOwotICAgICAgICBhY3RpdmVB bm5vdGF0aW9uLT5hdHRhY2gobV9hbm5vdGF0aW9uQ29udGFpbmVyLmdldCgpKTsKLSAgICB9IGVs c2UKLSAgICAgICAgbV9hY3RpdmVBbm5vdGF0aW9uID0gbnVsbHB0cjsKKyAgICAgICAgICAgIGF1 dG8gYWN0aXZlQW5ub3RhdGlvbiA9IFBERlBsdWdpbkFubm90YXRpb246OmNyZWF0ZShhbm5vdGF0 aW9uLmdldCgpLCB0aGlzKTsKKyAgICAgICAgICAgIG1fYWN0aXZlQW5ub3RhdGlvbiA9IGFjdGl2 ZUFubm90YXRpb24uZ2V0KCk7CisgICAgICAgICAgICBhY3RpdmVBbm5vdGF0aW9uLT5hdHRhY2go bV9hbm5vdGF0aW9uQ29udGFpbmVyLmdldCgpKTsKKyAgICAgICAgfSBlbHNlCisgICAgICAgICAg ICBtX2FjdGl2ZUFubm90YXRpb24gPSBudWxscHRyOworICAgIH0pOwogfQogCiB2b2lkIFBERlBs dWdpbjo6bm90aWZ5Q29udGVudFNjYWxlRmFjdG9yQ2hhbmdlZChDR0Zsb2F0IHNjYWxlRmFjdG9y KQo=