27140 2009-07-09 18:05:52 -0700 Add a preference key to make Web Inspector detach/attach by default 2009-07-10 08:51:20 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC Windows 7 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 bweinstein bweinstein aroben oldest_to_newest 130792 0 bweinstein 2009-07-09 18:05:52 -0700 There should be a preferences key or some other way to have the inspector dock to the webview when shown by default instead of having to open it then manually dock it (Windows version). <rdar://5712929> 130793 1 32545 bweinstein 2009-07-09 18:06:36 -0700 Created attachment 32545 Windows Patch 130798 2 32545 alice.barraclough 2009-07-09 18:33:21 -0700 Comment on attachment 32545 Windows Patch > @@ -322,6 +324,9 @@ void WebInspectorClient::showWindowWitho > ASSERT(m_webView); > ASSERT(m_inspectedWebViewHwnd); > > + InspectorController::Setting shouldAttach = m_inspectedWebView->page()->inspectorController()->setting(inspectorStartsAttachedName); > + m_shouldAttachWhenShown = (shouldAttach.type() == InspectorController::Setting::BooleanType) ? shouldAttach.booleanValue() : false; > + > if (!m_shouldAttachWhenShown) { > // Put the Inspector's WebView inside our window and show it. > m_webView->setHostWindow(reinterpret_cast<OLE_HANDLE>(m_hwnd)); bdash wants you to remove the extraneous parents around the condition before the question mark r=me 130801 3 bweinstein 2009-07-09 18:50:56 -0700 Committed in revision 45689. 130880 4 32545 aroben 2009-07-10 08:05:33 -0700 Comment on attachment 32545 Windows Patch I think it's a shame that all this work was done up at the WebKit level. (Almost?) All of this code should be cross-platform, instead of duplicated between Mac (in bug 27141) and Windows. I'd really like to see this moved down into WebCore. 130884 5 aroben 2009-07-10 08:51:20 -0700 (In reply to comment #4) > (From update of attachment 32545 [details]) > I think it's a shame that all this work was done up at the WebKit level. > (Almost?) All of this code should be cross-platform, instead of duplicated > between Mac (in bug 27141) and Windows. I'd really like to see this moved down > into WebCore. It is great to have the bug fixed, though! 32545 2009-07-09 18:06:36 -0700 2009-07-10 08:05:33 -0700 Windows Patch Inspector_attach.patch text/plain 4073 bweinstein SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA0NTY4NCkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMDctMDkgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3 ZWluc3RlaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEZpeCBvZiA8cmRhcjovLzU3MTI5Mjk+IEFkZCBwcmVmZXJlbmNlcyBrZXkg dG8gcmVtZW1iZXIgaWYgdGhlIEluc3BlY3RvciB3YXMgZG9ja2VkICgxNDI3MSkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MjcxCisKKyAgICAgICAg QWRkZWQgYSBwcmVmZXJlbmNlIGtleSB0byByZW1lbWJlciB3aGV0aGVyIHRoZSB1c2VyIHByZWZl cnMgdGhlIGluc3BlY3RvciBkZXRhY2hlZCBvciBhdHRhY2hlZC4KKworICAgICAgICAqIFdlYkNv cmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5jcHA6CisgICAgICAgIChXZWJJbnNwZWN0b3JD bGllbnQ6OnNob3dXaW5kb3cpOiBQYXNzIGJvdGggcGFyYW1ldGVycyBpbnRvIHNldFdpbmRvd1Zp c2libGUKKyAgICAgICAgKFdlYkluc3BlY3RvckNsaWVudDo6Y2xvc2VXaW5kb3cpOiBEaXR0bwor ICAgICAgICAoV2ViSW5zcGVjdG9yQ2xpZW50OjphdHRhY2hXaW5kb3cpOiBTZXQgcHJlZmVyZW5j ZSB0byBhdHRhY2hlZCB3aW5kb3dzIGhlcmUKKyAgICAgICAgKFdlYkluc3BlY3RvckNsaWVudDo6 ZGV0YWNoV2luZG93KTogU2V0IHByZWZlcmVuY2UgdG8gZGV0YWNoZWQgd2luZG93cyBoZXJlCisg ICAgICAgIChXZWJJbnNwZWN0b3JDbGllbnQ6OnNob3dXaW5kb3dXaXRob3V0Tm90aWZpY2F0aW9u cyk6IFJlYWQgcHJlZmVyZW5jZSBmb3IgYXR0YWNoZWQgdnMuIGRldGFjaGVkCisgICAgICAgIChX ZWJJbnNwZWN0b3JDbGllbnQ6Om9uQ2xvc2UpOiBQYXNzIGJvdGggcGFyYW1ldGVycyBpbnRvIHNl dFdpbmRvd1Zpc2libGUKKwogMjAwOS0wNy0wOSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBXZWJL aXQvd2luL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVudC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQuY3BwCShyZXZp c2lvbiA0NTUyNikKKysrIFdlYktpdC93aW4vV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xp ZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTEsNiArNTEsOCBAQAogCiB1c2luZyBuYW1lc3Bh Y2UgV2ViQ29yZTsKIAorc3RhdGljIGNvbnN0IGNoYXIqIGNvbnN0IGluc3BlY3RvclN0YXJ0c0F0 dGFjaGVkTmFtZSA9ICJpbnNwZWN0b3JTdGFydHNBdHRhY2hlZCI7CisKIHN0YXRpYyBMUENUU1RS IGtXZWJJbnNwZWN0b3JXaW5kb3dDbGFzc05hbWUgPSBURVhUKCJXZWJJbnNwZWN0b3JXaW5kb3dD bGFzcyIpOwogc3RhdGljIEFUT00gcmVnaXN0ZXJXaW5kb3dDbGFzcygpOwogc3RhdGljIExQQ1RT VFIga1dlYkluc3BlY3RvclBvaW50ZXJQcm9wID0gVEVYVCgiV2ViSW5zcGVjdG9yUG9pbnRlciIp OwpAQCAtMjE1LDEzICsyMTcsMTMgQEAgU3RyaW5nIFdlYkluc3BlY3RvckNsaWVudDo6aGlkZGVu UGFuZWxzKAogdm9pZCBXZWJJbnNwZWN0b3JDbGllbnQ6OnNob3dXaW5kb3coKQogewogICAgIHNo b3dXaW5kb3dXaXRob3V0Tm90aWZpY2F0aW9ucygpOwotICAgIG1faW5zcGVjdGVkV2ViVmlldy0+ cGFnZSgpLT5pbnNwZWN0b3JDb250cm9sbGVyKCktPnNldFdpbmRvd1Zpc2libGUodHJ1ZSk7Cisg ICAgbV9pbnNwZWN0ZWRXZWJWaWV3LT5wYWdlKCktPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+c2V0 V2luZG93VmlzaWJsZSh0cnVlLCBtX3Nob3VsZEF0dGFjaFdoZW5TaG93bik7CiB9CiAKIHZvaWQg V2ViSW5zcGVjdG9yQ2xpZW50OjpjbG9zZVdpbmRvdygpCiB7CiAgICAgY2xvc2VXaW5kb3dXaXRo b3V0Tm90aWZpY2F0aW9ucygpOwotICAgIG1faW5zcGVjdGVkV2ViVmlldy0+cGFnZSgpLT5pbnNw ZWN0b3JDb250cm9sbGVyKCktPnNldFdpbmRvd1Zpc2libGUoZmFsc2UpOworICAgIG1faW5zcGVj dGVkV2ViVmlldy0+cGFnZSgpLT5pbnNwZWN0b3JDb250cm9sbGVyKCktPnNldFdpbmRvd1Zpc2li bGUoZmFsc2UsIG1fc2hvdWxkQXR0YWNoV2hlblNob3duKTsKIH0KIAogYm9vbCBXZWJJbnNwZWN0 b3JDbGllbnQ6OndpbmRvd1Zpc2libGUoKQpAQCAtMjM0LDcgKzIzNiw3IEBAIHZvaWQgV2ViSW5z cGVjdG9yQ2xpZW50OjphdHRhY2hXaW5kb3coKQogICAgIGlmIChtX2F0dGFjaGVkKQogICAgICAg ICByZXR1cm47CiAKLSAgICBtX3Nob3VsZEF0dGFjaFdoZW5TaG93biA9IHRydWU7CisgICAgbV9p bnNwZWN0ZWRXZWJWaWV3LT5wYWdlKCktPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+c2V0U2V0dGlu ZyhpbnNwZWN0b3JTdGFydHNBdHRhY2hlZE5hbWUsIEluc3BlY3RvckNvbnRyb2xsZXI6OlNldHRp bmcodHJ1ZSkpOwogCiAgICAgY2xvc2VXaW5kb3dXaXRob3V0Tm90aWZpY2F0aW9ucygpOwogICAg IHNob3dXaW5kb3dXaXRob3V0Tm90aWZpY2F0aW9ucygpOwpAQCAtMjQ1LDcgKzI0Nyw3IEBAIHZv aWQgV2ViSW5zcGVjdG9yQ2xpZW50OjpkZXRhY2hXaW5kb3coKQogICAgIGlmICghbV9hdHRhY2hl ZCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgbV9zaG91bGRBdHRhY2hXaGVuU2hvd24gPSBmYWxz ZTsKKyAgICBtX2luc3BlY3RlZFdlYlZpZXctPnBhZ2UoKS0+aW5zcGVjdG9yQ29udHJvbGxlcigp LT5zZXRTZXR0aW5nKGluc3BlY3RvclN0YXJ0c0F0dGFjaGVkTmFtZSwgSW5zcGVjdG9yQ29udHJv bGxlcjo6U2V0dGluZyhmYWxzZSkpOwogCiAgICAgY2xvc2VXaW5kb3dXaXRob3V0Tm90aWZpY2F0 aW9ucygpOwogICAgIHNob3dXaW5kb3dXaXRob3V0Tm90aWZpY2F0aW9ucygpOwpAQCAtMzIyLDYg KzMyNCw5IEBAIHZvaWQgV2ViSW5zcGVjdG9yQ2xpZW50OjpzaG93V2luZG93V2l0aG8KICAgICBB U1NFUlQobV93ZWJWaWV3KTsKICAgICBBU1NFUlQobV9pbnNwZWN0ZWRXZWJWaWV3SHduZCk7CiAK KyAgICBJbnNwZWN0b3JDb250cm9sbGVyOjpTZXR0aW5nIHNob3VsZEF0dGFjaCA9IG1faW5zcGVj dGVkV2ViVmlldy0+cGFnZSgpLT5pbnNwZWN0b3JDb250cm9sbGVyKCktPnNldHRpbmcoaW5zcGVj dG9yU3RhcnRzQXR0YWNoZWROYW1lKTsKKyAgICBtX3Nob3VsZEF0dGFjaFdoZW5TaG93biA9IChz aG91bGRBdHRhY2gudHlwZSgpID09IEluc3BlY3RvckNvbnRyb2xsZXI6OlNldHRpbmc6OkJvb2xl YW5UeXBlKSA/IHNob3VsZEF0dGFjaC5ib29sZWFuVmFsdWUoKSA6IGZhbHNlOworCiAgICAgaWYg KCFtX3Nob3VsZEF0dGFjaFdoZW5TaG93bikgewogICAgICAgICAvLyBQdXQgdGhlIEluc3BlY3Rv cidzIFdlYlZpZXcgaW5zaWRlIG91ciB3aW5kb3cgYW5kIHNob3cgaXQuCiAgICAgICAgIG1fd2Vi Vmlldy0+c2V0SG9zdFdpbmRvdyhyZWludGVycHJldF9jYXN0PE9MRV9IQU5ETEU+KG1faHduZCkp OwpAQCAtMzg1LDcgKzM5MCw3IEBAIExSRVNVTFQgV2ViSW5zcGVjdG9yQ2xpZW50OjpvblNpemUo V1BBUkEKIExSRVNVTFQgV2ViSW5zcGVjdG9yQ2xpZW50OjpvbkNsb3NlKFdQQVJBTSwgTFBBUkFN KQogewogICAgIDo6U2hvd1dpbmRvdyhtX2h3bmQsIFNXX0hJREUpOwotICAgIG1faW5zcGVjdGVk V2ViVmlldy0+cGFnZSgpLT5pbnNwZWN0b3JDb250cm9sbGVyKCktPnNldFdpbmRvd1Zpc2libGUo ZmFsc2UpOworICAgIG1faW5zcGVjdGVkV2ViVmlldy0+cGFnZSgpLT5pbnNwZWN0b3JDb250cm9s bGVyKCktPnNldFdpbmRvd1Zpc2libGUoZmFsc2UsIG1fc2hvdWxkQXR0YWNoV2hlblNob3duKTsK IAogICAgIGhpZGVIaWdobGlnaHQoKTsKIAo=