271393 2024-03-21 10:11:40 -0700 [IFC][Cleanup] TextOnlySimpleLineBuilder should use rootStyle() 2024-03-21 14:00:14 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 2022790 0 zalan 2024-03-21 10:11:40 -0700 ssia 2022792 1 470460 zalan 2024-03-21 10:15:41 -0700 Created attachment 470460 [fast-cq]Patch 2022872 2 ews-feeder 2024-03-21 13:59:16 -0700 Committed 276491@main (f34f78ad7424): <https://commits.webkit.org/276491@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 470460. 2022873 3 webkit-bug-importer 2024-03-21 14:00:14 -0700 <rdar://problem/125190818> 470460 2024-03-21 10:15:41 -0700 2024-03-21 13:59:17 -0700 [fast-cq]Patch bug-271393-20240321101540.patch text/plain 7602 zalan RnJvbSBjZmJmZmFhODllODhjYzhmYTExNTM4MWNlMGJjNDgzMDgwZDEzZWNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFRodSwgMjEgTWFyIDIwMjQgMTA6MTM6NTggLTA3MDAKU3ViamVjdDogW1BBVENIXSBbSUZDXVtD bGVhbnVwXSBUZXh0T25seVNpbXBsZUxpbmVCdWlsZGVyIHNob3VsZCB1c2UKIHJvb3RTdHlsZSgp IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzEzOTMKClJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgoKcm9vdFN0eWxlKCkgYWxyZWFkeSByZXR1cm5zIHRoZSBsaW5l IGFwcHJvcHJpYXRlIHN0eWxlLgoKKiBTb3VyY2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0Nv bnRleHRzL2lubGluZS9JbmxpbmVMaW5lQnVpbGRlci5jcHA6CihXZWJDb3JlOjpMYXlvdXQ6Okxp bmVCdWlsZGVyOjphZGp1c3RlZExpbmVSZWN0V2l0aENhbmRpZGF0ZUlubGluZUNvbnRlbnQgY29u c3QpOgoqIFNvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL1Rl eHRPbmx5U2ltcGxlTGluZUJ1aWxkZXIuY3BwOgooV2ViQ29yZTo6TGF5b3V0OjpUZXh0T25seVNp bXBsZUxpbmVCdWlsZGVyOjpUZXh0T25seVNpbXBsZUxpbmVCdWlsZGVyKToKKFdlYkNvcmU6Okxh eW91dDo6VGV4dE9ubHlTaW1wbGVMaW5lQnVpbGRlcjo6bGF5b3V0SW5saW5lQ29udGVudCk6CihX ZWJDb3JlOjpMYXlvdXQ6OlRleHRPbmx5U2ltcGxlTGluZUJ1aWxkZXI6OnBsYWNlSW5saW5lVGV4 dENvbnRlbnQpOgooV2ViQ29yZTo6TGF5b3V0OjpUZXh0T25seVNpbXBsZUxpbmVCdWlsZGVyOjpw bGFjZU5vbldyYXBwaW5nSW5saW5lVGV4dENvbnRlbnQpOgooV2ViQ29yZTo6TGF5b3V0OjpUZXh0 T25seVNpbXBsZUxpbmVCdWlsZGVyOjpjb21taXRDYW5kaWRhdGVDb250ZW50KToKKFdlYkNvcmU6 OkxheW91dDo6VGV4dE9ubHlTaW1wbGVMaW5lQnVpbGRlcjo6aGFuZGxlTGluZUVuZGluZyk6CihX ZWJDb3JlOjpMYXlvdXQ6OlRleHRPbmx5U2ltcGxlTGluZUJ1aWxkZXI6OnJldmVydFRvVHJhaWxp bmdJdGVtKToKLS0tCiAuLi4vaW5saW5lL0lubGluZUxpbmVCdWlsZGVyLmNwcCAgICAgICAgICAg ICAgICB8ICAyICstCiAuLi4vaW5saW5lL1RleHRPbmx5U2ltcGxlTGluZUJ1aWxkZXIuY3BwICAg ICAgICB8IDE3ICsrKysrKysrLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9u cygrKSwgMTAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGluZUJ1aWxkZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvSW5saW5lTGluZUJ1aWxk ZXIuY3BwCmluZGV4IDk4NDkwMTZmZDgzOC4uYmY0M2M0ZDljNzRhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvZm9ybWF0dGluZ0NvbnRleHRzL2lubGluZS9JbmxpbmVMaW5lQnVp bGRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9p bmxpbmUvSW5saW5lTGluZUJ1aWxkZXIuY3BwCkBAIC04MDEsNyArODAxLDcgQEAgTGluZUJ1aWxk ZXI6OlJlY3RBbmRGbG9hdENvbnN0cmFpbnRzIExpbmVCdWlsZGVyOjphZGp1c3RlZExpbmVSZWN0 V2l0aENhbmRpZGF0ZUkKICAgICAgICAgcmV0dXJuIHsgbV9saW5lTG9naWNhbFJlY3QgfTsKICAg ICAvLyBGSVhNRTogVXNlIElubGluZUZvcm1hdHRpbmdVdGlsczo6aW5saW5lTGV2ZWxCb3hBZmZl Y3RzTGluZUJveCBpbnN0ZWFkLgogICAgIGF1dG8gY2FuZGlkYXRlQ29udGVudEhlaWdodCA9IElu bGluZUxheW91dFVuaXQgeyB9OwotICAgIGF1dG8gbGluZUJveENvbnRhaW4gPSBmb3JtYXR0aW5n Q29udGV4dCgpLnJvb3QoKS5zdHlsZSgpLmxpbmVCb3hDb250YWluKCk7CisgICAgYXV0byBsaW5l Qm94Q29udGFpbiA9IHJvb3RTdHlsZSgpLmxpbmVCb3hDb250YWluKCk7CiAgICAgZm9yIChhdXRv JiBydW4gOiBpbmxpbmVDb250ZW50LmNvbnRpbnVvdXNDb250ZW50KCkucnVucygpKSB7CiAgICAg ICAgIGF1dG8mIGlubGluZUl0ZW0gPSBydW4uaW5saW5lSXRlbTsKICAgICAgICAgaWYgKGlubGlu ZUl0ZW0uaXNUZXh0KCkpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3Jt YXR0aW5nQ29udGV4dHMvaW5saW5lL1RleHRPbmx5U2ltcGxlTGluZUJ1aWxkZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2Zvcm1hdHRpbmdDb250ZXh0cy9pbmxpbmUvVGV4dE9ubHlTaW1w bGVMaW5lQnVpbGRlci5jcHAKaW5kZXggNDUyN2Q5NjY1YWMwLi5mY2E5YjAzMDA0MmIgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9mb3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL1Rl eHRPbmx5U2ltcGxlTGluZUJ1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9m b3JtYXR0aW5nQ29udGV4dHMvaW5saW5lL1RleHRPbmx5U2ltcGxlTGluZUJ1aWxkZXIuY3BwCkBA IC05NCw3ICs5NCw3IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBjb25zdW1lVHJhaWxpbmdMaW5lQnJl YWtJZkFwcGxpY2FibGUoY29uc3QgVGV4dE9ubHlMaW5lQnJlYWtSCiAKIFRleHRPbmx5U2ltcGxl TGluZUJ1aWxkZXI6OlRleHRPbmx5U2ltcGxlTGluZUJ1aWxkZXIoSW5saW5lRm9ybWF0dGluZ0Nv bnRleHQmIGlubGluZUZvcm1hdHRpbmdDb250ZXh0LCBIb3Jpem9udGFsQ29uc3RyYWludHMgcm9v dEhvcml6b250YWxDb25zdHJhaW50cywgY29uc3QgSW5saW5lSXRlbUxpc3QmIGlubGluZUl0ZW1M aXN0KQogICAgIDogQWJzdHJhY3RMaW5lQnVpbGRlcihpbmxpbmVGb3JtYXR0aW5nQ29udGV4dCwg cm9vdEhvcml6b250YWxDb25zdHJhaW50cywgaW5saW5lSXRlbUxpc3QpCi0gICAgLCBtX2lzV3Jh cHBpbmdBbGxvd2VkKFRleHRVdGlsOjppc1dyYXBwaW5nQWxsb3dlZChyb290KCkuc3R5bGUoKSkp CisgICAgLCBtX2lzV3JhcHBpbmdBbGxvd2VkKFRleHRVdGlsOjppc1dyYXBwaW5nQWxsb3dlZChy b290U3R5bGUoKSkpCiB7CiB9CiAKQEAgLTEwNSw4ICsxMDUsNyBAQCBMaW5lTGF5b3V0UmVzdWx0 IFRleHRPbmx5U2ltcGxlTGluZUJ1aWxkZXI6OmxheW91dElubGluZUNvbnRlbnQoY29uc3QgTGlu ZUlucHV0JgogICAgIGF1dG8gcmVzdWx0ID0gbV9saW5lLmNsb3NlKCk7CiAKICAgICBhdXRvIGlz TGFzdElubGluZUNvbnRlbnQgPSBpc0xhc3RMaW5lV2l0aElubGluZUNvbnRlbnQocGxhY2VkQ29u dGVudEVuZCwgbGluZUlucHV0Lm5lZWRzTGF5b3V0UmFuZ2UuZW5kSW5kZXgoKSk7Ci0gICAgYXV0 byYgcm9vdFN0eWxlID0gaXNGaXJzdEZvcm1hdHRlZExpbmUoKSA/IHJvb3QoKS5maXJzdExpbmVT dHlsZSgpIDogcm9vdCgpLnN0eWxlKCk7Ci0gICAgYXV0byBjb250ZW50TG9naWNhbExlZnQgPSBJ bmxpbmVGb3JtYXR0aW5nVXRpbHM6Omhvcml6b250YWxBbGlnbm1lbnRPZmZzZXQocm9vdFN0eWxl LCByZXN1bHQuY29udGVudExvZ2ljYWxSaWdodCwgbV9saW5lTG9naWNhbFJlY3Qud2lkdGgoKSwg cmVzdWx0LmhhbmdpbmdUcmFpbGluZ0NvbnRlbnRXaWR0aCwgcmVzdWx0LnJ1bnMsIGlzTGFzdElu bGluZUNvbnRlbnQpOworICAgIGF1dG8gY29udGVudExvZ2ljYWxMZWZ0ID0gSW5saW5lRm9ybWF0 dGluZ1V0aWxzOjpob3Jpem9udGFsQWxpZ25tZW50T2Zmc2V0KHJvb3RTdHlsZSgpLCByZXN1bHQu Y29udGVudExvZ2ljYWxSaWdodCwgbV9saW5lTG9naWNhbFJlY3Qud2lkdGgoKSwgcmVzdWx0Lmhh bmdpbmdUcmFpbGluZ0NvbnRlbnRXaWR0aCwgcmVzdWx0LnJ1bnMsIGlzTGFzdElubGluZUNvbnRl bnQpOwogCiAgICAgcmV0dXJuIHsgeyBsaW5lSW5wdXQubmVlZHNMYXlvdXRSYW5nZS5zdGFydCwg cGxhY2VkQ29udGVudEVuZCB9CiAgICAgICAgICwgV1RGTW92ZShyZXN1bHQucnVucykKQEAgLTE1 Miw3ICsxNTEsNyBAQCB2b2lkIFRleHRPbmx5U2ltcGxlTGluZUJ1aWxkZXI6OmluaXRpYWxpemUo Y29uc3QgSW5saW5lSXRlbVJhbmdlJiBsYXlvdXRSYW5nZSwgYwogCiBJbmxpbmVJdGVtUG9zaXRp b24gVGV4dE9ubHlTaW1wbGVMaW5lQnVpbGRlcjo6cGxhY2VJbmxpbmVUZXh0Q29udGVudChjb25z dCBJbmxpbmVJdGVtUmFuZ2UmIGxheW91dFJhbmdlKQogewotICAgIGF1dG8mIHJvb3RTdHlsZSA9 ICFpc0ZpcnN0Rm9ybWF0dGVkTGluZSgpID8gcm9vdCgpLnN0eWxlKCkgOiByb290KCkuZmlyc3RM aW5lU3R5bGUoKTsKKyAgICBhdXRvJiByb290U3R5bGUgPSB0aGlzLT5yb290U3R5bGUoKTsKICAg ICBhdXRvIGhhc1dyYXBPcHBvcnR1bml0eUJlZm9yZVdoaXRlc3BhY2UgPSByb290U3R5bGUud2hp dGVTcGFjZUNvbGxhcHNlKCkgIT0gV2hpdGVTcGFjZUNvbGxhcHNlOjpCcmVha1NwYWNlcyAmJiBy b290U3R5bGUubGluZUJyZWFrKCkgIT0gTGluZUJyZWFrOjpBZnRlcldoaXRlU3BhY2U7CiAgICAg c2l6ZV90IHBsYWNlZElubGluZUl0ZW1Db3VudCA9IDA7CiAKQEAgLTIxOSwxMSArMjE4LDExIEBA IElubGluZUl0ZW1Qb3NpdGlvbiBUZXh0T25seVNpbXBsZUxpbmVCdWlsZGVyOjpwbGFjZUlubGlu ZVRleHRDb250ZW50KGNvbnN0IElubGluCiAKIElubGluZUl0ZW1Qb3NpdGlvbiBUZXh0T25seVNp bXBsZUxpbmVCdWlsZGVyOjpwbGFjZU5vbldyYXBwaW5nSW5saW5lVGV4dENvbnRlbnQoY29uc3Qg SW5saW5lSXRlbVJhbmdlJiBsYXlvdXRSYW5nZSkKIHsKLSAgICBBU1NFUlQoIVRleHRVdGlsOjpp c1dyYXBwaW5nQWxsb3dlZChyb290KCkuc3R5bGUoKSkpOworICAgIEFTU0VSVCghVGV4dFV0aWw6 OmlzV3JhcHBpbmdBbGxvd2VkKHJvb3RTdHlsZSgpKSk7CiAgICAgQVNTRVJUKCFtX3BhcnRpYWxM ZWFkaW5nVGV4dEl0ZW0pOwogCiAgICAgYXV0byBjYW5kaWRhdGVDb250ZW50ID0gQ2FuZGlkYXRl VGV4dENvbnRlbnQgeyBsYXlvdXRSYW5nZS5zdGFydEluZGV4KCksIGxheW91dFJhbmdlLnN0YXJ0 SW5kZXgoKSwgeyB9IH07Ci0gICAgYXV0byYgcm9vdFN0eWxlID0gIWlzRmlyc3RGb3JtYXR0ZWRM aW5lKCkgPyByb290KCkuc3R5bGUoKSA6IHJvb3QoKS5maXJzdExpbmVTdHlsZSgpOworICAgIGF1 dG8mIHJvb3RTdHlsZSA9IHRoaXMtPnJvb3RTdHlsZSgpOwogICAgIGF1dG8gaXNFbmRPZkxpbmUg PSBmYWxzZTsKICAgICBhdXRvIHRyYWlsaW5nTGluZUJyZWFrSW5kZXggPSBzdGQ6Om9wdGlvbmFs PHNpemVfdD4geyB9OwogICAgIGF1dG8gbmV4dEl0ZW1JbmRleCA9IGxheW91dFJhbmdlLnN0YXJ0 SW5kZXgoKTsKQEAgLTI2Miw3ICsyNjEsNyBAQCBJbmxpbmVJdGVtUG9zaXRpb24gVGV4dE9ubHlT aW1wbGVMaW5lQnVpbGRlcjo6cGxhY2VOb25XcmFwcGluZ0lubGluZVRleHRDb250ZW50KAogCiBU ZXh0T25seUxpbmVCcmVha1Jlc3VsdCBUZXh0T25seVNpbXBsZUxpbmVCdWlsZGVyOjpjb21taXRD YW5kaWRhdGVDb250ZW50KGNvbnN0IENhbmRpZGF0ZVRleHRDb250ZW50JiBjYW5kaWRhdGVDb250 ZW50LCBjb25zdCBJbmxpbmVJdGVtUmFuZ2UmIGxheW91dFJhbmdlKQogewotICAgIGF1dG8mIHJv b3RTdHlsZSA9ICFpc0ZpcnN0Rm9ybWF0dGVkTGluZSgpID8gcm9vdCgpLnN0eWxlKCkgOiByb290 KCkuZmlyc3RMaW5lU3R5bGUoKTsKKyAgICBhdXRvJiByb290U3R5bGUgPSB0aGlzLT5yb290U3R5 bGUoKTsKICAgICBhdXRvIGhhc0xlYWRpbmdQYXJ0aWFDb250ZW50ID0gbV9wYXJ0aWFsTGVhZGlu Z1RleHRJdGVtICYmIGNhbmRpZGF0ZUNvbnRlbnQuc3RhcnRJbmRleCA9PSBsYXlvdXRSYW5nZS5z dGFydEluZGV4KCk7CiAgICAgYXV0byBjb250ZW50V2lkdGggPSBbJl0gKGF1dG8mIGlubGluZVRl eHRJdGVtLCBJbmxpbmVMYXlvdXRVbml0IGNvbnRlbnRPZmZzZXQpIHsKICAgICAgICAgaWYgKGF1 dG8gbG9naWNhbFdpZHRoID0gaW5saW5lVGV4dEl0ZW0ud2lkdGgoKSkKQEAgLTM4MCw3ICszNzks NyBAQCB2b2lkIFRleHRPbmx5U2ltcGxlTGluZUJ1aWxkZXI6OmhhbmRsZUxpbmVFbmRpbmcoSW5s aW5lSXRlbVBvc2l0aW9uIHBsYWNlZENvbnRlbgogICAgIGF1dG8gaG9yaXpvbnRhbEF2YWlsYWJs ZVNwYWNlID0gbV9saW5lTG9naWNhbFJlY3Qud2lkdGgoKTsKICAgICBhdXRvIGlzTGFzdElubGlu ZUNvbnRlbnQgPSBpc0xhc3RMaW5lV2l0aElubGluZUNvbnRlbnQocGxhY2VkQ29udGVudEVuZCwg bGF5b3V0UmFuZ2VFbmRJbmRleCk7CiAgICAgYXV0byBzaG91bGRQcmVzZXJ2ZVRyYWlsaW5nV2hp dGVzcGFjZSA9IFsmXSB7Ci0gICAgICAgIHJldHVybiByb290KCkuc3R5bGUoKS5saW5lQnJlYWso KSA9PSBMaW5lQnJlYWs6OkFmdGVyV2hpdGVTcGFjZSAmJiBpbnRyaW5zaWNXaWR0aE1vZGUoKSAh PSBJbnRyaW5zaWNXaWR0aE1vZGU6Ok1pbmltdW0gJiYgKCFpc0xhc3RJbmxpbmVDb250ZW50IHx8 IGhvcml6b250YWxBdmFpbGFibGVTcGFjZSA8IG1fbGluZS5jb250ZW50TG9naWNhbFdpZHRoKCkp OworICAgICAgICByZXR1cm4gcm9vdFN0eWxlKCkubGluZUJyZWFrKCkgPT0gTGluZUJyZWFrOjpB ZnRlcldoaXRlU3BhY2UgJiYgaW50cmluc2ljV2lkdGhNb2RlKCkgIT0gSW50cmluc2ljV2lkdGhN b2RlOjpNaW5pbXVtICYmICghaXNMYXN0SW5saW5lQ29udGVudCB8fCBob3Jpem9udGFsQXZhaWxh YmxlU3BhY2UgPCBtX2xpbmUuY29udGVudExvZ2ljYWxXaWR0aCgpKTsKICAgICB9OwogICAgIG1f dHJpbW1lZFRyYWlsaW5nV2hpdGVzcGFjZVdpZHRoID0gbV9saW5lLmhhbmRsZVRyYWlsaW5nVHJp bW1hYmxlQ29udGVudChzaG91bGRQcmVzZXJ2ZVRyYWlsaW5nV2hpdGVzcGFjZSgpID8gTGluZTo6 VHJhaWxpbmdDb250ZW50QWN0aW9uOjpQcmVzZXJ2ZSA6IExpbmU6OlRyYWlsaW5nQ29udGVudEFj dGlvbjo6UmVtb3ZlKTsKICAgICBpZiAoZm9ybWF0dGluZ0NvbnRleHQoKS5xdWlya3MoKS50cmFp bGluZ05vbkJyZWFraW5nU3BhY2VOZWVkc0FkanVzdG1lbnQoaXNJbkludHJpbnNpY1dpZHRoTW9k ZSgpLCBob3Jpem9udGFsQXZhaWxhYmxlU3BhY2UgPCBtX2xpbmUuY29udGVudExvZ2ljYWxXaWR0 aCgpKSkKQEAgLTM5Miw3ICszOTEsNyBAQCB2b2lkIFRleHRPbmx5U2ltcGxlTGluZUJ1aWxkZXI6 OmhhbmRsZUxpbmVFbmRpbmcoSW5saW5lSXRlbVBvc2l0aW9uIHBsYWNlZENvbnRlbgogc2l6ZV90 IFRleHRPbmx5U2ltcGxlTGluZUJ1aWxkZXI6OnJldmVydFRvVHJhaWxpbmdJdGVtKGNvbnN0IElu bGluZUl0ZW1SYW5nZSYgbGF5b3V0UmFuZ2UsIGNvbnN0IElubGluZVRleHRJdGVtJiB0cmFpbGlu Z0lubGluZUl0ZW0pCiB7CiAgICAgYXV0byBpc0ZpcnN0Rm9ybWF0dGVkTGluZSA9IHRoaXMtPmlz Rmlyc3RGb3JtYXR0ZWRMaW5lKCk7Ci0gICAgYXV0byYgcm9vdFN0eWxlID0gIWlzRmlyc3RGb3Jt YXR0ZWRMaW5lID8gcm9vdCgpLnN0eWxlKCkgOiByb290KCkuZmlyc3RMaW5lU3R5bGUoKTsKKyAg ICBhdXRvJiByb290U3R5bGUgPSB0aGlzLT5yb290U3R5bGUoKTsKICAgICBtX2xpbmUuaW5pdGlh bGl6ZSh7IH0sIGlzRmlyc3RGb3JtYXR0ZWRMaW5lKTsKICAgICBzaXplX3QgbnVtYmVyT2ZJbmxp bmVJdGVtc09uTGluZSA9IDA7CiAK