27138 2009-07-09 17:09:51 -0700 LayoutTests/fast/dom/anchor-toString.html is unnecessarily platform-specific 2009-07-10 13:27:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://trac.webkit.org/browser/trunk/LayoutTests/fast/dom/anchor-toString.html P2 Normal --- 1 dpranke dpranke darin dglazkov oldest_to_newest 130772 0 dpranke 2009-07-09 17:09:51 -0700 the above test refers to an <a href="/sometestfile.html"> and checks that the resulting toString() produces valid output. If the test is being run over a filesystem, this will translate to "/sometestfile.html" on most unix systems, but on Windows this is actually implementation-dependent, and could legitimately return either "file:///sometestfile.html" or "file://C:/sometestfile.html" (or another drive letter). Since this test doesn't really seem to be testing the semantics of relative-URL parsing on file: URLs, I think it makes sense to change it to "http://localhost/sometestfile.html" to get something platform-independent. 130775 1 32541 dpranke 2009-07-09 17:21:40 -0700 Created attachment 32541 patch to make test case less platform-specific 130777 2 32541 darin 2009-07-09 17:24:13 -0700 Comment on attachment 32541 patch to make test case less platform-specific How exactly is file:/// platform-specific? Are there platforms that don't use file URLs? 130783 3 32541 darin 2009-07-09 17:42:30 -0700 Comment on attachment 32541 patch to make test case less platform-specific > + * fast/dom/anchor-toString-expected.txt: > + * fast/dom/anchor-toString.html: Strange indentation here. r=me Sorry, I missed the comment explaining what "platform-dependent" meant. I think the comment would have been a lot clearer if it just specifically called out Windows drive letters in URLs as the issue. 130784 4 darin 2009-07-09 17:43:09 -0700 (In reply to comment #0) > Since this test doesn't really seem to be testing the semantics of relative-URL > parsing on file: URLs What do you mean about relative-URL parsing? Aren't these absolute URLs? 130788 5 dpranke 2009-07-09 17:51:00 -0700 The test case has <a href="/sometestfile.html">, which is a relative URL, not an absolute URL. You are right that the comment probably would've been clearer if I'd just mentioned windows drive letters. Also, the formatting in the changelog was off due to tabs not expanding properly, I think. 130930 6 dglazkov 2009-07-10 13:27:04 -0700 Landed as http://trac.webkit.org/changeset/45722. 32541 2009-07-09 17:21:40 -0700 2009-07-09 17:42:30 -0700 patch to make test case less platform-specific patch_bug27138.txt text/plain 1768 dpranke SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ1NjgzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDctMDkgIERpcmsgUHJhbmtlICA8ZHBy YW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2hhbmdpbmcgdGhlIHRlc3Qgc3RyaW5nIGZyb20gYSBwbGF0Zm9ybS1kZXBl bmRlbnQgZmlsZTovLy8gdG8gYSBtb3JlCisgICAgICAgIGdlbmVyaWMgaHR0cDovLworCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzEzOAorCisgICAg ICAgICAgICAgICAgKiBmYXN0L2RvbS9hbmNob3ItdG9TdHJpbmctZXhwZWN0ZWQudHh0OgorICAg ICAgICAqIGZhc3QvZG9tL2FuY2hvci10b1N0cmluZy5odG1sOgorCiAyMDA5LTA3LTA5ICBDaHJp cyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9hbmNob3ItdG9TdHJpbmct ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2FuY2hvci10 b1N0cmluZy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDQ1NjgzKQorKysgTGF5b3V0VGVzdHMvZmFz dC9kb20vYW5jaG9yLXRvU3RyaW5nLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw3 ICsxLDcgQEAKIEEgbGluayEgCiAKLVdyaXRpbmcganVzdCB0aGUgYW5jaG9yIG9iamVjdCAtIGZp bGU6Ly8vc29tZXRlc3RmaWxlLmh0bWwKK1dyaXRpbmcganVzdCB0aGUgYW5jaG9yIG9iamVjdCAt IGh0dHA6Ly9sb2NhbGhvc3Qvc29tZXRlc3RmaWxlLmh0bWwKIAotV3JpdGluZyB0aGUgcmVzdWx0 IG9mIHRoZSBTdHJpbmcoYW5jaG9yKSAtIGZpbGU6Ly8vc29tZXRlc3RmaWxlLmh0bWwKK1dyaXRp bmcgdGhlIHJlc3VsdCBvZiB0aGUgU3RyaW5nKGFuY2hvcikgLSBodHRwOi8vbG9jYWxob3N0L3Nv bWV0ZXN0ZmlsZS5odG1sCiAKLVdyaXRpbmcgdGhlIHJlc3VsdCBvZiB0aGUgYW5jaG9yJ3MgdG9T dHJpbmcoKSBtZXRob2QgLSBmaWxlOi8vL3NvbWV0ZXN0ZmlsZS5odG1sCitXcml0aW5nIHRoZSBy ZXN1bHQgb2YgdGhlIGFuY2hvcidzIHRvU3RyaW5nKCkgbWV0aG9kIC0gaHR0cDovL2xvY2FsaG9z dC9zb21ldGVzdGZpbGUuaHRtbApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vYW5jaG9yLXRv U3RyaW5nLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vYW5jaG9yLXRv U3RyaW5nLmh0bWwJKHJldmlzaW9uIDQ1NjgzKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vYW5j aG9yLXRvU3RyaW5nLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBACi08YSBocmVm PSIvc29tZXRlc3RmaWxlLmh0bWwiIGlkPSJhbmNob3IiPgorPGEgaHJlZj0iaHR0cDovL2xvY2Fs aG9zdC9zb21ldGVzdGZpbGUuaHRtbCIgaWQ9ImFuY2hvciI+CiBBIGxpbmshCiA8L2E+CiA8YnI+ Cg==