271376 2024-03-21 05:03:53 -0700 [Skia] Check if glFence is available before using it 2024-03-31 09:41:37 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 268972 1 cgarcia cgarcia bugs-noreply ujwal.koneru webkit-bug-importer oldest_to_newest 2022711 0 cgarcia 2024-03-21 05:03:53 -0700 If not available we need to call GrDirectContext::submit() with GrSyncCpu=kYes 2022715 1 cgarcia 2024-03-21 05:54:27 -0700 Pull request: https://github.com/WebKit/WebKit/pull/26241 2022749 2 ews-feeder 2024-03-21 08:11:03 -0700 Committed 276463@main (c4b3e26f6881): <https://commits.webkit.org/276463@main> Reviewed commits have been landed. Closing PR #26241 and removing active labels. 2022750 3 webkit-bug-importer 2024-03-21 08:12:14 -0700 <rdar://problem/125168348> 2022886 4 ujwal.koneru 2024-03-21 14:42:03 -0700 Hi Carlos, I am checking in to playstation build failure for this change(https://build.webkit.org/#/builders/42/builds/39115). It looks like GL_SYNC_GPU_COMMANDS_COMPLETE is not available from gles3 headers.(gl3) In gl2 and gl2ext, I could not see the declaration at https://registry.khronos.org/OpenGL/api/GLES2/gl2ext.h The declaration is available from gl3.h https://registry.khronos.org/OpenGL/api/GLES3/gl3.h I am wondering if the code was intended for gl3 check/apple extension support check(GL_SYNC_GPU_COMMANDS_COMPLETE_APPLE ). Please advise. 2025015 5 cgarcia 2024-03-31 09:41:37 -0700 Yes, in that case I guess we need to include gl3.h in the #if USE(LIBEPOXY) else.