27127 2009-07-09 12:39:46 -0700 Upstream fixes to NPV8Object.cpp that make ~30 layout tests pass. 2010-06-12 15:20:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 ajwong webkit-unassigned dglazkov levin oldest_to_newest 130701 0 ajwong 2009-07-09 12:39:46 -0700 see summary 130703 1 32526 ajwong 2009-07-09 12:44:00 -0700 Created attachment 32526 Fixes for NPV8Object.cpp 130705 2 32526 dglazkov 2009-07-09 12:48:48 -0700 Comment on attachment 32526 Fixes for NPV8Object.cpp r=me 131280 3 levin 2009-07-13 02:32:27 -0700 Committed as http://trac.webkit.org/changeset/45798 237347 4 ap 2010-06-12 15:20:04 -0700 *** Bug 26864 has been marked as a duplicate of this bug. *** 32526 2009-07-09 12:44:00 -0700 2009-07-09 12:48:48 -0700 Fixes for NPV8Object.cpp npv8object.patch text/plain 6997 ajwong ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTZhMmUyMS4uNGI0ZTlmZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAwOS0wNy0wOSAgQWxiZXJ0IEouIFdv bmcgIDxhandvbmdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFVwc3RyZWFtIGZpeGVzIHRvIE5QVjhPYmplY3QuY3BwIHRoYXQg bWFrZSB+MzAgbGF5b3V0IHRlc3RzIHBhc3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yNzEyNworCisgICAgICAgIFRoZXJlIHdlcmUgYSBudW1iZXIg b2YgYnVncyBpbnRyb2R1Y2VkIGR1cmluZyB0aGUgbGFzdCB1cHN0cmVhbWluZworICAgICAgICBl ZmZvcnQgdGhhdCBicm9rZSBhcm9uZCAzMCBsYXlvdXQgdGVzdHMuICBUaGlzIGZpeGVzIHRob3Nl IGJ1Z3MuCisgICAgICAgIEl0IGFsc28gaGFzIGNvbXBpbGUgZml4ZXMgdG8gbWF0Y2ggdGhlIHJl Y2VudCBjdXR0aW5nIGFwYXJ0IG9mCisgICAgICAgIFY4UHJveHkuCisKKyAgICAgICAgKiBiaW5k aW5ncy92OC9OUFY4T2JqZWN0LmNwcDoKKyAgICAgICAgKGZyZWVWOE5QT2JqZWN0KToKKyAgICAg ICAgKG5wQ3JlYXRlVjhTY3JpcHRPYmplY3QpOgorICAgICAgICAoTlBOX0ludm9rZSk6CisgICAg ICAgIChOUE5fSW52b2tlRGVmYXVsdCk6CisgICAgICAgIChOUE5fRXZhbHVhdGVIZWxwZXIpOgor ICAgICAgICAoTlBOX1NldEV4Y2VwdGlvbik6CisgICAgICAgIChOUE5fQ29uc3RydWN0KToKKwog MjAwOS0wNy0wOCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJ1 YmJlciBzdGFtcGVkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5n cy92OC9OUFY4T2JqZWN0LmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvTlBWOE9iamVjdC5jcHAK aW5kZXggYTMzYmI2Yi4uMjE1MDFiOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9O UFY4T2JqZWN0LmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L05QVjhPYmplY3QuY3BwCkBA IC0zNSwxMSArMzUsMTMgQEAKICNpbmNsdWRlICJQbGF0Zm9ybVN0cmluZy5oIgogI2luY2x1ZGUg IlNjcmlwdENvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJWOEN1c3RvbUJpbmRpbmcuaCIKKyNpbmNs dWRlICJWOEdDQ29udHJvbGxlci5oIgogI2luY2x1ZGUgIlY4SGVscGVycy5oIgogI2luY2x1ZGUg IlY4TlBVdGlscy5oIgogI2luY2x1ZGUgIlY4UHJveHkuaCIKICNpbmNsdWRlICJiaW5kaW5ncy9u cHJ1bnRpbWUuaCIKICNpbmNsdWRlICJucHJ1bnRpbWVfcHJpdi5oIgorI2luY2x1ZGUgInd0Zi9T dHJpbmdFeHRyYXMuaCIKIAogI2luY2x1ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSA8djguaD4KQEAg LTQ4LDYgKzUwLDggQEAgdXNpbmcgV2ViQ29yZTo6dG9WOENvbnRleHQ7CiB1c2luZyBXZWJDb3Jl Ojp0b1Y4UHJveHk7CiB1c2luZyBXZWJDb3JlOjpWOENsYXNzSW5kZXg7CiB1c2luZyBXZWJDb3Jl OjpWOEN1c3RvbTsKK3VzaW5nIFdlYkNvcmU6OlY4RE9NV3JhcHBlcjsKK3VzaW5nIFdlYkNvcmU6 OlY4R0NDb250cm9sbGVyOwogdXNpbmcgV2ViQ29yZTo6VjhQcm94eTsKIAogLy8gRklYTUU6IENv bW1lbnRzIG9uIHdoeSB1c2UgbWFsbG9jIGFuZCBmcmVlLgpAQCAtNjAsNyArNjQsNyBAQCBzdGF0 aWMgdm9pZCBmcmVlVjhOUE9iamVjdChOUE9iamVjdCogbnBPYmplY3QpCiB7CiAgICAgVjhOUE9i amVjdCogdjhOcE9iamVjdCA9IHJlaW50ZXJwcmV0X2Nhc3Q8VjhOUE9iamVjdCo+KG5wT2JqZWN0 KTsKICNpZm5kZWYgTkRFQlVHCi0gICAgVjhHQ0NvbnRyb2xsZXI6OlVucmVnaXN0ZXJHbG9iYWxI YW5kbGUodjhOcE9iamVjdCwgdjhOcE9iamVjdC0+djhPYmplY3QpOworICAgIFY4R0NDb250cm9s bGVyOjp1bnJlZ2lzdGVyR2xvYmFsSGFuZGxlKHY4TnBPYmplY3QsIHY4TnBPYmplY3QtPnY4T2Jq ZWN0KTsKICNlbmRpZgogICAgIHY4TnBPYmplY3QtPnY4T2JqZWN0LkRpc3Bvc2UoKTsKICAgICBm cmVlKHY4TnBPYmplY3QpOwpAQCAtOTgsMTkgKzEwMiwyMSBAQCBOUENsYXNzKiBucFNjcmlwdE9i amVjdENsYXNzID0gJlY4TlBPYmplY3RDbGFzczsKIAogTlBPYmplY3QqIG5wQ3JlYXRlVjhTY3Jp cHRPYmplY3QoTlBQIG5wcCwgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBvYmplY3QsIFdlYkNvcmU6 OkRPTVdpbmRvdyogcm9vdCkKIHsKLSAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiB0eXBlSW5kZXgg PSBvYmplY3QtPkdldEludGVybmFsRmllbGQoVjhDdXN0b206OmtET01XcmFwcGVyVHlwZUluZGV4 KTsKICAgICAvLyBDaGVjayB0byBzZWUgaWYgdGhpcyBvYmplY3QgaXMgYWxyZWFkeSB3cmFwcGVk LgotICAgIGlmIChvYmplY3QtPkludGVybmFsRmllbGRDb3VudCgpID09IFY4Q3VzdG9tOjprTlBP YmplY3RJbnRlcm5hbEZpZWxkQ291bnQgJiYgdHlwZUluZGV4LT5Jc051bWJlcigpICYmIHR5cGVJ bmRleC0+VWludDMyVmFsdWUoKSA9PSBWOENsYXNzSW5kZXg6Ok5QT0JKRUNUKSB7CisgICAgaWYg KG9iamVjdC0+SW50ZXJuYWxGaWVsZENvdW50KCkgPT0gVjhDdXN0b206OmtOUE9iamVjdEludGVy bmFsRmllbGRDb3VudCkgeworICAgICAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiB0eXBlSW5kZXgg PSBvYmplY3QtPkdldEludGVybmFsRmllbGQoVjhDdXN0b206OmtET01XcmFwcGVyVHlwZUluZGV4 KTsKKyAgICAgICAgaWYgKHR5cGVJbmRleC0+SXNOdW1iZXIoKSAmJiB0eXBlSW5kZXgtPlVpbnQz MlZhbHVlKCkgPT0gVjhDbGFzc0luZGV4OjpOUE9CSkVDVCkgewogCi0gICAgICAgIE5QT2JqZWN0 KiByZXR1cm5WYWx1ZSA9IFY4UHJveHk6OlRvTmF0aXZlT2JqZWN0PE5QT2JqZWN0PihWOENsYXNz SW5kZXg6Ok5QT0JKRUNULCBvYmplY3QpOwotICAgICAgICBOUE5fUmV0YWluT2JqZWN0KHJldHVy blZhbHVlKTsKLSAgICAgICAgcmV0dXJuIHJldHVyblZhbHVlOworICAgICAgICAgICAgTlBPYmpl Y3QqIHJldHVyblZhbHVlID0gVjhET01XcmFwcGVyOjpjb252ZXJ0VG9OYXRpdmVPYmplY3Q8TlBP YmplY3Q+KFY4Q2xhc3NJbmRleDo6TlBPQkpFQ1QsIG9iamVjdCk7CisgICAgICAgICAgICBOUE5f UmV0YWluT2JqZWN0KHJldHVyblZhbHVlKTsKKyAgICAgICAgICAgIHJldHVybiByZXR1cm5WYWx1 ZTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIFY4TlBPYmplY3QqIHY4bnBPYmplY3QgPSByZWlu dGVycHJldF9jYXN0PFY4TlBPYmplY3QqPihOUE5fQ3JlYXRlT2JqZWN0KG5wcCwgJlY4TlBPYmpl Y3RDbGFzcykpOwogICAgIHY4bnBPYmplY3QtPnY4T2JqZWN0ID0gdjg6OlBlcnNpc3RlbnQ8djg6 Ok9iamVjdD46Ok5ldyhvYmplY3QpOwogI2lmbmRlZiBOREVCVUcKLSAgICBWOFByb3h5OjpSZWdp c3Rlckdsb2JhbEhhbmRsZShXZWJDb3JlOjpOUE9CSkVDVCwgdjhucE9iamVjdCwgdjhucE9iamVj dC0+djhPYmplY3QpOworICAgIFY4R0NDb250cm9sbGVyOjpyZWdpc3Rlckdsb2JhbEhhbmRsZShX ZWJDb3JlOjpOUE9CSkVDVCwgdjhucE9iamVjdCwgdjhucE9iamVjdC0+djhPYmplY3QpOwogI2Vu ZGlmCiAgICAgdjhucE9iamVjdC0+cm9vdE9iamVjdCA9IHJvb3Q7CiAgICAgcmV0dXJuIHJlaW50 ZXJwcmV0X2Nhc3Q8TlBPYmplY3QqPih2OG5wT2JqZWN0KTsKQEAgLTEyMiw4ICsxMjgsOCBAQCBi b29sIE5QTl9JbnZva2UoTlBQIG5wcCwgTlBPYmplY3QqIG5wT2JqZWN0LCBOUElkZW50aWZpZXIg bWV0aG9kTmFtZSwgY29uc3QgTlBWYQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBpZiAo bnBPYmplY3QtPl9jbGFzcyAhPSBucFNjcmlwdE9iamVjdENsYXNzKSB7Ci0gICAgICAgIGlmIChu cE9iamVjdC0+X2NsYXNzLT5pbnZva2VEZWZhdWx0KQotICAgICAgICAgICAgcmV0dXJuIG5wT2Jq ZWN0LT5fY2xhc3MtPmludm9rZURlZmF1bHQobnBPYmplY3QsIGFyZ3VtZW50cywgYXJndW1lbnRD b3VudCwgcmVzdWx0KTsKKyAgICAgICAgaWYgKG5wT2JqZWN0LT5fY2xhc3MtPmludm9rZSkKKyAg ICAgICAgICAgIHJldHVybiBucE9iamVjdC0+X2NsYXNzLT5pbnZva2UobnBPYmplY3QsIG1ldGhv ZE5hbWUsIGFyZ3VtZW50cywgYXJndW1lbnRDb3VudCwgcmVzdWx0KTsKIAogICAgICAgICBWT0lE X1RPX05QVkFSSUFOVCgqcmVzdWx0KTsKICAgICAgICAgcmV0dXJuIHRydWU7CkBAIC0xNjcsNyAr MTczLDcgQEAgYm9vbCBOUE5fSW52b2tlKE5QUCBucHAsIE5QT2JqZWN0KiBucE9iamVjdCwgTlBJ ZGVudGlmaWVyIG1ldGhvZE5hbWUsIGNvbnN0IE5QVmEKICAgICAvLyBDYWxsIHRoZSBmdW5jdGlv biBvYmplY3QuCiAgICAgdjg6OkhhbmRsZTx2ODo6RnVuY3Rpb24+IGZ1bmN0aW9uID0gdjg6Okhh bmRsZTx2ODo6RnVuY3Rpb24+OjpDYXN0KGZ1bmN0aW9uT2JqZWN0KTsKICAgICBPd25BcnJheVB0 cjx2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gPiBhcmd2KGNyZWF0ZVZhbHVlTGlzdEZyb21WYXJpYW50 QXJncyhhcmd1bWVudHMsIGFyZ3VtZW50Q291bnQsIG5wT2JqZWN0KSk7Ci0gICAgdjg6OkxvY2Fs PHY4OjpWYWx1ZT4gcmVzdWx0T2JqZWN0ID0gcHJveHktPkNhbGxGdW5jdGlvbihmdW5jdGlvbiwg djhOcE9iamVjdC0+djhPYmplY3QsIGFyZ3VtZW50Q291bnQsIGFyZ3YuZ2V0KCkpOworICAgIHY4 OjpMb2NhbDx2ODo6VmFsdWU+IHJlc3VsdE9iamVjdCA9IHByb3h5LT5jYWxsRnVuY3Rpb24oZnVu Y3Rpb24sIHY4TnBPYmplY3QtPnY4T2JqZWN0LCBhcmd1bWVudENvdW50LCBhcmd2LmdldCgpKTsK IAogICAgIC8vIElmIHdlIGhhZCBhbiBlcnJvciwgcmV0dXJuIGZhbHNlLiAgVGhlIHNwZWMgaXMg YSBsaXR0bGUgdW5jbGVhciBoZXJlLCBidXQgc2F5cyAiUmV0dXJucyB0cnVlIGlmIHRoZSBtZXRo b2Qgd2FzCiAgICAgLy8gc3VjY2Vzc2Z1bGx5IGludm9rZWQiLiAgSWYgd2UgZ2V0IGFuIGVycm9y IHJldHVybiB2YWx1ZSwgd2FzIHRoYXQgc3VjY2Vzc2Z1bGx5IGludm9rZWQ/CkBAIC0yMTUsNyAr MjIxLDcgQEAgYm9vbCBOUE5fSW52b2tlRGVmYXVsdChOUFAgbnBwLCBOUE9iamVjdCogbnBPYmpl Y3QsIGNvbnN0IE5QVmFyaWFudCogYXJndW1lbnRzLAogICAgICAgICBBU1NFUlQocHJveHkpOwog CiAgICAgICAgIE93bkFycmF5UHRyPHY4OjpIYW5kbGU8djg6OlZhbHVlPiA+IGFyZ3YoY3JlYXRl VmFsdWVMaXN0RnJvbVZhcmlhbnRBcmdzKGFyZ3VtZW50cywgYXJndW1lbnRDb3VudCwgbnBPYmpl Y3QpKTsKLSAgICAgICAgcmVzdWx0T2JqZWN0ID0gcHJveHktPkNhbGxGdW5jdGlvbihmdW5jdGlv biwgZnVuY3Rpb25PYmplY3QsIGFyZ3VtZW50Q291bnQsIGFyZ3YuZ2V0KCkpOworICAgICAgICBy ZXN1bHRPYmplY3QgPSBwcm94eS0+Y2FsbEZ1bmN0aW9uKGZ1bmN0aW9uLCBmdW5jdGlvbk9iamVj dCwgYXJndW1lbnRDb3VudCwgYXJndi5nZXQoKSk7CiAgICAgfQogICAgIC8vIElmIHdlIGhhZCBh biBlcnJvciwgcmV0dXJuIGZhbHNlLiAgVGhlIHNwZWMgaXMgYSBsaXR0bGUgdW5jbGVhciBoZXJl LCBidXQgc2F5cyAiUmV0dXJucyB0cnVlIGlmIHRoZSBtZXRob2Qgd2FzCiAgICAgLy8gc3VjY2Vz c2Z1bGx5IGludm9rZWQiLiAgSWYgd2UgZ2V0IGFuIGVycm9yIHJldHVybiB2YWx1ZSwgd2FzIHRo YXQgc3VjY2Vzc2Z1bGx5IGludm9rZWQ/CkBAIC0yNTMsNyArMjU5LDcgQEAgYm9vbCBOUE5fRXZh bHVhdGVIZWxwZXIoTlBQIG5wcCwgYm9vbCBwb3B1cHNBbGxvd2VkLCBOUE9iamVjdCogbnBPYmpl Y3QsIE5QU3RyaW4KIAogICAgIFdlYkNvcmU6OlN0cmluZyBmaWxlbmFtZTsKICAgICBpZiAoIXBv cHVwc0FsbG93ZWQpCi0gICAgICAgIGZpbGVuYW1lID0gIm5wU2NyaXB0IjsKKyAgICAgICAgZmls ZW5hbWUgPSAibnBzY3JpcHQiOwogCiAgICAgV2ViQ29yZTo6U3RyaW5nIHNjcmlwdCA9IFdlYkNv cmU6OlN0cmluZzo6ZnJvbVVURjgobnBTY3JpcHQtPlVURjhDaGFyYWN0ZXJzLCBucFNjcmlwdC0+ VVRGOExlbmd0aCk7CiAgICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gdjhyZXN1bHQgPSBwcm94eS0+ ZXZhbHVhdGUoV2ViQ29yZTo6U2NyaXB0U291cmNlQ29kZShzY3JpcHQsIFdlYkNvcmU6OktVUkwo ZmlsZW5hbWUpKSwgMCk7CkBAIC00MDEsNyArNDA3LDcgQEAgdm9pZCBOUE5fU2V0RXhjZXB0aW9u KE5QT2JqZWN0KiBucE9iamVjdCwgY29uc3QgTlBVVEY4ICptZXNzYWdlKQogICAgICAgICByZXR1 cm47CiAKICAgICB2ODo6Q29udGV4dDo6U2NvcGUgc2NvcGUoY29udGV4dCk7Ci0gICAgVjhQcm94 eTo6VGhyb3dFcnJvcihWOFByb3h5OjpHRU5FUkFMX0VSUk9SLCBtZXNzYWdlKTsKKyAgICBWOFBy b3h5Ojp0aHJvd0Vycm9yKFY4UHJveHk6OkdlbmVyYWxFcnJvciwgbWVzc2FnZSk7CiB9CiAKIGJv b2wgTlBOX0VudW1lcmF0ZShOUFAgbnBwLCBOUE9iamVjdCogbnBPYmplY3QsIE5QSWRlbnRpZmll cioqIGlkZW50aWZpZXIsIHVpbnQzMl90KiBjb3VudCkKQEAgLTQ4NSw3ICs0OTEsNyBAQCBib29s IE5QTl9Db25zdHJ1Y3QoTlBQIG5wcCwgTlBPYmplY3QqIG5wT2JqZWN0LCBjb25zdCBOUFZhcmlh bnQqIGFyZ3VtZW50cywgdWludAogICAgICAgICAgICAgQVNTRVJUKHByb3h5KTsKIAogICAgICAg ICAgICAgT3duQXJyYXlQdHI8djg6OkhhbmRsZTx2ODo6VmFsdWU+ID4gYXJndihjcmVhdGVWYWx1 ZUxpc3RGcm9tVmFyaWFudEFyZ3MoYXJndW1lbnRzLCBhcmd1bWVudENvdW50LCBucE9iamVjdCkp OwotICAgICAgICAgICAgcmVzdWx0T2JqZWN0ID0gcHJveHktPk5ld0luc3RhbmNlKGN0b3IsIGFy Z3VtZW50Q291bnQsIGFyZ3YuZ2V0KCkpOworICAgICAgICAgICAgcmVzdWx0T2JqZWN0ID0gcHJv eHktPm5ld0luc3RhbmNlKGN0b3IsIGFyZ3VtZW50Q291bnQsIGFyZ3YuZ2V0KCkpOwogICAgICAg ICB9CiAKICAgICAgICAgaWYgKHJlc3VsdE9iamVjdC5Jc0VtcHR5KCkpCg==