27122 2009-07-09 10:25:01 -0700 prepare-ChangeLog should decode HTML entities in short description 2009-07-13 02:37:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 hamaji webkit-unassigned hamaji levin oldest_to_newest 130683 0 hamaji 2009-07-09 10:25:01 -0700 When I ran ./WebKitTools/Scripts/prepare-ChangeLog --bug=25406 I've got -webkit-box-orient:horizontal doesn't work on <button> tag in ChangeLog. It is better to decode HTML entities. 130685 1 32522 hamaji 2009-07-09 10:27:04 -0700 Created attachment 32522 Patch v1 130693 2 32522 darin 2009-07-09 12:07:54 -0700 Comment on attachment 32522 Patch v1 Is the HTML::Entities package installed on everyone's system? Is it included with Mac OS X, for example? 130699 3 hamaji 2009-07-09 12:26:43 -0700 (In reply to comment #2) > (From update of attachment 32522 [details]) > Is the HTML::Entities package installed on everyone's system? Is it included > with Mac OS X, for example? Environments I checked (OSX 10.4, 10.5, Debian, Ubuntu, Cygwin) had the module. However, I've just noticed that perl-5.8.8 source package don't have the module so it seems not to be a part of standard. Should I implement it by myself? It would not difficult at all because we don't need all HTML entites but ones bugzilla use (maybe <>"'& I guess?). 130704 4 32527 hamaji 2009-07-09 12:47:43 -0700 Created attachment 32527 Patch v2 130706 5 hamaji 2009-07-09 12:53:03 -0700 Attached another patch which doesn't use HTML::Entities. I grepped bugzilla's source code and found xml_quote is the only function which has "'". So, I guessed that we don't need to decode &#[0-9a-f]{3}; style entities. 130710 6 32528 hamaji 2009-07-09 13:03:27 -0700 Created attachment 32528 Patch v3 Oops sorry. I forgot to add function declaration for decodeEntities. 130813 7 32528 mjs 2009-07-09 20:07:28 -0700 Comment on attachment 32528 Patch v3 r=me 131283 8 levin 2009-07-13 02:37:39 -0700 Committed as http://trac.webkit.org/changeset/45799 32522 2009-07-09 10:27:04 -0700 2009-07-09 12:47:43 -0700 Patch v1 prep.patch text/plain 1489 hamaji NTc2M2UzYzI5ODVmNjdlOTE4M2JmMDAxNjViZDExNjZjMjFlNjcwMgpkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGIwZmJmNTgu LjMwMDcxNjkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRU b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0wNy0wOSAgU2hpbmljaGlybyBI YW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIHByZXBhcmUtQ2hhbmdlTG9nIHNob3VsZCBkZWNvZGUgSFRN TCBlbnRpdGllcyBpbiBzaG9ydCBkZXNjcmlwdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjcxMjIKKworICAgICAgICBEZWNvZGUgc2hvcnQgZGVz Y3JpcHRpb24gdXNpbmcgSFRNTDo6RW50aXRpZXMgbW9kdWxlLgorCisgICAgICAgICogU2NyaXB0 cy9wcmVwYXJlLUNoYW5nZUxvZzoKKwogMjAwOS0wNy0wOCAgRGF2aWQgS2lsemVyICA8ZGRraWx6 ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1ZyAyNzA2MjogYnVnemlsbGEtdG9vbDogcG9zdC1j b21taXRzIHNob3VsZCByZWFkIGJ1ZyBpZCBmcm9tIGNvbW1pdCBsb2cgYW5kIGFjdHVhbGx5IHdv cmsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCmluZGV4IGU3ODFlODMuLmE1NTNi ZTggMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKKysr IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwpAQCAtNjAsNiArNjAsNyBA QCB1c2UgRmlsZTo6QmFzZW5hbWU7CiB1c2UgRmlsZTo6U3BlYzsKIHVzZSBGaW5kQmluOwogdXNl IEdldG9wdDo6TG9uZzsKK3VzZSBIVE1MOjpFbnRpdGllczsKIHVzZSBsaWIgJEZpbmRCaW46OkJp bjsKIHVzZSBQT1NJWCBxdyhzdHJmdGltZSk7CiB1c2UgVkNTVXRpbHM7CkBAIC0yNTQsNyArMjU1 LDcgQEAgaWYgKCRidWdOdW1iZXIpIHsKICAgICAjIFBlcmwgaGFzIG5vIGJ1aWx0IGluIFhNTCBw cm9jZXNzaW5nLCBzbyB3ZSdsbCBmZXRjaCBhbmQgcGFyc2Ugd2l0aCBjdXJsIGFuZCBncmVwCiAg ICAgbXkgJGRlc2NyaXB0aW9uTGluZSA9IGBjdXJsIC0tc2lsZW50ICIkYnVnWE1MVVJMIiB8IGdy ZXAgc2hvcnRfZGVzY2A7CiAgICAgJGRlc2NyaXB0aW9uTGluZSA9fiAvPHNob3J0X2Rlc2M+KC4q KTxcL3Nob3J0X2Rlc2M+LzsKLSAgICAkYnVnRGVzY3JpcHRpb24gPSAkMTsKKyAgICAkYnVnRGVz Y3JpcHRpb24gPSBkZWNvZGVfZW50aXRpZXMoJDEpOwogICAgIHByaW50IFNUREVSUiAiICBEZXNj cmlwdGlvbiBmcm9tIGJ1ZyAkYnVnTnVtYmVyOlxuICAgIFwiJGJ1Z0Rlc2NyaXB0aW9uXCIuXG4i OwogfQogCg== 32527 2009-07-09 12:47:43 -0700 2009-07-09 13:03:27 -0700 Patch v2 prep.patch text/plain 1841 hamaji NmU2N2MyZmE5ZmVlNTY4ZGQ0ZWYzMzZlYWY4MTUyZDRkNTQzMzZjYQpkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGIwZmJmNTgu LjgzOTcyYmEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRU b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNy0wOSAgU2hpbmljaGlybyBI YW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIHByZXBhcmUtQ2hhbmdlTG9nIHNob3VsZCBkZWNvZGUgSFRN TCBlbnRpdGllcyBpbiBzaG9ydCBkZXNjcmlwdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjcxMjIKKworICAgICAgICBEZWNvZGUgdGhlIHNob3J0 IGRlc2NyaXB0aW9uIGJ5IGFkZGluZyBhIGZ1bmN0aW9uIHdoaWNoIGRlY29kZXMgSFRNTAorICAg ICAgICBlbnRpdGllcy4gSXQgY2FuIGRlY29kZSAmLCA8LCA+LCAiLCBhbmQgJyAuIFRoZXkgbWF5 IGJlIHN1ZmZpY2llbnQKKyAgICAgICAgYXMgdGhlIGRlc2NyaXB0aW9uIHNlZW1zIHRvIGJlIGVu Y29kZWQgYnkgeG1sX3F1b3RlIGluCisgICAgICAgIGh0dHA6Ly9teHIubW96aWxsYS5vcmcvYnVn emlsbGEvc291cmNlL0J1Z3ppbGxhL1V0aWwucG0KKworICAgICAgICAqIFNjcmlwdHMvcHJlcGFy ZS1DaGFuZ2VMb2c6CisKIDIwMDktMDctMDggIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxl LmNvbT4KIAogICAgICAgICBCdWcgMjcwNjI6IGJ1Z3ppbGxhLXRvb2w6IHBvc3QtY29tbWl0cyBz aG91bGQgcmVhZCBidWcgaWQgZnJvbSBjb21taXQgbG9nIGFuZCBhY3R1YWxseSB3b3JrCmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwppbmRleCBlNzgxZTgzLi44N2ViNjNkIDEwMDc1 NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCisrKyBiL1dlYktp dFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKQEAgLTI1NCw3ICsyNTQsNyBAQCBpZiAo JGJ1Z051bWJlcikgewogICAgICMgUGVybCBoYXMgbm8gYnVpbHQgaW4gWE1MIHByb2Nlc3Npbmcs IHNvIHdlJ2xsIGZldGNoIGFuZCBwYXJzZSB3aXRoIGN1cmwgYW5kIGdyZXAKICAgICBteSAkZGVz Y3JpcHRpb25MaW5lID0gYGN1cmwgLS1zaWxlbnQgIiRidWdYTUxVUkwiIHwgZ3JlcCBzaG9ydF9k ZXNjYDsKICAgICAkZGVzY3JpcHRpb25MaW5lID1+IC88c2hvcnRfZGVzYz4oLiopPFwvc2hvcnRf ZGVzYz4vOwotICAgICRidWdEZXNjcmlwdGlvbiA9ICQxOworICAgICRidWdEZXNjcmlwdGlvbiA9 IGRlY29kZUVudGl0aWVzKCQxKTsKICAgICBwcmludCBTVERFUlIgIiAgRGVzY3JpcHRpb24gZnJv bSBidWcgJGJ1Z051bWJlcjpcbiAgICBcIiRidWdEZXNjcmlwdGlvblwiLlxuIjsKIH0KIApAQCAt MTU1NywzICsxNTU3LDE0IEBAIHN1YiBub3JtYWxpemVQYXRoKCQpCiAgICAgJHBhdGggPX4gcy9c XC9cLy9nOwogICAgIHJldHVybiAkcGF0aDsKIH0KKworc3ViIGRlY29kZUVudGl0aWVzKCQpCit7 CisgICAgbXkgKCR0ZXh0KSA9IEBfOworICAgICR0ZXh0ID1+IHMvXCZsdDsvPC9nOworICAgICR0 ZXh0ID1+IHMvXCZndDsvPi9nOworICAgICR0ZXh0ID1+IHMvXCZxdW90Oy9cIi9nOworICAgICR0 ZXh0ID1+IHMvXCZhcG9zOy9cJy9nOworICAgICR0ZXh0ID1+IHMvXCZhbXA7L1wmL2c7CisgICAg cmV0dXJuICR0ZXh0OworfQo= 32528 2009-07-09 13:03:27 -0700 2009-07-09 20:07:28 -0700 Patch v3 prep.patch text/plain 2084 hamaji ZTAwOGU5MDhhOWVhZDIzZDE3YTEyYWVjOTNhNzE5NzllMTFiZDg4YgpkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGIwZmJmNTgu LjgzOTcyYmEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRU b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0wNy0wOSAgU2hpbmljaGlybyBI YW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIHByZXBhcmUtQ2hhbmdlTG9nIHNob3VsZCBkZWNvZGUgSFRN TCBlbnRpdGllcyBpbiBzaG9ydCBkZXNjcmlwdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjcxMjIKKworICAgICAgICBEZWNvZGUgdGhlIHNob3J0 IGRlc2NyaXB0aW9uIGJ5IGFkZGluZyBhIGZ1bmN0aW9uIHdoaWNoIGRlY29kZXMgSFRNTAorICAg ICAgICBlbnRpdGllcy4gSXQgY2FuIGRlY29kZSAmLCA8LCA+LCAiLCBhbmQgJyAuIFRoZXkgbWF5 IGJlIHN1ZmZpY2llbnQKKyAgICAgICAgYXMgdGhlIGRlc2NyaXB0aW9uIHNlZW1zIHRvIGJlIGVu Y29kZWQgYnkgeG1sX3F1b3RlIGluCisgICAgICAgIGh0dHA6Ly9teHIubW96aWxsYS5vcmcvYnVn emlsbGEvc291cmNlL0J1Z3ppbGxhL1V0aWwucG0KKworICAgICAgICAqIFNjcmlwdHMvcHJlcGFy ZS1DaGFuZ2VMb2c6CisKIDIwMDktMDctMDggIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxl LmNvbT4KIAogICAgICAgICBCdWcgMjcwNjI6IGJ1Z3ppbGxhLXRvb2w6IHBvc3QtY29tbWl0cyBz aG91bGQgcmVhZCBidWcgaWQgZnJvbSBjb21taXQgbG9nIGFuZCBhY3R1YWxseSB3b3JrCmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwppbmRleCBlNzgxZTgzLi44NDRkY2VjIDEwMDc1 NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCisrKyBiL1dlYktp dFRvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKQEAgLTkyLDYgKzkyLDcgQEAgc3ViIHBy b2Nlc3NQYXRocyhcQCk7CiBzdWIgcmV2aWV3ZXJBbmREZXNjcmlwdGlvbkZvckdpdENvbW1pdCgk KTsKIHN1YiBub3JtYWxpemVMaW5lRW5kaW5ncygkJCk7CiBzdWIgbm9ybWFsaXplUGF0aCgkKTsK K3N1YiBkZWNvZGVFbnRpdGllcygkKTsKIAogIyBQcm9qZWN0IHRpbWUgem9uZSBmb3IgQ3VwZXJ0 aW5vLCBDQSwgVVMKIG15ICRjaGFuZ2VMb2dUaW1lWm9uZSA9ICJQU1Q4UERUIjsKQEAgLTI1NCw3 ICsyNTUsNyBAQCBpZiAoJGJ1Z051bWJlcikgewogICAgICMgUGVybCBoYXMgbm8gYnVpbHQgaW4g WE1MIHByb2Nlc3NpbmcsIHNvIHdlJ2xsIGZldGNoIGFuZCBwYXJzZSB3aXRoIGN1cmwgYW5kIGdy ZXAKICAgICBteSAkZGVzY3JpcHRpb25MaW5lID0gYGN1cmwgLS1zaWxlbnQgIiRidWdYTUxVUkwi IHwgZ3JlcCBzaG9ydF9kZXNjYDsKICAgICAkZGVzY3JpcHRpb25MaW5lID1+IC88c2hvcnRfZGVz Yz4oLiopPFwvc2hvcnRfZGVzYz4vOwotICAgICRidWdEZXNjcmlwdGlvbiA9ICQxOworICAgICRi dWdEZXNjcmlwdGlvbiA9IGRlY29kZUVudGl0aWVzKCQxKTsKICAgICBwcmludCBTVERFUlIgIiAg RGVzY3JpcHRpb24gZnJvbSBidWcgJGJ1Z051bWJlcjpcbiAgICBcIiRidWdEZXNjcmlwdGlvblwi LlxuIjsKIH0KIApAQCAtMTU1NywzICsxNTU4LDE0IEBAIHN1YiBub3JtYWxpemVQYXRoKCQpCiAg ICAgJHBhdGggPX4gcy9cXC9cLy9nOwogICAgIHJldHVybiAkcGF0aDsKIH0KKworc3ViIGRlY29k ZUVudGl0aWVzKCQpCit7CisgICAgbXkgKCR0ZXh0KSA9IEBfOworICAgICR0ZXh0ID1+IHMvXCZs dDsvPC9nOworICAgICR0ZXh0ID1+IHMvXCZndDsvPi9nOworICAgICR0ZXh0ID1+IHMvXCZxdW90 Oy9cIi9nOworICAgICR0ZXh0ID1+IHMvXCZhcG9zOy9cJy9nOworICAgICR0ZXh0ID1+IHMvXCZh bXA7L1wmL2c7CisgICAgcmV0dXJuICR0ZXh0OworfQo=