271168 2024-03-18 11:12:09 -0700 AX: The accname for summary elements should use on subtree text over the title attribute 2024-03-18 19:53:10 -0700 1 1 1 Unclassified WebKit Accessibility Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig samuel_white webkit-bug-importer oldest_to_newest 2021817 0 tyler_w 2024-03-18 11:12:09 -0700 ... 2021818 1 webkit-bug-importer 2024-03-18 11:12:30 -0700 <rdar://problem/124958776> 2021823 2 470419 tyler_w 2024-03-18 11:16:50 -0700 Created attachment 470419 Patch 2021832 3 cfleizach 2024-03-18 12:01:48 -0700 No test that verified this behavior? 2021836 4 tyler_w 2024-03-18 12:15:52 -0700 (In reply to chris fleizach from comment #3) > No test that verified this behavior? We pass one additional WPT sub-test (note the change of FAIL to PASS in the test expectation file updates). 2021854 5 andresg_22 2024-03-18 13:13:24 -0700 (In reply to Tyler Wilcock from comment #2) > Created attachment 470419 [details] > Patch --- a/LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_tooltip-expected.txt +++ b/LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_tooltip-expected.txt @@ -28,6 +28,6 @@ PASS url input with placeholder and tooltip label PASS textarea with placeholder and tooltip label PASS abbr with tooltip label PASS kbd with tooltip label -FAIL summary with tooltip label and contents assert_equals: <summary title="title" data-expectedlabel="contents" data-testname="summary with tooltip label and contents" class="ex">contents</summary> expected "contents" but got "title" +PASS summary with tooltip label and contents AG: this seems contrary to the "rule" that the ARIA attributes override the HTML construct. If the title is ignored, why to allow a title for this element in the first place? I think your change is fine to pass the test, what I'm questioning is the test itself. 2021855 6 cfleizach 2024-03-18 13:14:53 -0700 (In reply to Tyler Wilcock from comment #4) > (In reply to chris fleizach from comment #3) > > No test that verified this behavior? > We pass one additional WPT sub-test (note the change of FAIL to PASS in the > test expectation file updates). But we removed a very specific behavior. No test was checking that presumably? 2021866 7 tyler_w 2024-03-18 13:41:20 -0700 (In reply to chris fleizach from comment #6) > (In reply to Tyler Wilcock from comment #4) > > (In reply to chris fleizach from comment #3) > > > No test that verified this behavior? > > We pass one additional WPT sub-test (note the change of FAIL to PASS in the > > test expectation file updates). > > But we removed a very specific behavior. No test was checking that > presumably? Ah, yes sorry I misunderstood. This behavior was added in: https://github.com/WebKit/WebKit/commit/ef43e42c5970c6e8ee6423edf077d79829b00867 With no test. It's also contrary to the spec, and to what the other two browsers do, so seems right to remove. 2021867 8 tyler_w 2024-03-18 13:43:20 -0700 (In reply to Andres Gonzalez from comment #5) > (In reply to Tyler Wilcock from comment #2) > > Created attachment 470419 [details] > > Patch > > --- > a/LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_tooltip- > expected.txt > +++ > b/LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_tooltip- > expected.txt > @@ -28,6 +28,6 @@ PASS url input with placeholder and tooltip label > PASS textarea with placeholder and tooltip label > PASS abbr with tooltip label > PASS kbd with tooltip label > -FAIL summary with tooltip label and contents assert_equals: <summary > title="title" data-expectedlabel="contents" data-testname="summary with > tooltip label and contents" class="ex">contents</summary> expected > "contents" but got "title" > +PASS summary with tooltip label and contents > > AG: this seems contrary to the "rule" that the ARIA attributes override the > HTML construct. If the title is ignored, why to allow a title for this > element in the first place? I think your change is fine to pass the test, > what I'm questioning is the test itself. TW: Seems like a good question to raise on the spec, or starting a discussion elsewhere. It's been like this since the html-aam spec was first written. I traced it back to 8 years ago (https://github.com/w3c/html-aam/blame/b9b93b9bd67deb5473c1da3be299705b870b4a80/index.html) hoping to find a reasoning for this, but didn't have any luck. 2022012 9 ews-feeder 2024-03-18 19:53:08 -0700 Committed 276323@main (652ad7d7e57a): <https://commits.webkit.org/276323@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 470419. 470419 2024-03-18 11:16:50 -0700 2024-03-18 19:53:09 -0700 Patch bug-271168-20240318111650.patch text/plain 4762 tyler_w RnJvbSBkN2ZiZDVkZDQwMGZmNjU1MjU4MWYwOTFkZmZlYjgxZTZiNDk3MmEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUeWxlciBXaWxjb2NrIDx0eWxlcl93QGFwcGxlLmNvbT4KRGF0 ZTogTW9uLCAxOCBNYXIgMjAyNCAxMToxNDo1NiAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEFYOiBU aGUgYWNjbmFtZSBmb3Igc3VtbWFyeSBlbGVtZW50cyBzaG91bGQgdXNlIG9uIHN1YnRyZWUKIHRl eHQgb3ZlciB0aGUgdGl0bGUgYXR0cmlidXRlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yNzExNjgKIHJkYXI6Ly9wcm9ibGVtLzEyNDk1ODc3NgoKUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCgpUaGlzIGlzIGRlZmluZWQgaW4gdGhlIHNwZWM6CgpodHRwczovL3cz Yy5naXRodWIuaW8vaHRtbC1hYW0vI3N1bW1hcnktZWxlbWVudC1hY2Nlc3NpYmxlLW5hbWUtY29t cHV0YXRpb24KCiogTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9h Y2NuYW1lL25hbWUvY29tcF90b29sdGlwLWV4cGVjdGVkLnR4dDoKKiBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9nbGliL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvYWNjbmFtZS9uYW1lL2Nv bXBfdG9vbHRpcC1leHBlY3RlZC50eHQ6CiogTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zL2ltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvYWNjbmFtZS9uYW1lL2NvbXBfdG9vbHRpcC1leHBl Y3RlZC50eHQ6CiogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2Jq ZWN0LmNwcDoKKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlPYmplY3Q6OmRlcGVuZHNPblRleHRVbmRl ckVsZW1lbnQgY29uc3QpOgotLS0KIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNz aWJpbGl0eU9iamVjdC5jcHAgICAgICAgICAgfCA0IC0tLS0KIC4uLi93ZWItcGxhdGZvcm0tdGVz dHMvYWNjbmFtZS9uYW1lL2NvbXBfdG9vbHRpcC1leHBlY3RlZC50eHQgfCAyICstCiAuLi4vd2Vi LXBsYXRmb3JtLXRlc3RzL2FjY25hbWUvbmFtZS9jb21wX3Rvb2x0aXAtZXhwZWN0ZWQudHh0IHwg MiArLQogLi4uL3dlYi1wbGF0Zm9ybS10ZXN0cy9hY2NuYW1lL25hbWUvY29tcF90b29sdGlwLWV4 cGVjdGVkLnR4dCB8IDIgKy0KIDQgZmlsZXMgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCA3IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNj ZXNzaWJpbGl0eU9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlPYmplY3QuY3BwCmluZGV4IDRiN2YwNTg5MDgwNy4uZDhkZjE5NmExZmY2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3Qu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVj dC5jcHAKQEAgLTE5MjcsMTAgKzE5MjcsNiBAQCBib29sIEFjY2Vzc2liaWxpdHlPYmplY3Q6OmRl cGVuZHNPblRleHRVbmRlckVsZW1lbnQoKSBjb25zdAogICAgICAgICAgICAgYnJlYWs7CiAgICAg ICAgIEZBTExUSFJPVUdIOwogICAgIGNhc2UgQWNjZXNzaWJpbGl0eVJvbGU6OlN1bW1hcnk6Ci0g ICAgICAgIC8vIFRoZSB0ZXh0IG5vZGUgZm9yIGEgPHN1bW1hcnk+IGVsZW1lbnQgc2hvdWxkIGJl IGluY2x1ZGVkIGluIGl0cyB2aXNpYmxlIHRleHQsIHVubGVzcyBhIHRpdGxlIGF0dHJpYnV0ZSBp cyBwcmVzZW50LgotICAgICAgICBpZiAoIWhhc0F0dHJpYnV0ZSh0aXRsZUF0dHIpKQotICAgICAg ICAgICAgcmV0dXJuIHRydWU7Ci0gICAgICAgIGJyZWFrOwogICAgIGNhc2UgQWNjZXNzaWJpbGl0 eVJvbGU6OkJ1dHRvbjoKICAgICBjYXNlIEFjY2Vzc2liaWxpdHlSb2xlOjpUb2dnbGVCdXR0b246 CiAgICAgY2FzZSBBY2Nlc3NpYmlsaXR5Um9sZTo6Q2hlY2tib3g6CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2FjY25hbWUvbmFtZS9jb21w X3Rvb2x0aXAtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0 Zm9ybS10ZXN0cy9hY2NuYW1lL25hbWUvY29tcF90b29sdGlwLWV4cGVjdGVkLnR4dAppbmRleCAw MTNiYmE1Y2ZlMTkuLjQ2NjhkMWVmNzQ5YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9hY2NuYW1lL25hbWUvY29tcF90b29sdGlwLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L2FjY25hbWUvbmFtZS9jb21wX3Rvb2x0aXAtZXhwZWN0ZWQudHh0CkBAIC0yOCw2ICsyOCw2IEBA IFBBU1MgdXJsIGlucHV0IHdpdGggcGxhY2Vob2xkZXIgYW5kIHRvb2x0aXAgbGFiZWwKIFBBU1Mg dGV4dGFyZWEgd2l0aCBwbGFjZWhvbGRlciBhbmQgdG9vbHRpcCBsYWJlbAogUEFTUyBhYmJyIHdp dGggdG9vbHRpcCBsYWJlbAogUEFTUyBrYmQgd2l0aCB0b29sdGlwIGxhYmVsCi1GQUlMIHN1bW1h cnkgd2l0aCB0b29sdGlwIGxhYmVsIGFuZCBjb250ZW50cyBhc3NlcnRfZXF1YWxzOiA8c3VtbWFy eSB0aXRsZT0idGl0bGUiIGRhdGEtZXhwZWN0ZWRsYWJlbD0iY29udGVudHMiIGRhdGEtdGVzdG5h bWU9InN1bW1hcnkgd2l0aCB0b29sdGlwIGxhYmVsIGFuZCBjb250ZW50cyIgY2xhc3M9ImV4Ij5j b250ZW50czwvc3VtbWFyeT4gZXhwZWN0ZWQgImNvbnRlbnRzIiBidXQgZ290ICJ0aXRsZSIKK1BB U1Mgc3VtbWFyeSB3aXRoIHRvb2x0aXAgbGFiZWwgYW5kIGNvbnRlbnRzCiBQQVNTIGlmcmFtZSB3 aXRoIHRvb2x0aXAgbGFiZWwKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ2xp Yi9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2FjY25hbWUvbmFtZS9jb21wX3Rvb2x0 aXAtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ2xpYi9pbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL2FjY25hbWUvbmFtZS9jb21wX3Rvb2x0aXAtZXhwZWN0ZWQudHh0 CmluZGV4IDE1ZjRjMzE4ZjJiMS4uNTQxZWYyODY2MmE1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9nbGliL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvYWNjbmFtZS9u YW1lL2NvbXBfdG9vbHRpcC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z2xpYi9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2FjY25hbWUvbmFtZS9jb21wX3Rv b2x0aXAtZXhwZWN0ZWQudHh0CkBAIC0yOCw2ICsyOCw2IEBAIFBBU1MgdXJsIGlucHV0IHdpdGgg cGxhY2Vob2xkZXIgYW5kIHRvb2x0aXAgbGFiZWwKIFBBU1MgdGV4dGFyZWEgd2l0aCBwbGFjZWhv bGRlciBhbmQgdG9vbHRpcCBsYWJlbAogUEFTUyBhYmJyIHdpdGggdG9vbHRpcCBsYWJlbAogUEFT UyBrYmQgd2l0aCB0b29sdGlwIGxhYmVsCi1GQUlMIHN1bW1hcnkgd2l0aCB0b29sdGlwIGxhYmVs IGFuZCBjb250ZW50cyBhc3NlcnRfZXF1YWxzOiA8c3VtbWFyeSB0aXRsZT0idGl0bGUiIGRhdGEt ZXhwZWN0ZWRsYWJlbD0iY29udGVudHMiIGRhdGEtdGVzdG5hbWU9InN1bW1hcnkgd2l0aCB0b29s dGlwIGxhYmVsIGFuZCBjb250ZW50cyIgY2xhc3M9ImV4Ij5jb250ZW50czwvc3VtbWFyeT4gZXhw ZWN0ZWQgImNvbnRlbnRzIiBidXQgZ290ICJ0aXRsZSIKK1BBU1Mgc3VtbWFyeSB3aXRoIHRvb2x0 aXAgbGFiZWwgYW5kIGNvbnRlbnRzCiBQQVNTIGlmcmFtZSB3aXRoIHRvb2x0aXAgbGFiZWwKIApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvYWNjbmFtZS9uYW1lL2NvbXBfdG9vbHRpcC1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9pb3MvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9hY2Nu YW1lL25hbWUvY29tcF90b29sdGlwLWV4cGVjdGVkLnR4dAppbmRleCAxNWY0YzMxOGYyYjEuLjU0 MWVmMjg2NjJhNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zL2ltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvYWNjbmFtZS9uYW1lL2NvbXBfdG9vbHRpcC1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvYWNjbmFtZS9uYW1lL2NvbXBfdG9vbHRpcC1leHBlY3RlZC50eHQKQEAgLTI4 LDYgKzI4LDYgQEAgUEFTUyB1cmwgaW5wdXQgd2l0aCBwbGFjZWhvbGRlciBhbmQgdG9vbHRpcCBs YWJlbAogUEFTUyB0ZXh0YXJlYSB3aXRoIHBsYWNlaG9sZGVyIGFuZCB0b29sdGlwIGxhYmVsCiBQ QVNTIGFiYnIgd2l0aCB0b29sdGlwIGxhYmVsCiBQQVNTIGtiZCB3aXRoIHRvb2x0aXAgbGFiZWwK LUZBSUwgc3VtbWFyeSB3aXRoIHRvb2x0aXAgbGFiZWwgYW5kIGNvbnRlbnRzIGFzc2VydF9lcXVh bHM6IDxzdW1tYXJ5IHRpdGxlPSJ0aXRsZSIgZGF0YS1leHBlY3RlZGxhYmVsPSJjb250ZW50cyIg ZGF0YS10ZXN0bmFtZT0ic3VtbWFyeSB3aXRoIHRvb2x0aXAgbGFiZWwgYW5kIGNvbnRlbnRzIiBj bGFzcz0iZXgiPmNvbnRlbnRzPC9zdW1tYXJ5PiBleHBlY3RlZCAiY29udGVudHMiIGJ1dCBnb3Qg InRpdGxlIgorUEFTUyBzdW1tYXJ5IHdpdGggdG9vbHRpcCBsYWJlbCBhbmQgY29udGVudHMKIFBB U1MgaWZyYW1lIHdpdGggdG9vbHRpcCBsYWJlbAogCg==