271132 2024-03-17 14:07:13 -0700 REGRESSION(276246@main): ASSERTION FAILED: contentHasNegativeImplicitMargin 2024-03-28 16:06:10 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=271113 InRadar P2 Normal --- 1 fujii webkit-unassigned ap bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 2021664 0 fujii 2024-03-17 14:07:13 -0700 Only WinCairo is crashing. Regressions: Unexpected crashes (3) fast/text/crash-grapheme-cluster-spanning-adjacent-textitems.html [ Crash ] fast/text/minimum-width-break-on-empty-content-crash.html [ Crash ] fast/text/word-break-column-gap-display-flex-utf16-surrogates.html [ Crash ] History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Ftext%2Fword-break-column-gap-display-flex-utf16-surrogates.html&test=fast%2Ftext%2Fminimum-width-break-on-empty-content-crash.html&test=fast%2Ftext%2Fcrash-grapheme-cluster-spanning-adjacent-textitems.html&platform=wincairo&style=debug https://build.webkit.org/results/WinCairo-64-bit-Debug-Tests/276246@main%20(22114)/fast/text/minimum-width-break-on-empty-content-crash-crash-log.txt ASSERTION FAILED: contentHasNegativeImplicitMargin C:\BW\WinCairo-64-bit-Debug-Build\build\Source\WebCore\layout/formattingContexts/inline/InlineFormattingContext.cpp(201) : minimumMaximumContentSize 1 00007FF8FB3A1CA9 WTFCrash 2 00007FF8D9B32F0D WTFCrashWithInfo 3 00007FF8DD1CFD14 WebCore::Layout::InlineFormattingContext::minimumMaximumContentSize 4 00007FF8DD2BE438 WebCore::LayoutIntegration::LineLayout::computeIntrinsicWidthConstraints 5 00007FF8DDCC2CC4 WebCore::RenderBlockFlow::tryComputePreferredWidthsUsingModernPath 6 00007FF8DDCA9975 WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths 7 00007FF8DDCA96AC WebCore::RenderBlockFlow::computeIntrinsicLogicalWidths 8 00007FF8DDC9EB4E WebCore::RenderBlock::computePreferredLogicalWidths 9 00007FF8DDCCA469 WebCore::RenderBox::maxPreferredLogicalWidth 10 00007FF8DDCC69C3 WebCore::RenderBox::computeLogicalWidthInFragmentUsing 11 00007FF8DDC91941 WebCore::RenderBox::computeLogicalWidthInFragment 12 00007FF8DDCD2250 WebCore::RenderBox::updateLogicalWidth 13 00007FF8DDC8F49A WebCore::RenderBlock::recomputeLogicalWidth 14 00007FF8DDCAB517 WebCore::RenderBlockFlow::recomputeLogicalWidthAndColumnWidth 15 00007FF8DDCAC019 WebCore::RenderBlockFlow::layoutBlock 16 00007FF8DDC8F26E WebCore::RenderBlock::layout 17 00007FF8DDD42C99 WebCore::RenderElement::layoutIfNeeded 18 00007FF8DDCB0CF2 WebCore::RenderBlockFlow::layoutModernLines 19 00007FF8DDCAE766 WebCore::RenderBlockFlow::layoutInlineChildren 20 00007FF8DDCAD5FF WebCore::RenderBlockFlow::layoutInFlowChildren 21 00007FF8DDCAC2FA WebCore::RenderBlockFlow::layoutBlock 22 00007FF8DDC8F26E WebCore::RenderBlock::layout 23 00007FF8DDCAFA03 WebCore::RenderBlockFlow::layoutBlockChild 24 00007FF8DDCAEB4A WebCore::RenderBlockFlow::layoutBlockChildren 25 00007FF8DDCAD63E WebCore::RenderBlockFlow::layoutInFlowChildren 26 00007FF8DDCAC2FA WebCore::RenderBlockFlow::layoutBlock 27 00007FF8DDC8F26E WebCore::RenderBlock::layout 28 00007FF8DDCAFA03 WebCore::RenderBlockFlow::layoutBlockChild 29 00007FF8DDCAEB4A WebCore::RenderBlockFlow::layoutBlockChildren 30 00007FF8DDCAD63E WebCore::RenderBlockFlow::layoutInFlowChildren 31 00007FF8DDCAC2FA WebCore::RenderBlockFlow::layoutBlock 2021665 1 zalan 2024-03-17 14:11:06 -0700 >Only WinCairo is crashing. this is odd! Let me take a look at those tests. 2021666 2 zalan 2024-03-17 14:24:13 -0700 Didn't see anything peculiar. It'd be interesting to find out what else triggers inconsistent min/max results on WinCairo -maybe we just need fuzzy matching? 2023533 3 webkit-bug-importer 2024-03-24 14:08:08 -0700 <rdar://problem/125322599> 2023546 4 470585 fujii 2024-03-24 18:40:17 -0700 Created attachment 470585 WIP patch for fast/text/minimum-width-break-on-empty-content-crash.html For fast/text/minimum-width-break-on-empty-content-crash.html, Font::widthForGlyph of "\n" glyph returns 6 on Windows. This is a width of the space glyph. It should be 0. 2024599 5 fujii 2024-03-28 16:05:58 -0700 276774@main fixed fast/text/minimum-width-break-on-empty-content-crash.html problem. 276797@main fixed fast/text/word-break-column-gap-display-flex-utf16-surrogates.html problem. fast/text/crash-grapheme-cluster-spanning-adjacent-textitems.html is still crashing for Windows port. 470585 2024-03-24 18:40:17 -0700 2024-03-28 16:06:10 -0700 WIP patch for fast/text/minimum-width-break-on-empty-content-crash.html wip.patch text/plain 785 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnQuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udC5jcHAKaW5kZXggYTU3NTA5MTQy MTdmLi5iY2MyYTY2NWFiZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0ZvbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zv bnQuY3BwCkBAIC0zMzksNyArMzM5LDcgQEAgc3RhdGljIHZvaWQgb3ZlcnJpZGVDb250cm9sQ2hh cmFjdGVycyhWZWN0b3I8VUNoYXI+JiBidWZmZXIsIHVuc2lnbmVkIHN0YXJ0LCB1bnMKICAgICBv dmVyd3JpdGVDb2RlUG9pbnRzKG51bGxDaGFyYWN0ZXIsIHNwYWNlLCB6ZXJvV2lkdGhTcGFjZSk7 CiAgICAgb3ZlcndyaXRlQ29kZVBvaW50cyhkZWxldGVDaGFyYWN0ZXIsIG5vQnJlYWtTcGFjZSwg emVyb1dpZHRoU3BhY2UpOwogICAgIG92ZXJ3cml0ZUNvZGVQb2ludChzb2Z0SHlwaGVuLCB6ZXJv V2lkdGhTcGFjZSk7Ci0gICAgb3ZlcndyaXRlQ29kZVBvaW50KG5ld2xpbmVDaGFyYWN0ZXIsIHNw YWNlKTsKKyAgICBvdmVyd3JpdGVDb2RlUG9pbnQobmV3bGluZUNoYXJhY3RlciwgemVyb1dpZHRo U3BhY2UpOwogICAgIG92ZXJ3cml0ZUNvZGVQb2ludCh0YWJDaGFyYWN0ZXIsIHNwYWNlKTsKICAg ICBvdmVyd3JpdGVDb2RlUG9pbnQobm9CcmVha1NwYWNlLCBzcGFjZSk7CiAgICAgb3ZlcndyaXRl Q29kZVBvaW50KGxlZnRUb1JpZ2h0TWFyaywgemVyb1dpZHRoU3BhY2UpOwo=