27098 2009-07-08 15:49:19 -0700 Make prepare-ChangeLog less shouty 2009-07-09 01:14:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mjs mjs oldest_to_newest 130552 0 mjs 2009-07-08 15:49:19 -0700 prepare-ChangeLog's new text is seen by some as overly verbose and SHOUTY. 130553 1 32480 mjs 2009-07-08 15:54:34 -0700 Created attachment 32480 patch 130555 2 32480 mrowe 2009-07-08 15:57:19 -0700 Comment on attachment 32480 patch r=me 130556 3 mjs 2009-07-08 15:58:04 -0700 I didn't solve every possible problem with prepare-ChangeLog, but I tried to make it a bit less shouty. If you don't provide the --bug argument, it includes text like this: --------- 2009-07-08 Maciej Stachowiak <mjs@apple.com> Reviewed by NOBODY (OOPS!). Need a short description and bug URL (OOPS!) * Scripts/prepare-ChangeLog: --------- If you do use --bug, it provides text like this: --------- 2009-07-08 Maciej Stachowiak <mjs@apple.com> Reviewed by NOBODY (OOPS!). Make prepare-ChangeLog less shouty https://bugs.webkit.org/show_bug.cgi?id=27098 * Scripts/prepare-ChangeLog: --------- It also says this on the console (not in the ChangeLog): -- Please remember to include a detailed description in your ChangeLog entry. -- -- See <http://webkit.org/coding/contributing.html> for more info -- 130558 4 32480 eric 2009-07-08 16:00:10 -0700 Comment on attachment 32480 patch + print CHANGE_LOG normalizeLineEndings(" $bugDescription\n", $endl) if $bugDescription; does not need to be conditional anymore. You can remove the "if ..." part. + print CHANGE_LOG normalizeLineEndings(" No new tests. (OOPS!)\n\n", $endl); Seems like that line will often be left in by casual contributers. Mabe just change it back to the WARNING: line before my change? Really, it's up to you. 130633 5 mjs 2009-07-09 01:13:52 -0700 At least when I was testing, the conditional was needed, otherwise it inserted extra blank lines. The "OOPS!" will prevent the "lack of tests" line from being committed as-is. If we also make post-diff complain about it, we should be golden. 130634 6 mjs 2009-07-09 01:14:37 -0700 Also: I committed this. 32480 2009-07-08 15:54:34 -0700 2009-07-08 16:00:10 -0700 patch bugzilla_requires_a_filename.patch text/plain 2566 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ1NjQ2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDct MDggIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHByZXBhcmUtQ2hhbmdlTG9nIGxl c3Mgc2hvdXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yNzA5OAorCisgICAgICAgICogU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZzoKKwogMjAwOS0w Ny0wOCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1ZyAy NzA4MzogYnVnemlsbGEucHk6IENsZWFuIHVwIGJ1Z19zZXJ2ZXIgdXNlCkluZGV4OiBTY3JpcHRz L3ByZXBhcmUtQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNjcmlwdHMvcHJlcGFyZS1DaGFuZ2VM b2cJKHJldmlzaW9uIDQ1NTI4KQorKysgU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMzM0LDIxICszMzQsMTkgQEAgZm9yZWFjaCBteSAkcHJlZml4IChzb3J0IGtl eXMgJWZpbGVzKSB7CiAgICAgcHJpbnQgQ0hBTkdFX0xPRyBub3JtYWxpemVMaW5lRW5kaW5ncygi ICAgICAgICBSZXZpZXdlZCBieSAkcmV2aWV3ZXIuXG5cbiIsICRlbmRsKTsKICAgICBwcmludCBD SEFOR0VfTE9HIG5vcm1hbGl6ZUxpbmVFbmRpbmdzKCRkZXNjcmlwdGlvbiAuICJcbiIsICRlbmRs KSBpZiAkZGVzY3JpcHRpb247CiAKLSAgICAkYnVnRGVzY3JpcHRpb24gPSAiU0hPUlQgREVTQ1JJ UFRJT04vQlVHIFRJVExFIEdPRVMgSEVSRSAoT09QUyEpIiB1bmxlc3MgJGJ1Z0Rlc2NyaXB0aW9u OwotICAgIHByaW50IENIQU5HRV9MT0cgbm9ybWFsaXplTGluZUVuZGluZ3MoIiAgICAgICAgJGJ1 Z0Rlc2NyaXB0aW9uXG4iLCAkZW5kbCk7Ci0KLSAgICAkYnVnVVJMID0gIkJVRyBVUkwgR09FUyBI RVJFIChwYXNzIC0tYnVnPSB0byBhdXRvZmlsbCkiIHVubGVzcyAkYnVnVVJMOwotICAgIHByaW50 IENIQU5HRV9MT0cgbm9ybWFsaXplTGluZUVuZGluZ3MoIiAgICAgICAgJGJ1Z1VSTFxuXG4iLCAk ZW5kbCk7CisgICAgJGJ1Z0Rlc2NyaXB0aW9uID0gIk5lZWQgYSBzaG9ydCBkZXNjcmlwdGlvbiBh bmQgYnVnIFVSTCAoT09QUyEpIiB1bmxlc3MgJGJ1Z0Rlc2NyaXB0aW9uOworICAgIHByaW50IENI QU5HRV9MT0cgbm9ybWFsaXplTGluZUVuZGluZ3MoIiAgICAgICAgJGJ1Z0Rlc2NyaXB0aW9uXG4i LCAkZW5kbCkgaWYgJGJ1Z0Rlc2NyaXB0aW9uOworICAgIHByaW50IENIQU5HRV9MT0cgbm9ybWFs aXplTGluZUVuZGluZ3MoIiAgICAgICAgJGJ1Z1VSTFxuIiwgJGVuZGwpIGlmICRidWdVUkw7Cisg ICAgcHJpbnQgQ0hBTkdFX0xPRyAiXG4iOwogCiAgICAgIyBXZSBjb3VsZCBwcmUtcG9wdWxhdGUg dGhpcyB3aXRoIHRoZSBnaXQgY29tbWl0IGxvZyBvciB3aXRoIHRoZSBidWcgZGVzY3JpcHRpb24u Ci0gICAgcHJpbnQgQ0hBTkdFX0xPRyBub3JtYWxpemVMaW5lRW5kaW5ncygiICAgICAgICBERVRB SUxFRCBERVNDUklQVElPTiBPRiBUSEUgQ0hBTkdFUyBHT0VTIEhFUkUuIChPT1BTISkgU0VFOlxu IiwgJGVuZGwpOwotICAgIHByaW50IENIQU5HRV9MT0cgbm9ybWFsaXplTGluZUVuZGluZ3MoIiAg ICAgICAgaHR0cDovL3dlYmtpdC5vcmcvY29kaW5nL2NvbnRyaWJ1dGluZy5odG1sIEZPUiBNT1JF IElORk9STUFUSU9OXG5cbiIsICRlbmRsKTsKKyAgICBwcmludCAoIi0tIFBsZWFzZSByZW1lbWJl ciB0byBpbmNsdWRlIGEgZGV0YWlsZWQgZGVzY3JpcHRpb24gaW4geW91ciBDaGFuZ2VMb2cgZW50 cnkuIC0tXG4tLSBTZWUgPGh0dHA6Ly93ZWJraXQub3JnL2NvZGluZy9jb250cmlidXRpbmcuaHRt bD4gZm9yIG1vcmUgaW5mbyAtLVxuIik7CiAKICAgICBpZiAoJHByZWZpeCA9fiBtL1dlYkNvcmUv IHx8IGBwd2RgID1+IG0vV2ViQ29yZS8pIHsKICAgICAgICAgaWYgKCRkaWRDaGFuZ2VSZWdyZXNz aW9uVGVzdHMpIHsKICAgICAgICAgICAgIHByaW50IENIQU5HRV9MT0cgbm9ybWFsaXplTGluZUVu ZGluZ3ModGVzdExpc3RGb3JDaGFuZ2VMb2coc29ydCBAYWRkZWRSZWdyZXNzaW9uVGVzdHMpLCAk ZW5kbCk7CiAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBwcmludCBDSEFOR0VfTE9HIG5v cm1hbGl6ZUxpbmVFbmRpbmdzKCIgICAgICAgIExJU1QgT0YgVEVTVFMsIE9SIEVYUExBTkFUSU9O IFdIWSBURVNUSU5HIElTIElNUE9TU0lCTEUgR09FUyBIRVJFIChPT1BTISlcblxuIiwgJGVuZGwp OworICAgICAgICAgICAgcHJpbnQgQ0hBTkdFX0xPRyBub3JtYWxpemVMaW5lRW5kaW5ncygiICAg ICAgICBObyBuZXcgdGVzdHMuIChPT1BTISlcblxuIiwgJGVuZGwpOwogICAgICAgICB9CiAgICAg fQ==