<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>270963</bug_id>
          
          <creation_ts>2024-03-14 02:13:43 -0700</creation_ts>
          <short_desc>[GTK] [2.42.5] SharedContextMutex.cpp: error: inlining failed in call to ‘always_inline’</short_desc>
          <delta_ts>2024-03-14 13:00:00 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alberto Garcia">berto</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2020957</commentid>
    <comment_count>0</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2024-03-14 02:13:43 -0700</bug_when>
    <thetext>Both WebKitGTK and WPE WebKit 2.42.5 have recently stopped building in Debian unstable:

                           ----------------------------------------
/&lt;&lt;PKGBUILDDIR&gt;&gt;/Source/ThirdParty/ANGLE/src/libANGLE/SharedContextMutex.cpp:219:41: error: inlining failed in call to ‘always_inline’ ‘egl::SharedContextMutex&lt;Mutex&gt;* egl::SharedContextMutex&lt;Mutex&gt;::doTryLock() [with Mutex = std::mutex]’: recursive inlining
  219 | ANGLE_INLINE SharedContextMutex&lt;Mutex&gt; *SharedContextMutex&lt;Mutex&gt;::doTryLock()
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~

/&lt;&lt;PKGBUILDDIR&gt;&gt;/Source/ThirdParty/ANGLE/src/libANGLE/SharedContextMutex.cpp:241:41: error: inlining failed in call to ‘always_inline’ ‘egl::SharedContextMutex&lt;Mutex&gt;* egl::SharedContextMutex&lt;Mutex&gt;::doLock() [with Mutex = std::mutex]’: recursive inlining
  241 | ANGLE_INLINE SharedContextMutex&lt;Mutex&gt; *SharedContextMutex&lt;Mutex&gt;::doLock()
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~
                           ----------------------------------------

This is due to the ANGLE_INLINE macro in Source/ThirdParty/ANGLE/src/common/angleutils.h:

   #if defined(NDEBUG) &amp;&amp; ANGLE_HAS_ATTRIBUTE_ALWAYS_INLINE
   #    define ANGLE_INLINE inline __attribute__((always_inline))
   #elif defined(NDEBUG) &amp;&amp; ANGLE_HAS___FORCEINLINE
   #    define ANGLE_INLINE __forceinline
   #else
   #    define ANGLE_INLINE inline
   #endif

I&apos;m building WebKit with NDEBUG so ANGLE_INLINE is &apos;inline __attribute__((always_inline))&apos;

If I stop using NDEBUG or otherwise force ANGLE_INLINE to simply be &apos;inline&apos; then this builds fine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2021101</commentid>
    <comment_count>1</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2024-03-14 13:00:00 -0700</bug_when>
    <thetext>Never mind, this was caused because I was accidentally using -Werror=implicit-function-declaration for C++ files.

Closing as invalid.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>