27090 2009-07-08 12:44:20 -0700 Remove lockBackForwardList argument from HTMLFormElement::submit() 2009-07-08 13:35:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Trivial --- 1 ap ap ggaren oldest_to_newest 130485 0 ap 2009-07-08 12:44:20 -0700 It's always false, no need to pass it in. 130487 1 32467 ap 2009-07-08 12:47:20 -0700 Created attachment 32467 proposed patch 130488 2 32467 ggaren 2009-07-08 12:51:33 -0700 Comment on attachment 32467 proposed patch r=me 130495 3 ap 2009-07-08 13:35:31 -0700 Committed revision 45633 (with some changes suggested by Darin Adler). 32467 2009-07-08 12:47:20 -0700 2009-07-08 12:51:33 -0700 proposed patch RemoveArgument.txt text/plain 4409 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTYzMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMDctMDggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzA5MAorICAgICAgICBS ZW1vdmUgbG9ja0JhY2tGb3J3YXJkTGlzdCBhcmd1bWVudCBmcm9tIEhUTUxGb3JtRWxlbWVudDo6 c3VibWl0KCkKKworICAgICAgICBObyBjaGFuZ2UgaW4gYmVoYXZpb3IsIHNvIG5vIHRlc3RzLgor CisgICAgICAgICogYmluZGluZ3MvanMvSlNIVE1MRm9ybUVsZW1lbnRDdXN0b20uY3BwOiAoV2Vi Q29yZTo6SlNIVE1MRm9ybUVsZW1lbnQ6OnN1Ym1pdCk6IFJlbW92ZWQgdGhlCisgICAgICAgIGFy Z3VtZW50IChmYWxzZSB3YXMgdGhlIGRlZmF1bHQgYW55d2F5KS4KKyAgICAgICAgKiBodG1sL0hU TUxGb3JtRWxlbWVudC5jcHA6IChXZWJDb3JlOjpIVE1MRm9ybUVsZW1lbnQ6OnN1Ym1pdCk6IEhh cmRjb2RlIGZhbHNlIHdoZW4gcGFzc2luZworICAgICAgICBsb2NrQmFja0ZvcndhcmRMaXN0IHRv IHN1Ym1pdEZvcm0oKS4KKyAgICAgICAgKiBodG1sL0hUTUxGb3JtRWxlbWVudC5oOiBSZW1vdmVk IHRoZSB1bm5lY2Vzc2FyeSBhcmd1bWVudC4KKwogMjAwOS0wNy0wOCAgQnJlbnQgRnVsZ2hhbSAg PGJmdWxnaGFtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQnVpbGQgZml4OiBBZGQgbWlzc2luZyAj aW5jbHVkZXMgZm9yIFdpbmRvd3MgKGNVUkwpIGJ1aWxkLgpJbmRleDogV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0hUTUxGb3JtRWxlbWVudEN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9i aW5kaW5ncy9qcy9KU0hUTUxGb3JtRWxlbWVudEN1c3RvbS5jcHAJKHJldmlzaW9uIDQ1NTk2KQor KysgV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxGb3JtRWxlbWVudEN1c3RvbS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTYyLDcgKzYyLDcgQEAgSlNWYWx1ZSBKU0hUTUxGb3JtRWxlbWVudDo6c3Vi bWl0KEV4ZWNTdAogICAgIEZyYW1lKiBhY3RpdmVGcmFtZSA9IGFzSlNET01XaW5kb3coZXhlYy0+ ZHluYW1pY0dsb2JhbE9iamVjdCgpKS0+aW1wbCgpLT5mcmFtZSgpOwogICAgIGlmICghYWN0aXZl RnJhbWUpCiAgICAgICAgIHJldHVybiBqc1VuZGVmaW5lZCgpOwotICAgIHN0YXRpY19jYXN0PEhU TUxGb3JtRWxlbWVudCo+KGltcGwoKSktPnN1Ym1pdCgwLCBmYWxzZSwgIWFjdGl2ZUZyYW1lLT5z Y3JpcHQoKS0+YW55UGFnZUlzUHJvY2Vzc2luZ1VzZXJHZXN0dXJlKCksIGZhbHNlKTsKKyAgICBz dGF0aWNfY2FzdDxIVE1MRm9ybUVsZW1lbnQqPihpbXBsKCkpLT5zdWJtaXQoMCwgZmFsc2UsICFh Y3RpdmVGcmFtZS0+c2NyaXB0KCktPmFueVBhZ2VJc1Byb2Nlc3NpbmdVc2VyR2VzdHVyZSgpKTsK ICAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKIH0KIApJbmRleDogV2ViQ29yZS9odG1sL0hUTUxG b3JtRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVu dC5jcHAJKHJldmlzaW9uIDQ1NTk2KQorKysgV2ViQ29yZS9odG1sL0hUTUxGb3JtRWxlbWVudC5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTMyOCw3ICszMjgsNyBAQCBzdGF0aWMgdm9pZCB0cmFuc2Zl ck1haWx0b1Bvc3RGb3JtRGF0YVRvCiAgICAgdXJsLnNldFF1ZXJ5KHF1ZXJ5KTsKIH0KIAotdm9p ZCBIVE1MRm9ybUVsZW1lbnQ6OnN1Ym1pdChFdmVudCogZXZlbnQsIGJvb2wgYWN0aXZhdGVTdWJt aXRCdXR0b24sIGJvb2wgbG9ja0hpc3RvcnksIGJvb2wgbG9ja0JhY2tGb3J3YXJkTGlzdCkKK3Zv aWQgSFRNTEZvcm1FbGVtZW50OjpzdWJtaXQoRXZlbnQqIGV2ZW50LCBib29sIGFjdGl2YXRlU3Vi bWl0QnV0dG9uLCBib29sIGxvY2tIaXN0b3J5KQogewogICAgIEZyYW1lVmlldyogdmlldyA9IGRv Y3VtZW50KCktPnZpZXcoKTsKICAgICBGcmFtZSogZnJhbWUgPSBkb2N1bWVudCgpLT5mcmFtZSgp OwpAQCAtMzg5LDE0ICszODksMTQgQEAgdm9pZCBIVE1MRm9ybUVsZW1lbnQ6OnN1Ym1pdChFdmVu dCogZXZlbgogICAgICAgICAgICAgICAgIG1fdXJsID0gdXJsLnN0cmluZygpOwogICAgICAgICAg ICAgfQogCi0gICAgICAgICAgICBmcmFtZS0+bG9hZGVyKCktPnN1Ym1pdEZvcm0oIlBPU1QiLCBt X3VybCwgZGF0YS5yZWxlYXNlKCksIG1fdGFyZ2V0LCBtX2Zvcm1EYXRhQnVpbGRlci5lbmNvZGlu Z1R5cGUoKSwgU3RyaW5nKCksIGxvY2tIaXN0b3J5LCBsb2NrQmFja0ZvcndhcmRMaXN0LCBldmVu dCwgZm9ybVN0YXRlLnJlbGVhc2UoKSk7CisgICAgICAgICAgICBmcmFtZS0+bG9hZGVyKCktPnN1 Ym1pdEZvcm0oIlBPU1QiLCBtX3VybCwgZGF0YS5yZWxlYXNlKCksIG1fdGFyZ2V0LCBtX2Zvcm1E YXRhQnVpbGRlci5lbmNvZGluZ1R5cGUoKSwgU3RyaW5nKCksIGxvY2tIaXN0b3J5LCBmYWxzZSwg ZXZlbnQsIGZvcm1TdGF0ZS5yZWxlYXNlKCkpOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAg ICAgVmVjdG9yPGNoYXI+IGJvdW5kYXJ5ID0gbV9mb3JtRGF0YUJ1aWxkZXIuZ2VuZXJhdGVVbmlx dWVCb3VuZGFyeVN0cmluZygpOwotICAgICAgICAgICAgZnJhbWUtPmxvYWRlcigpLT5zdWJtaXRG b3JtKCJQT1NUIiwgbV91cmwsIGNyZWF0ZUZvcm1EYXRhKGJvdW5kYXJ5LmRhdGEoKSksIG1fdGFy Z2V0LCBtX2Zvcm1EYXRhQnVpbGRlci5lbmNvZGluZ1R5cGUoKSwgYm91bmRhcnkuZGF0YSgpLCBs b2NrSGlzdG9yeSwgbG9ja0JhY2tGb3J3YXJkTGlzdCwgZXZlbnQsIGZvcm1TdGF0ZS5yZWxlYXNl KCkpOworICAgICAgICAgICAgZnJhbWUtPmxvYWRlcigpLT5zdWJtaXRGb3JtKCJQT1NUIiwgbV91 cmwsIGNyZWF0ZUZvcm1EYXRhKGJvdW5kYXJ5LmRhdGEoKSksIG1fdGFyZ2V0LCBtX2Zvcm1EYXRh QnVpbGRlci5lbmNvZGluZ1R5cGUoKSwgYm91bmRhcnkuZGF0YSgpLCBsb2NrSGlzdG9yeSwgZmFs c2UsIGV2ZW50LCBmb3JtU3RhdGUucmVsZWFzZSgpKTsKICAgICAgICAgfQogICAgIH0gZWxzZSB7 CiAgICAgICAgIG1fZm9ybURhdGFCdWlsZGVyLnNldElzTXVsdGlQYXJ0Rm9ybShmYWxzZSk7Ci0g ICAgICAgIGZyYW1lLT5sb2FkZXIoKS0+c3VibWl0Rm9ybSgiR0VUIiwgbV91cmwsIGNyZWF0ZUZv cm1EYXRhKENTdHJpbmcoKSksIG1fdGFyZ2V0LCBTdHJpbmcoKSwgU3RyaW5nKCksIGxvY2tIaXN0 b3J5LCBsb2NrQmFja0ZvcndhcmRMaXN0LCBldmVudCwgZm9ybVN0YXRlLnJlbGVhc2UoKSk7Cisg ICAgICAgIGZyYW1lLT5sb2FkZXIoKS0+c3VibWl0Rm9ybSgiR0VUIiwgbV91cmwsIGNyZWF0ZUZv cm1EYXRhKENTdHJpbmcoKSksIG1fdGFyZ2V0LCBTdHJpbmcoKSwgU3RyaW5nKCksIGxvY2tIaXN0 b3J5LCBmYWxzZSwgZXZlbnQsIGZvcm1TdGF0ZS5yZWxlYXNlKCkpOwogICAgIH0KIAogICAgIGlm IChuZWVkQnV0dG9uQWN0aXZhdGlvbiAmJiBmaXJzdFN1Y2Nlc3NmdWxTdWJtaXRCdXR0b24pCklu ZGV4OiBXZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9odG1sL0hUTUxGb3JtRWxlbWVudC5oCShyZXZpc2lvbiA0NTU5NikKKysrIFdlYkNvcmUvaHRt bC9IVE1MRm9ybUVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNzgsNyArNzgsNyBAQCBwdWJs aWM6CiAgICAgdm9pZCByZW1vdmVJbWdFbGVtZW50KEhUTUxJbWFnZUVsZW1lbnQqKTsKIAogICAg IGJvb2wgcHJlcGFyZVN1Ym1pdChFdmVudCopOwotICAgIHZvaWQgc3VibWl0KEV2ZW50KiA9IDAs IGJvb2wgYWN0aXZhdGVTdWJtaXRCdXR0b24gPSBmYWxzZSwgYm9vbCBsb2NrSGlzdG9yeSA9IGZh bHNlLCBib29sIGxvY2tCYWNrRm9yd2FyZExpc3QgPSBmYWxzZSk7CisgICAgdm9pZCBzdWJtaXQo RXZlbnQqID0gMCwgYm9vbCBhY3RpdmF0ZVN1Ym1pdEJ1dHRvbiA9IGZhbHNlLCBib29sIGxvY2tI aXN0b3J5ID0gZmFsc2UpOwogICAgIHZvaWQgcmVzZXQoKTsKIAogICAgIC8vIFVzZWQgdG8gaW5k aWNhdGUgYSBtYWxmb3JtZWQgc3RhdGUgdG8ga2VlcCBmcm9tIGFwcGx5aW5nIHRoZSBib3R0b20g bWFyZ2luIG9mIHRoZSBmb3JtLgo=