27089 2009-07-08 12:43:14 -0700 Fix V8 idl codegen to use unique constant names 2009-07-08 13:33:22 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 maruel webkit-unassigned abarth oldest_to_newest 130484 0 maruel 2009-07-08 12:43:14 -0700 Embed the interface name in the global constant names so coagulating all the .cc files into one compile unit works with V8 bindings. 130486 1 32466 maruel 2009-07-08 12:45:51 -0700 Created attachment 32466 Fix to use a DerivedSource.cpp-like cpp merger for v8 bindings 130493 2 32466 abarth 2009-07-08 13:28:18 -0700 Comment on attachment 32466 Fix to use a DerivedSource.cpp-like cpp merger for v8 bindings LGTM 130494 3 abarth 2009-07-08 13:33:22 -0700 Sending WebCore/ChangeLog Sending WebCore/bindings/scripts/CodeGeneratorV8.pm Transmitting file data .. Committed revision 45632. 32466 2009-07-08 12:45:51 -0700 2009-07-08 13:28:18 -0700 Fix to use a DerivedSource.cpp-like cpp merger for v8 bindings bug_27089.diff text/plain 2531 maruel SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTYzMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMDctMDggIE1hcmMtQW50b2luZSBSdWVsICA8bWFydWVsQGNo cm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXggVjggaWRsIGNvZGVnZW4gdG8gdXNlIHVuaXF1ZSBjb25zdGFudCBuYW1lcworICAg ICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3MDg5PgorCisg ICAgICAgIEVtYmVkIHRoZSBpbnRlcmZhY2UgbmFtZSBpbiB0aGUgZ2xvYmFsIGNvbnN0YW50IG5h bWVzIHNvIGNvYWd1bGF0aW5nIGFsbAorICAgICAgICB0aGUgLmNjIGZpbGVzIGludG8gb25lIGNv bXBpbGUgdW5pdCB3b3JrcyB3aXRoIFY4IGJpbmRpbmdzLgorCisgICAgICAgIE5vdGhpbmcgYWRk ZWQ7IFN0aWxsIGNvbXBpbGVzIGFuZCBwYXNzIHRlc3RzLgorCisgICAgICAgICogYmluZGluZ3Mv c2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisKIDIwMDktMDctMDggIEJyZW50IEZ1bGdoYW0g IDxiZnVsZ2hhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1aWxkIGZpeDogQWRkIG1pc3Npbmcg I2luY2x1ZGVzIGZvciBXaW5kb3dzIChjVVJMKSBidWlsZC4KSW5kZXg6IFdlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQkocmV2aXNpb24gNDU2MjcpCisrKyBXZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCSh3b3JraW5nIGNvcHkpCkBA IC0xMTc0LDcgKzExNzQsNyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgogICAgIG15ICRo YXNfYXR0cmlidXRlcyA9IDA7CiAgICAgaWYgKEAkYXR0cmlidXRlcykgewogICAgICAgICAkaGFz X2F0dHJpYnV0ZXMgPSAxOwotICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgInN0YXRpYyBjb25z dCBCYXRjaGVkQXR0cmlidXRlIGF0dHJzW10gPSB7XG4iKTsKKyAgICAgICAgcHVzaChAaW1wbENv bnRlbnQsICJzdGF0aWMgY29uc3QgQmF0Y2hlZEF0dHJpYnV0ZSAke2ludGVyZmFjZU5hbWV9X2F0 dHJzW10gPSB7XG4iKTsKICAgICAgICAgR2VuZXJhdGVCYXRjaGVkQXR0cmlidXRlRGF0YSgkaW50 ZXJmYWNlTmFtZSwgJGF0dHJpYnV0ZXMpOwogICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgIn07 XG4iKTsKICAgICB9CkBAIC0xMTgzLDcgKzExODMsNyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRh dGlvbgogICAgIG15ICRoYXNfY29uc3RhbnRzID0gMDsKICAgICBpZiAoQHskZGF0YU5vZGUtPmNv bnN0YW50c30pIHsKICAgICAgICAgJGhhc19jb25zdGFudHMgPSAxOwotICAgICAgICBwdXNoKEBp bXBsQ29udGVudCwgInN0YXRpYyBjb25zdCBCYXRjaGVkQ29uc3RhbnQgY29uc3RzW10gPSB7XG4i KTsKKyAgICAgICAgcHVzaChAaW1wbENvbnRlbnQsICJzdGF0aWMgY29uc3QgQmF0Y2hlZENvbnN0 YW50ICR7aW50ZXJmYWNlTmFtZX1fY29uc3RzW10gPSB7XG4iKTsKICAgICB9CiAgICAgZm9yZWFj aCBteSAkY29uc3RhbnQgKEB7JGRhdGFOb2RlLT5jb25zdGFudHN9KSB7CiAgICAgICAgIG15ICRu YW1lID0gJGNvbnN0YW50LT5uYW1lOwpAQCAtMTIzNCw3ICsxMjM0LDcgQEAgRU5ECiAgICAgIyBT ZXQgdXAgb3VyIGF0dHJpYnV0ZXMgaWYgd2UgaGF2ZSB0aGVtCiAgICAgaWYgKCRoYXNfYXR0cmli dXRlcykgewogICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgPDxFTkQpOwotICBiYXRjaENvbmZp Z3VyZUF0dHJpYnV0ZXMoaW5zdGFuY2UsIHByb3RvLCBhdHRycywgc2l6ZW9mKGF0dHJzKS9zaXpl b2YoKmF0dHJzKSk7CisgIGJhdGNoQ29uZmlndXJlQXR0cmlidXRlcyhpbnN0YW5jZSwgcHJvdG8s ICR7aW50ZXJmYWNlTmFtZX1fYXR0cnMsIHNpemVvZigke2ludGVyZmFjZU5hbWV9X2F0dHJzKS9z aXplb2YoKiR7aW50ZXJmYWNlTmFtZX1fYXR0cnMpKTsKIEVORAogICAgIH0KIApAQCAtMTMyOCw3 ICsxMzI4LDcgQEAgRU5ECiAKICAgICBpZiAoJGhhc19jb25zdGFudHMpIHsKICAgICAgICAgcHVz aChAaW1wbENvbnRlbnQsIDw8RU5EKTsKLSAgYmF0Y2hDb25maWd1cmVDb25zdGFudHMoZGVzYywg cHJvdG8sIGNvbnN0cywgc2l6ZW9mKGNvbnN0cykvc2l6ZW9mKCpjb25zdHMpKTsKKyAgYmF0Y2hD b25maWd1cmVDb25zdGFudHMoZGVzYywgcHJvdG8sICR7aW50ZXJmYWNlTmFtZX1fY29uc3RzLCBz aXplb2YoJHtpbnRlcmZhY2VOYW1lfV9jb25zdHMpL3NpemVvZigqJHtpbnRlcmZhY2VOYW1lfV9j b25zdHMpKTsKIEVORAogICAgIH0KIAo=