270883 2024-03-12 17:21:08 -0700 [UnifiedPDF] WebCore::DataDetectorHighlight should be decoupled from the page 2024-03-13 18:35:11 -0700 1 1 1 Unclassified WebKit PDF WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 a_protyasha a_protyasha a_protyasha thorton webkit-bug-importer oldest_to_newest 2020600 0 a_protyasha 2024-03-12 17:21:08 -0700 Currently, DataDetectorHighlight instances require a WebCore::Page object at construction time. This is inconvenient when trying to fit this data type into the UnifiedPDF Data Detection code paths. We should instead offload the work required from WebCore::Page to the DataDetectorHighlightClient virtual interface, which various overlay controllers can implement (and call into Page, if need be, for implementation support) 2020601 1 webkit-bug-importer 2024-03-12 17:21:16 -0700 <rdar://problem/124490748> 2020608 2 a_protyasha 2024-03-12 17:46:05 -0700 Pull request: https://github.com/WebKit/WebKit/pull/25799 2020897 3 ews-feeder 2024-03-13 18:35:09 -0700 Committed 276060@main (c4304291691c): <https://commits.webkit.org/276060@main> Reviewed commits have been landed. Closing PR #25799 and removing active labels.