270779 2024-03-10 21:57:11 -0700 Navigator.mediaDevices.getSupportedConstraints mistakenly reports torch as false. 2024-03-11 18:49:40 -0700 1 1 1 Unclassified WebKit WebRTC Safari 17 Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=169871 BrowserCompat, InRadar P2 Normal --- 1 shawnlee webkit-unassigned karlcow webkit-bug-importer youennf oldest_to_newest 2020014 0 shawnlee 2024-03-10 21:57:11 -0700 demo : https://sy74yv.csb.app/ It will show the result of getSupportedConstraints. {"aspectRatio":true "deviceId":true "displaySurface":true "echoCancellation":true "facingMode":true "frameRate":true "groupId":false "height":true "sampleRate":false "sampleSize":false "torch":false "volume":true "whiteBalanceMode":true "width":true "zoom":true}{"aspectRatio":true "deviceId":true "displaySurface":true "echoCancellation":true "facingMode":true "frameRate":true "groupId":false "height":true "sampleRate":false "sampleSize":false "torch":false "volume":true "whiteBalanceMode":true "width":true "zoom":true} Tested on iphone 13 pro, 16.4 According to https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getSupportedConstraints, only constraints supported by the user agent are included in the list, each of these Boolean properties has the value true. 2020019 1 karlcow 2024-03-10 23:35:54 -0700 Thanks Shawn! Let's head to the spec, instead of MDN. https://w3c.github.io/mediacapture-main/#dom-mediadevices-getsupportedconstraints getSupportedConstraints Returns a dictionary whose members are the constrainable properties known to the User Agent. * A supported constrainable property MUST be represented * AND any constrainable properties not supported by the User Agent MUST NOT be present in the returned dictionary. * The values returned represent what the User Agent implements and will not change during a browsing session. Safari on desktop reports WRONGFULLY: "groupId":false "sampleRate":false "sampleSize":false "torch":false So indeed there is a bug here. That looks like an easy fix https://searchfox.org/wubkat/rev/c67bb750f2c1083399f0dbe7d08b416cd45eee34/Source/WebCore/Modules/mediastream/MediaDevices.cpp#363-383 Where the value is added to result only if the value is true. In more details: On STP 190 {"aspectRatio":true "deviceId":true "displaySurface":true "echoCancellation":true "facingMode":true "frameRate":true "groupId":false "height":true "sampleRate":false "sampleSize":false "torch":false "volume":true "whiteBalanceMode":true "width":true "zoom":true} On Firefox Nightly 125.0a1 (2024-03-10) (64-bit) {"autoGainControl":true "browserWindow":true "channelCount":true "deviceId":true "echoCancellation":true "facingMode":true "frameRate":true "groupId":true "height":true "mediaSource":true "noiseSuppression":true "scrollWithPage":true "viewportHeight":true "viewportOffsetX":true "viewportOffsetY":true "viewportWidth":true "width":true} On Chrome Canary Version 124.0.6350.0 {"aspectRatio":true "autoGainControl":true "brightness":true "channelCount":true "colorTemperature":true "contrast":true "deviceId":true "displaySurface":true "echoCancellation":true "exposureCompensation":true "exposureMode":true "exposureTime":true "facingMode":true "focusDistance":true "focusMode":true "frameRate":true "groupId":true "height":true "iso":true "latency":true "noiseSuppression":true "pan":true "pointsOfInterest":true "resizeMode":true "sampleRate":true "sampleSize":true "saturation":true "sharpness":true "suppressLocalAudioPlayback":true "tilt":true "torch":true "voiceIsolation":true "whiteBalanceMode":true "width":true "zoom":true} 2020020 2 webkit-bug-importer 2024-03-10 23:36:02 -0700 <rdar://problem/124372654> 2020021 3 karlcow 2024-03-11 00:01:50 -0700 I may have a quick patch for this. 2020057 4 karlcow 2024-03-11 05:18:59 -0700 After chatting with Youenn, there's some part that could be better optimized. With probably removing `RealtimeMediaSourceCenter::supportedConstraints` 2020062 5 karlcow 2024-03-11 05:24:10 -0700 The WebIDL in the spec is defined as partial interface MediaDevices { MediaTrackSupportedConstraints getSupportedConstraints(); Promise<MediaStream> getUserMedia(optional MediaStreamConstraints constraints = {}); }; Also https://searchfox.org/wubkat/source/Source/WebCore/Modules/mediastream/MediaStreamTrack.idl and bug 169871 2020287 6 karlcow 2024-03-11 17:11:49 -0700 The PR is in https://github.com/WebKit/WebKit/pull/25712 2020330 7 ews-feeder 2024-03-11 18:49:38 -0700 Committed 275945@main (8153861f277e): <https://commits.webkit.org/275945@main> Reviewed commits have been landed. Closing PR #25712 and removing active labels.