270776 2024-03-10 19:03:55 -0700 [Skia] libSkia.a is always considered outdated 2024-04-26 04:55:58 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=273315 P2 Normal --- 268972 1 pgriffis aperez aperez bugs-noreply webkit-bug-importer oldest_to_newest 2019990 0 pgriffis 2024-03-10 19:03:55 -0700 If you run: `ninja -d explain -C WebKitBuild/WPE/Debug libSkia.a` It outputs: ninja explain: output Source/ThirdParty/skia/CMakeFiles/Skia_headers_symlink doesn't exist ninja explain: Source/ThirdParty/skia/CMakeFiles/Skia_headers_symlink is dirty ninja explain: Skia/Headers/skia is dirty [1/1] Link Skia headers This causes every single build to relink Skia and everything that depends on it. Currently this is defined in CMake as: add_custom_target(Skia_headers_symlink COMMAND ${CMAKE_COMMAND} -E create_symlink "${CMAKE_CURRENT_SOURCE_DIR}/include" "${Skia_FRAMEWORK_HEADERS_DIR}/skia" BYPRODUCTS "${Skia_FRAMEWORK_HEADERS_DIR}/skia" COMMENT "Link Skia headers" ) add_dependencies(Skia Skia_headers_symlink) I'm not sure what the proper solution to this is. 2030487 1 aperez 2024-04-23 01:42:04 -0700 I think we may be able to use a POST_BUILD custom command to generate the symlink after libSkia.a is built *without* having the build system consider that the library is always outdated. Let me give it a try. 2030488 2 aperez 2024-04-23 01:48:45 -0700 Pull request: https://github.com/WebKit/WebKit/pull/27620 2030490 3 ews-feeder 2024-04-23 02:01:25 -0700 Committed 277860@main (c48d5a8a6a38): <https://commits.webkit.org/277860@main> Reviewed commits have been landed. Closing PR #27620 and removing active labels.