270699 2024-03-08 07:30:20 -0800 [JSC] Add arbitrary label alignment functionality to offlineasm 2024-04-08 13:45:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All Unspecified REOPENED InRadar P2 Normal --- 271065 1 maximilian webkit-unassigned commit-queue justin_michaud mark.lam webkit-bug-importer oldest_to_newest 2019614 0 maximilian 2024-03-08 07:30:20 -0800 To express some programs like the InPlaceInterpreter we need to align instructions to specific boundaries (such as 256). We currently to do this via `emit ".balign 256, 0xcc"' (for instance) but this is not reliable on armv7 as its globaladdr implementation can insert code unpredictably (from the point of view of the offlineasm user), hence breaking the alignment. We should add functionality in offlineasm to address this usecase reliably. Possibly related to rdar://113594783 2020991 1 ews-feeder 2024-03-14 06:01:23 -0700 Committed 276085@main (71f803e6ee62): <https://commits.webkit.org/276085@main> Reviewed commits have been landed. Closing PR #25628 and removing active labels. 2020992 2 webkit-bug-importer 2024-03-14 06:02:15 -0700 <rdar://problem/124613758> 2021383 3 commit-queue 2024-03-15 10:41:36 -0700 Re-opened since this is blocked by bug 271065 2026147 4 mark.lam 2024-04-04 17:43:04 -0700 rdar://113594783 2026149 5 mark.lam 2024-04-04 17:44:00 -0700 *** Bug 272200 has been marked as a duplicate of this bug. *** 2026150 6 mark.lam 2024-04-04 17:47:40 -0700 Pull request for re-land: https://github.com/WebKit/WebKit/pull/26877 2026355 7 ews-feeder 2024-04-05 13:15:43 -0700 Committed 277134@main (75713dba1787): <https://commits.webkit.org/277134@main> Reviewed commits have been landed. Closing PR #26877 and removing active labels. 2026839 8 ews-feeder 2024-04-08 13:27:18 -0700 Committed 277212@main (885441cde700): <https://commits.webkit.org/277212@main> Reviewed commits have been landed. Closing PR #26986 and removing active labels. 2026843 9 mark.lam 2024-04-08 13:33:38 -0700 We're going to revert this because it's causing crashes. 2026932 10 mark.lam 2024-04-08 13:45:46 -0700 This was reverted by Justin Michaud in https://commits.webkit.org/277212@main.