270689 2024-03-08 03:02:36 -0800 [WPE] [LibWebRTC] Fix build for ARM 32-bit 2024-03-11 11:38:12 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino dpino webkit-bug-importer oldest_to_newest 2019571 0 dpino 2024-03-08 03:02:36 -0800 When building WPE with build flag `--cmakeargs=-DUSE_GSTREAMER_WEBRTC=FALSE` (enables LibWebRTC) on ARM 32-bit, I got the following build error: ``` In file included from /home/dpino/WPEWebKit/Source/ThirdParty/libwebrtc/Source/third_party/pffft/src/pffft.c:155: /home/dpino/WPEWebKit/Source/ThirdParty/libwebrtc/Source/third_party/pffft/src/pffft.c: In function ‘passf2_ps’: /usr/lib/gcc/arm-linux-gnueabihf/11/include/arm_neon.h:1957:1: error: inlining failed in call to ‘always_inline’ ‘vsubq_f32’: target specific option mismatch 1957 | vsubq_f32 (float32x4_t a, float32x4_t b) ``` This build error also happens in other files such as: Source/webrtc/modules/audio_processing/aec3/adaptive_fir_filter.cc Source/webrtc/modules/audio_processing/aec3/adaptive_fir_filter_erl.cc Source/webrtc/modules/audio_processing/aec3/comfort_noise_generator.cc Source/webrtc/modules/audio_processing/aec3/matched_filter.cc Source/webrtc/modules/audio_processing/aec3/suppression_filter.cc Source/webrtc/modules/audio_processing/aec3/suppression_gain.cc These files need to be explicitly set with build flags "-mfpu=neon -mfloat-abi=hard". See: - Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/aec3/BUILD.gn - Source/ThirdParty/libwebrtc/Source/third_party/pffft/README.txt 2019576 1 dpino 2024-03-08 03:08:54 -0800 Pull request: https://github.com/webkit/webkit/pull/25620 2020189 2 ews-feeder 2024-03-11 11:37:54 -0700 Committed 275915@main (565848432d81): <https://commits.webkit.org/275915@main> Reviewed commits have been landed. Closing PR #25620 and removing active labels. 2020190 3 webkit-bug-importer 2024-03-11 11:38:12 -0700 <rdar://problem/124399531>