27059 2009-07-07 19:18:11 -0700 Exclude Symbian platform from define of MIDDLE_ENDIAN 2009-08-06 21:11:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) S60 Emulator S60 3rd edition RESOLVED FIXED P2 Normal --- 27065 0 norbert.leser webkit-unassigned abarth eric hausmann laszlo.gombos mjs yongjun.zhang oldest_to_newest 130341 0 32418 norbert.leser 2009-07-07 19:18:11 -0700 Created attachment 32418 Code patch for Platform.h The proposed patch adds !PLATFORM(SYMBIAN) tpo prevent it from entering the conditional code block that defines WTF_PLATFORM_MIDDLE_ENDIAN=1. 131088 1 32418 eric 2009-07-10 23:17:06 -0700 Comment on attachment 32418 Code patch for Platform.h Why? PLATFORM(SYMBIAN) seems the wrong level of define to be using here. 137451 2 34180 norbert.leser 2009-08-05 15:00:06 -0700 Created attachment 34180 Update of patch file for bug #27059 I updated the patch according to the review comment. Instead of adding a !SYMBIAN condition to the already hard to decipher negative conditional clause within the ARM block, I added the proper __ARM_EABI__ flag to the SYMBIAN case. In addition, I cleaned up the condition of the else branch in the ARM block (removed redundant condition check). 137484 3 34180 darin 2009-08-05 16:45:11 -0700 Comment on attachment 34180 Update of patch file for bug #27059 Seems unfortunate to define something that begins with two underscores, since that's supposed to be reserved for the environment, not the library. 137595 4 34212 norbert.leser 2009-08-06 10:32:09 -0700 Created attachment 34212 2nd update of patch file for bug #27059 I agree with Darin'd comment of trying to avoid redefining variables with beginning double underscores in the library code. How about this updated patch: Since on Symbian, we detect the __EABI__ variable but not __ARM_EABI__, I simply added that flag to the respective (negative) conditional statements. It's only in 2 places and I assume it is safe for any other platforms that may or may not have this flag set. 137613 5 34216 norbert.leser 2009-08-06 11:58:35 -0700 Created attachment 34216 3rd update of patch file for bug #27059 Fixed a typo (superfluous spaces) - otherwise same as patch platform_h_bug_27059_3.txt 137780 6 34216 abarth 2009-08-06 21:11:09 -0700 Comment on attachment 34216 3rd update of patch file for bug #27059 Clearing review flag on attachment: 34216 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/Platform.h Committed r46881 M JavaScriptCore/wtf/Platform.h M JavaScriptCore/ChangeLog r46881 = 5dc259f3deb7d16009ef6a9c9d0573db54f74cc4 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46881 137781 7 abarth 2009-08-06 21:11:14 -0700 All reviewed patches have been landed. Closing bug. 32418 2009-07-07 19:18:11 -0700 2009-08-05 15:00:06 -0700 Code patch for Platform.h patch_Platform_h_2.txt text/plain 1063 norbert.leser SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gNDU2 MTApCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0w Ny0wNyAgTm9yYmVydCBMZXNlciAgPG5vcmJlcnQubGVzZXJAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV4Y2x1ZGUgU3ltYmlhbiBw bGF0Zm9ybSBmcm9tIGRlZmluZSBvZgorICAgICAgICBXVEZfUExBVEZPUk1fTUlERExFX0VORElB TgorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmg6CisKIDIwMDktMDct MDMgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgWGFuIExvcGV6IGFuZCBHdXN0YXZvIE5vcm9uaGEuCkluZGV4OiBKYXZhU2Ny aXB0Q29yZS93dGYvUGxhdGZvcm0uaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIEphdmFTY3JpcHRDb3JlL3d0 Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiA0NTYxMCkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0 Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMjEsNyArMjIxLDcgQEAKICNkZWZpbmUgV1RGX1BM QVRGT1JNX0FSTSAxCiAjaWYgZGVmaW5lZChfX0FSTUVCX18pCiAjZGVmaW5lIFdURl9QTEFURk9S TV9CSUdfRU5ESUFOIDEKLSNlbGlmICFkZWZpbmVkKF9fQVJNX0VBQklfXykgJiYgIWRlZmluZWQo X19BUk1FQl9fKSAmJiAhZGVmaW5lZChfX1ZGUF9GUF9fKQorI2VsaWYgIWRlZmluZWQoX19BUk1f RUFCSV9fKSAmJiAhZGVmaW5lZChfX0FSTUVCX18pICYmICFkZWZpbmVkKF9fVkZQX0ZQX18pICYm ICFQTEFURk9STShTWU1CSUFOKQogI2RlZmluZSBXVEZfUExBVEZPUk1fTUlERExFX0VORElBTiAx CiAjZW5kaWYKICNpZiAhZGVmaW5lZChfX0FSTV9FQUJJX18pCg== 34180 2009-08-05 15:00:06 -0700 2009-08-06 10:32:09 -0700 Update of patch file for bug #27059 platform_h_bug_27059_2.txt text/plain 1366 norbert.leser SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIEphdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNDY4MTYpCisrKyBKYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOC0wNSAgTm9yYmVy dCBMZXNlciAgPG5vcmJlcnQubGVzZXJAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZWQgcGF0Y2ggZm9yIGJ1ZyAjMjcwNTk6 CisgICAgICAgIFN5bWJpYW4gcGxhdGZvcm0gYWx3YXlzIHVzZXMgbGl0dGxlIGVuZGlhbiBlbmNv ZGluZywKKyAgICAgICAgcmVnYXJkbGVzcyBvZiBjb21waWxlci4KKyAgICAgICAgV2UgbmVlZCB0 byBtYWtlIHN1cmUgdGhhdCB3ZSBjb3JyZWN0bHkgZGV0ZWN0IEVBQkkgYXJjaGl0ZWN0dXJlCisg ICAgICAgIGZvciBhcm12NSB0YXJnZXRzIG9uIFN5bWJpYW4uCisKKyAgICAgICAgKiB3dGYvUGxh dGZvcm0uaDoKKwogMjAwOS0wOC0wNCAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBh cHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyIFN0YW1wZWQgYnkgT2l2ZXIgSHVudC4KSW5kZXg6 IEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oDQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gSmF2YVNjcmlw dENvcmUvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDQ2ODEzKQorKysgSmF2YVNjcmlwdENvcmUv d3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTk4LDYgKzk4LDkgQEAKICN1bmRlZiBX VEZfUExBVEZPUk1fV0lOX09TCiAjdW5kZWYgV1RGX1BMQVRGT1JNX1dJTgogI2RlZmluZSBXVEZf UExBVEZPUk1fU1lNQklBTiAxCisjaWYgZGVmaW5lZCAoX19FQUJJX18pCisjZGVmaW5lIF9fQVJN X0VBQklfXworI2VuZGlmCiAjZW5kaWYKIAogCkBAIC0yMjAsNyArMjIzLDcgQEAKICNkZWZpbmUg V1RGX1BMQVRGT1JNX0FSTSAxCiAjaWYgZGVmaW5lZChfX0FSTUVCX18pCiAjZGVmaW5lIFdURl9Q TEFURk9STV9CSUdfRU5ESUFOIDEKLSNlbGlmICFkZWZpbmVkKF9fQVJNX0VBQklfXykgJiYgIWRl ZmluZWQoX19BUk1FQl9fKSAmJiAhZGVmaW5lZChfX1ZGUF9GUF9fKQorI2VsaWYgIWRlZmluZWQo X19BUk1fRUFCSV9fKSAmJiAhZGVmaW5lZChfX1ZGUF9GUF9fKQogI2RlZmluZSBXVEZfUExBVEZP Uk1fTUlERExFX0VORElBTiAxCiAjZW5kaWYKICNpZiAhZGVmaW5lZChfX0FSTV9FQUJJX18pCg== 34212 2009-08-06 10:32:09 -0700 2009-08-06 11:58:35 -0700 2nd update of patch file for bug #27059 platform_h_bug_27059_3.txt text/plain 1390 norbert.leser SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIEphdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNDY4NTApCisrKyBKYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOC0wNiAgTm9yYmVy dCBMZXNlciAgPG5vcmJlcnQubGVzZXJAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZWQgcGF0Y2ggZm9yIGJ1ZyAjMjcwNTk6 CisgICAgICAgIFN5bWJpYW4gcGxhdGZvcm0gYWx3YXlzIHVzZXMgbGl0dGxlIGVuZGlhbiBlbmNv ZGluZywKKyAgICAgICAgcmVnYXJkbGVzcyBvZiBjb21waWxlci4KKyAgICAgICAgV2UgbmVlZCB0 byBtYWtlIHN1cmUgdGhhdCB3ZSBjb3JyZWN0bHkgZGV0ZWN0IEVBQkkgYXJjaGl0ZWN0dXJlCisg ICAgICAgIGZvciBhcm12NSB0YXJnZXRzIG9uIFN5bWJpYW4sCisgICAgICAgIHdoZXJlIF9fRUFC SV9fIGlzIHNldCBidXQgbm90IF9fQVJNX0VBQklfXworCisgICAgICAgICogd3RmL1BsYXRmb3Jt Lmg6CisKIDIwMDktMDgtMDUgIFpvbHRhbiBIb3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQu aHU+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBKYXZhU2NyaXB0 Q29yZS93dGYvUGxhdGZvcm0uaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9Q bGF0Zm9ybS5oCShyZXZpc2lvbiA0Njg0NykKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9y bS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMjAsMTAgKzIyMCwxMCBAQAogI2RlZmluZSBXVEZfUExB VEZPUk1fQVJNIDEKICNpZiBkZWZpbmVkKF9fQVJNRUJfXykKICNkZWZpbmUgV1RGX1BMQVRGT1JN X0JJR19FTkRJQU4gMQotI2VsaWYgIWRlZmluZWQoX19BUk1fRUFCSV9fKSAmJiAhZGVmaW5lZChf X0FSTUVCX18pICYmICFkZWZpbmVkKF9fVkZQX0ZQX18pCisjZWxpZiAhZGVmaW5lZChfX0FSTV9F QUJJX18pICYmICFkZWZpbmVkIChfX0VBQklfXykgJiYgIWRlZmluZWQoX19WRlBfRlBfXykKICNk ZWZpbmUgV1RGX1BMQVRGT1JNX01JRERMRV9FTkRJQU4gMQogI2VuZGlmCi0jaWYgIWRlZmluZWQo X19BUk1fRUFCSV9fKQorI2lmICFkZWZpbmVkKF9fQVJNX0VBQklfXykgJiYgIWRlZmluZWQgKF9f RUFCSV9fKQogI2RlZmluZSBXVEZfUExBVEZPUk1fRk9SQ0VfUEFDSyAxCiAjZW5kaWYKICNkZWZp bmUgQVJNX0FSQ0hfVkVSU0lPTiAzCg== 34216 2009-08-06 11:58:35 -0700 2009-08-06 21:11:08 -0700 3rd update of patch file for bug #27059 platform_h_bug_27059_4.txt text/plain 1384 norbert.leser SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2ODUwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDgtMDYgIE5vcmJlcnQg TGVzZXIgIDxub3JiZXJ0Lmxlc2VyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGVkIHBhdGNoIGZvciBidWcgIzI3MDU5Ogor ICAgICAgICBTeW1iaWFuIHBsYXRmb3JtIGFsd2F5cyB1c2VzIGxpdHRsZSBlbmRpYW4gZW5jb2Rp bmcsCisgICAgICAgIHJlZ2FyZGxlc3Mgb2YgY29tcGlsZXIuCisgICAgICAgIFdlIG5lZWQgdG8g bWFrZSBzdXJlIHRoYXQgd2UgY29ycmVjdGx5IGRldGVjdCBFQUJJIGFyY2hpdGVjdHVyZQorICAg ICAgICBmb3IgYXJtdjUgdGFyZ2V0cyBvbiBTeW1iaWFuLAorICAgICAgICB3aGVyZSBfX0VBQklf XyBpcyBzZXQgYnV0IG5vdCBfX0FSTV9FQUJJX18KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5o OgorCiAyMDA5LTA4LTA1ICBab2x0YW4gSG9ydmF0aCAgPGh6b2x0YW5AaW5mLnUtc3plZ2VkLmh1 PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogSmF2YVNjcmlwdENv cmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRm b3JtLmgJKHJldmlzaW9uIDQ2ODQ3KQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJ KHdvcmtpbmcgY29weSkKQEAgLTIyMCwxMCArMjIwLDEwIEBACiAjZGVmaW5lIFdURl9QTEFURk9S TV9BUk0gMQogI2lmIGRlZmluZWQoX19BUk1FQl9fKQogI2RlZmluZSBXVEZfUExBVEZPUk1fQklH X0VORElBTiAxCi0jZWxpZiAhZGVmaW5lZChfX0FSTV9FQUJJX18pICYmICFkZWZpbmVkKF9fQVJN RUJfXykgJiYgIWRlZmluZWQoX19WRlBfRlBfXykKKyNlbGlmICFkZWZpbmVkKF9fQVJNX0VBQklf XykgJiYgIWRlZmluZWQoX19FQUJJX18pICYmICFkZWZpbmVkKF9fVkZQX0ZQX18pCiAjZGVmaW5l IFdURl9QTEFURk9STV9NSURETEVfRU5ESUFOIDEKICNlbmRpZgotI2lmICFkZWZpbmVkKF9fQVJN X0VBQklfXykKKyNpZiAhZGVmaW5lZChfX0FSTV9FQUJJX18pICYmICFkZWZpbmVkKF9fRUFCSV9f KQogI2RlZmluZSBXVEZfUExBVEZPUk1fRk9SQ0VfUEFDSyAxCiAjZW5kaWYKICNkZWZpbmUgQVJN X0FSQ0hfVkVSU0lPTiAzCg==