270556 2024-03-05 20:06:01 -0800 [IFC][Subpixel] Do not mix float and LayoutUnit types in RenderText::positionForPoint 2024-03-06 08:37:14 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan mmaxfield pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 2018957 0 zalan 2024-03-05 20:06:01 -0800 ssia 2018961 1 470192 zalan 2024-03-05 20:20:10 -0800 Created attachment 470192 [fast-cq]Patch 2019067 2 ews-feeder 2024-03-06 08:36:08 -0800 Committed 275741@main (5c97e0d70826): <https://commits.webkit.org/275741@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 470192. 2019068 3 webkit-bug-importer 2024-03-06 08:37:14 -0800 <rdar://problem/124143560> 470192 2024-03-05 20:20:10 -0800 2024-03-06 08:36:10 -0800 [fast-cq]Patch bug-270556-20240305202009.patch text/plain 3568 zalan RnJvbSAxNDQ5NzRkOGQ1ZTkzYzI1ODc4MzE3ZDZjMjY0ODRlMmQ0ZWJjYjBjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFR1ZSwgNSBNYXIgMjAyNCAyMDowNjoxOCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFtJRkNdW1N1 YnBpeGVsXSBEbyBub3QgbWl4IGZsb2F0IGFuZCBMYXlvdXRVbml0IHR5cGVzIGluCiBSZW5kZXJU ZXh0Ojpwb3NpdGlvbkZvclBvaW50IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNzA1NTYKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKVGhpcyBpcyBpbiBwcmVw YXJhdGlvbiBmb3IgcmVtb3ZpbmcgaW50ZWdyYWwgdmVydGljYWwgc25hcHBpbmcuCgpDb21wYXJp bmcgdGhlIGluY29taW5nIExheW91dFVuaXQgeyBwb2ludEJsb2NrRGlyZWN0aW9uIH0gYWdhaW5z dCB0aGUgZmxvYXQgeyBsaW5lIGJvdHRvbSB9IHByb3ZpZGVzIHRoZSBleHBlY3RlZCBsaW5lIHJh bmdlCmFzIGxvbmcgYXMgdGhlc2UgdmFsdWVzIGFyZSBib3RoIHNuYXBwZWQgdG8gaW50ZWdyYWwg cGl4ZWwgdmFsdWVzIChhcyB0aGUgcmVzdWx0IG9mIGludGVncmFsIGJhc2VkICh2ZXJ0aWNhbCkg bGluZSBsYXlvdXQpLApidXQgb25jZSB0aGUgc25hcHBpbmcgaXMgcmVtb3ZlZCwgdGhpcyBpbmNv bWluZyAoYW5kIGltcGxpY2l0bHkgZmxvb3JlZCBmbG9hdCB3aGVuIGNvbnZlcnRlZCB0byBMYXlv dXRVbml0KSB2YWx1ZSBtYXkgbm90IGZhbGwgaW50byB0aGUgZXhwZWN0ZWQgKG5vbi1zbmFwcGVk KSBsaW5lIHJhbmdlLgpMZXQncyB1c2UgdGhlIHNhbWUgdHlwZSAod2l0aCB0aGUgc2FtZSByb3Vu ZGluZyBzdHJhdGVneSkgdG8gZmluZCAicG9zaXRpb24gZm9yIHBvaW50Ii4KCiogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQuY3BwOgooV2ViQ29yZTo6UmVuZGVyVGV4dDo6cG9z aXRpb25Gb3JQb2ludCk6Ci0tLQogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRleHQu Y3BwIHwgMTAgKysrKystLS0tLQogMSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNSBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAKaW5kZXgg Yjc0NjAxOWNlZmNjLi5hZDcxZTZjZjFiYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGV4dC5jcHAKQEAgLTgxMyw4ICs4MTMsOCBAQCBWaXNpYmxlUG9zaXRpb24gUmVuZGVyVGV4 dDo6cG9zaXRpb25Gb3JQb2ludChjb25zdCBMYXlvdXRQb2ludCYgcG9pbnQsIGNvbnN0IFJlbgog ICAgIGlmICghZmlyc3RSdW4gfHwgIXRleHQoKS5sZW5ndGgoKSkKICAgICAgICAgcmV0dXJuIGNy ZWF0ZVZpc2libGVQb3NpdGlvbigwLCBBZmZpbml0eTo6RG93bnN0cmVhbSk7CiAKLSAgICBMYXlv dXRVbml0IHBvaW50TGluZURpcmVjdGlvbiA9IGZpcnN0UnVuLT5pc0hvcml6b250YWwoKSA/IHBv aW50LngoKSA6IHBvaW50LnkoKTsKLSAgICBMYXlvdXRVbml0IHBvaW50QmxvY2tEaXJlY3Rpb24g PSBmaXJzdFJ1bi0+aXNIb3Jpem9udGFsKCkgPyBwb2ludC55KCkgOiBwb2ludC54KCk7CisgICAg YXV0byBwb2ludExpbmVEaXJlY3Rpb24gPSBmaXJzdFJ1bi0+aXNIb3Jpem9udGFsKCkgPyBwb2lu dC54KCkgOiBwb2ludC55KCk7CisgICAgYXV0byBwb2ludEJsb2NrRGlyZWN0aW9uID0gZmlyc3RS dW4tPmlzSG9yaXpvbnRhbCgpID8gcG9pbnQueSgpIDogcG9pbnQueCgpOwogICAgIGJvb2wgYmxv Y2tzQXJlRmxpcHBlZCA9IHN0eWxlKCkuaXNGbGlwcGVkQmxvY2tzV3JpdGluZ01vZGUoKTsKIAog ICAgIElubGluZUl0ZXJhdG9yOjpUZXh0Qm94SXRlcmF0b3IgbGFzdFJ1bjsKQEAgLTgyNSwxNSAr ODI1LDE1IEBAIFZpc2libGVQb3NpdGlvbiBSZW5kZXJUZXh0Ojpwb3NpdGlvbkZvclBvaW50KGNv bnN0IExheW91dFBvaW50JiBwb2ludCwgY29uc3QgUmVuCiAgICAgICAgIGF1dG8gbGluZUJveCA9 IHJ1bi0+bGluZUJveCgpOwogICAgICAgICBhdXRvIHRvcCA9IExheW91dFVuaXQgeyBzdGQ6Om1p bihwcmV2aW91c0xpbmVCb3hDb250ZW50Qm90dG9tT3JCb3JkZXJBbmRQYWRkaW5nKCpsaW5lQm94 KSwgbGluZUJveC0+Y29udGVudExvZ2ljYWxUb3AoKSkgfTsKICAgICAgICAgaWYgKHBvaW50Qmxv Y2tEaXJlY3Rpb24gPiB0b3AgfHwgKCFibG9ja3NBcmVGbGlwcGVkICYmIHBvaW50QmxvY2tEaXJl Y3Rpb24gPT0gdG9wKSkgewotICAgICAgICAgICAgYXV0byBib3R0b20gPSBMaW5lU2VsZWN0aW9u Ojpsb2dpY2FsQm90dG9tKCpsaW5lQm94KTsKKyAgICAgICAgICAgIGF1dG8gYm90dG9tID0gTGF5 b3V0VW5pdCB7IExpbmVTZWxlY3Rpb246OmxvZ2ljYWxCb3R0b20oKmxpbmVCb3gpIH07CiAgICAg ICAgICAgICBpZiAoYXV0byBuZXh0TGluZUJveCA9IGxpbmVCb3gtPm5leHQoKSkKLSAgICAgICAg ICAgICAgICBib3R0b20gPSBzdGQ6Om1pbihib3R0b20sIG5leHRMaW5lQm94LT5jb250ZW50TG9n aWNhbFRvcCgpKTsKKyAgICAgICAgICAgICAgICBib3R0b20gPSBzdGQ6Om1pbihib3R0b20sIExh eW91dFVuaXQgeyBuZXh0TGluZUJveC0+Y29udGVudExvZ2ljYWxUb3AoKSB9KTsKIAogICAgICAg ICAgICAgaWYgKHBvaW50QmxvY2tEaXJlY3Rpb24gPCBib3R0b20gfHwgKGJsb2Nrc0FyZUZsaXBw ZWQgJiYgcG9pbnRCbG9ja0RpcmVjdGlvbiA9PSBib3R0b20pKSB7CiAgICAgICAgICAgICAgICAg U2hvdWxkQWZmaW5pdHlCZURvd25zdHJlYW0gc2hvdWxkQWZmaW5pdHlCZURvd25zdHJlYW07CiAj aWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKICAgICAgICAgICAgICAgICBpZiAocG9pbnRMaW5lRGly ZWN0aW9uICE9IHJ1bi0+bG9naWNhbExlZnRJZ25vcmluZ0lubGluZURpcmVjdGlvbigpICYmIHBv aW50LngoKSA8IHJ1bi0+dmlzdWFsUmVjdElnbm9yaW5nQmxvY2tEaXJlY3Rpb24oKS54KCkgKyBy dW4tPmxvZ2ljYWxXaWR0aCgpKSB7Ci0gICAgICAgICAgICAgICAgICAgIGludCBoYWxmID0gcnVu LT52aXN1YWxSZWN0SWdub3JpbmdCbG9ja0RpcmVjdGlvbigpLngoKSArIHJ1bi0+bG9naWNhbFdp ZHRoKCkgLyAyOworICAgICAgICAgICAgICAgICAgICBhdXRvIGhhbGYgPSBMYXlvdXRVbml0IHsg cnVuLT52aXN1YWxSZWN0SWdub3JpbmdCbG9ja0RpcmVjdGlvbigpLngoKSArIHJ1bi0+bG9naWNh bFdpZHRoKCkgLyAyLmYgfTsKICAgICAgICAgICAgICAgICAgICAgYXV0byBhZmZpbml0eSA9IHBv aW50LngoKSA8IGhhbGYgPyBBZmZpbml0eTo6RG93bnN0cmVhbSA6IEFmZmluaXR5OjpVcHN0cmVh bTsKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGNyZWF0ZVZpc2libGVQb3NpdGlvbihvZmZz ZXRGb3JQb3NpdGlvbkluUnVuKCpydW4sIHBvaW50TGluZURpcmVjdGlvbikgKyBydW4tPnN0YXJ0 KCksIGFmZmluaXR5KTsKICAgICAgICAgICAgICAgICB9Cg==