270507 2024-03-04 22:47:06 -0800 Guide outside contributors to use run-minibrowser rather than run-safari 2024-03-11 23:48:13 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=236968 InRadar P2 Normal --- 1 mike mike webkit-bug-importer oldest_to_newest 2018694 0 mike 2024-03-04 22:47:06 -0800 Outside (non-Apple) contributors who aren’t building with the Apple Internal SDK — even those building on macOS — should be guided to use the run-minibrowser script rather than the run-safari script. But unless the contributor is building the GTK or WPE port, the current build-webkit script is hardcoded to emit a “congrats” message saying this: > To run Safari with this newly-built code, use the "Tools/Scripts/run-safari" script. And the https://github.com/webkit/WebKit/?tab=readme-ov-file#running-webkit Readme.md file says: > Run the following command to launch Safari with your local build of WebKit: > Tools/Scripts/run-safari --debug So the build-webkit script and the Readme.md file should be updated to instead guide all outside/non-Apple contributors — even those building on macOS — to use the run-minibrowser script. Otherwise, it seems to be a common problem that outside contributors try the run-safari script, find that it doesn’t work expected, and then become confused and unsure how to proceed. In the best case, their next step is that they show up in the Slack #help room asking what they’ve done wrong — in which case, someone else in the room quickly points out to them that they need to use the run-minibrowser script instead. But the less-fortunate contributors can end up wasting time their time trying on their own to figure out what they’ve done wrong, and failing. 2018703 1 mike 2024-03-04 23:56:38 -0800 Pull request: https://github.com/WebKit/WebKit/pull/25476 2020379 2 webkit-bug-importer 2024-03-11 23:48:13 -0700 <rdar://problem/124433085>