270376 2024-03-01 13:43:49 -0800 [JSC] Decode local indices at runtime in WASM in-place interpreter 2024-03-07 17:48:20 -0800 1 1 1 Unclassified WebKit WebAssembly WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 d_degazio d_degazio webkit-bug-importer oldest_to_newest 2018103 0 d_degazio 2024-03-01 13:43:49 -0800 rdar://123720682 Local indices are encoded using ULEB128 in WebAssembly. In the work-in-progress in-place interpreter, we currently handle (U)LEB128 decoding during validation, and generate fully decoded indices in the metadata. Most functions, however, have very few locals in WebAssembly - WASM binaries that have gone through optimizations tend to treat locals like registers, and in all of JetStream 2 there is no local index that takes more than two bytes to encode. Since it's extremely common local indices will be single-byte, then it makes a lot of sense to skip the metadata entirely for all local instructions, instead having a single-byte fast path combined with an infrequently-taken ULEB128 decode at runtime. Since getting and setting locals makes up something like 1/3 of all WASM instructions in typical binaries, this should substantially reduce the size of the metadata generated for the in-place interpreter, and hopefully improve runtime performance as well. 2019441 1 d_degazio 2024-03-07 13:21:37 -0800 Pull request: https://github.com/WebKit/WebKit/pull/25596 2019510 2 ews-feeder 2024-03-07 17:48:18 -0800 Committed 275815@main (bfe017002276): <https://commits.webkit.org/275815@main> Reviewed commits have been landed. Closing PR #25596 and removing active labels.