270374 2024-03-01 13:36:45 -0800 [Wasm-GC] Fix JS API casts for some top types 2024-03-22 16:54:01 -0700 1 1 1 Unclassified WebKit WebAssembly WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 247394 1 asumu webkit-unassigned webkit-bug-importer oldest_to_newest 2018100 0 asumu 2024-03-01 13:36:45 -0800 There are a small number of cases in the JS API cast code that makes too-optimistic assumptions for top types (because the code was originally written to implement cast instructions, which benefit from static type-checking). Example diff for js-api.js: ``` + { + let m1 = instantiate(` + (module + (func (export "f")) + ) + `); + assert.throws( + () => instantiate(` + (module + (global (import "m" "f") (ref any)) + ) + `, { m: { f: m1.exports.f } }), + WebAssembly.LinkError, + "Argument value did not match the reference type" + ) + } ``` There's a simple fix for these cases. 2019481 1 asumu 2024-03-07 15:32:32 -0800 Pull request: https://github.com/WebKit/WebKit/pull/25599 2019693 2 webkit-bug-importer 2024-03-08 13:37:12 -0800 <rdar://problem/124294503> 2023274 3 ews-feeder 2024-03-22 16:53:59 -0700 Committed 276580@main (a2bcc4921f7c): <https://commits.webkit.org/276580@main> Reviewed commits have been landed. Closing PR #25599 and removing active labels.