270341 2024-03-01 05:03:29 -0800 REGRESSION(270647@main): vertical form controls causing WPT failures 2024-12-17 20:33:10 -0800 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=245355 https://bugs.webkit.org/show_bug.cgi?id=264692 InRadar, WPTImpact P2 Normal --- 1 gsnedders webkit-unassigned akeerthi cdumez karlcow ntim webkit-bug-importer wenson_hsieh oldest_to_newest 2017964 0 gsnedders 2024-03-01 05:03:29 -0800 This may well largely be a test development task, but: * /css/css-align/baseline-rules/grid-item-input-type-text.html: https://wpt.fyi/results/css/css-align/baseline-rules/grid-item-input-type-text.html?label=master&product=safari%5Bstable%5D&product=safari%5Bexperimental%5D&aligned&diff&filter=ADC * /css/css-flexbox/flex-item-compressible-002.html: https://wpt.fyi/results/css/css-flexbox/flex-item-compressible-002.html?label=master&product=safari%5Bstable%5D&product=safari%5Bexperimental%5D&aligned&diff&filter=ADC * /css/css-inline/baseline-source/baseline-source-first-textarea-002.tentative.html: https://wpt.fyi/results/css/css-inline/baseline-source/baseline-source-first-textarea-002.tentative.html?label=master&product=safari%5Bstable%5D&product=safari%5Bexperimental%5D&aligned&diff&filter=ADC * /css/css-inline/baseline-source/baseline-source-first-textarea-003.tentative.html: https://wpt.fyi/results/css/css-inline/baseline-source/baseline-source-first-textarea-003.tentative.html?label=master&product=safari%5Bstable%5D&product=safari%5Bexperimental%5D&aligned&diff&filter=ADC * /css/css-inline/baseline-source/baseline-source-last-textarea-002.tentative.html: https://wpt.fyi/results/css/css-inline/baseline-source/baseline-source-last-textarea-002.tentative.html?label=master&product=safari%5Bstable%5D&product=safari%5Bexperimental%5D&aligned&diff&filter=ADC * /css/css-inline/baseline-source/baseline-source-last-textarea-003.tentative.html: https://wpt.fyi/results/css/css-inline/baseline-source/baseline-source-last-textarea-003.tentative.html?label=master&product=safari%5Bstable%5D&product=safari%5Bexperimental%5D&aligned&diff&filter=ADC * /css/css-writing-modes/forms/checkbox-appearance-native-vertical-lr-baseline.optional.html: https://wpt.fyi/results/css/css-writing-modes/forms/checkbox-appearance-native-vertical-lr-baseline.optional.html?label=master&product=safari%5Bstable%5D&product=safari%5Bexperimental%5D&aligned&diff&filter=ADC * /css/css-writing-modes/forms/checkbox-appearance-native-vertical-rl-baseline.optional.html: https://wpt.fyi/results/css/css-writing-modes/forms/checkbox-appearance-native-vertical-rl-baseline.optional.html?label=master&product=safari%5Bstable%5D&product=safari%5Bexperimental%5D&aligned&diff&filter=ADC * /css/css-writing-modes/forms/radio-appearance-native-vertical-lr-baseline.optional.html: https://wpt.fyi/results/css/css-writing-modes/forms/radio-appearance-native-vertical-lr-baseline.optional.html?label=master&product=safari%5Bstable%5D&product=safari%5Bexperimental%5D&aligned&diff&filter=ADC * /css/css-writing-modes/forms/radio-appearance-native-vertical-rl-baseline.optional.html: https://wpt.fyi/results/css/css-writing-modes/forms/radio-appearance-native-vertical-rl-baseline.optional.html?label=master&product=safari%5Bstable%5D&product=safari%5Bexperimental%5D&aligned&diff&filter=ADC All of these regressed with the enablement of vertical form controls. Needless to say, we probably don't want to be failing tests everyone else passes, thus this probably needs test changes to allow for vertical form controls (or does the spec require support?). 2017965 1 webkit-bug-importer 2024-03-01 05:03:48 -0800 <rdar://problem/123895894> 2018062 2 akeerthi 2024-03-01 11:18:44 -0800 Starting to triage these. * /css/css-writing-modes/forms/checkbox-appearance-native-vertical-lr-baseline.optional.html: https://wpt.fyi/results/css/css-writing-modes/forms/checkbox-appearance-native-vertical-lr-baseline.optional.html * /css/css-writing-modes/forms/checkbox-appearance-native-vertical-rl-baseline.optional.html: https://wpt.fyi/results/css/css-writing-modes/forms/checkbox-appearance-native-vertical-rl-baseline.optional.html * /css/css-writing-modes/forms/radio-appearance-native-vertical-lr-baseline.optional.html: https://wpt.fyi/results/css/css-writing-modes/forms/radio-appearance-native-vertical-lr-baseline.optional.html * /css/css-writing-modes/forms/radio-appearance-native-vertical-rl-baseline.optional.html Are not regressions. In fact, I first wrote these tests. Chrome then added to the tests in https://github.com/web-platform-tests/wpt/commit/715c01dd8ab90c9e402eddf7792f26f243ee843d Really, the Chrome additions should have been done as a separate ref test. They show that our baseline alignment for checkboxes and radio buttons is incorrect for vertical writing mode + text-orientation: sideways. But that is simply a bug in a new feature. The test was passing pre-270647@main simply because it was written in a way such that the test passes when form controls are forced to use a horizontal writing mode. 2018063 3 akeerthi 2024-03-01 11:21:37 -0800 * /css/css-align/baseline-rules/grid-item-input-type-text.html Is a 1px positioning difference in vertical writing mode. The test previously passed as horizontal writing mode does not have the same bug, and form controls were previously forced into horizontal. 2018065 4 akeerthi 2024-03-01 11:41:10 -0800 The same is true of the remaining tests. They are all written in a way such that they pass when a horizontal writing mode is forced. But that itself is incorrect. We need to track related tests separately, as bugs in vertical writing mode.