27013 2009-07-06 16:00:47 -0700 WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle definition for Windows 2009-07-08 14:36:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dumi dumi alp aroben dglazkov fishd hausmann oldest_to_newest 130048 0 dumi 2009-07-06 16:00:47 -0700 WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle definition for PLATFORM(WIN_OS). 130058 1 dumi 2009-07-06 17:23:52 -0700 What I wanted was a way to distinguish between the CHROMIUM port on Windows and the CHROMIUM port on Mac/Linux. If I understand the code correctly, there's no way to do this in WebKit, because WebKit knows only about one generic CHROMIUM port. So we'll have to take care of this in the Chromium code. 130293 2 dumi 2009-07-07 15:56:29 -0700 After talking to Darin, it looks like we can extend the PlatformFileHandle definition for PLATFORM(WIN) to all WebKit ports built on Windows, which seems reasonable to me and works for Chromium too. Reopening the issue, patch coming shortly. 130295 3 32399 dumi 2009-07-07 16:00:03 -0700 Created attachment 32399 patch 130302 4 32399 fishd 2009-07-07 16:28:13 -0700 Comment on attachment 32399 patch I'm concerned this may cause problems for the PLATFORM(QT) build. I believe that in the PLATFORM(QT) builds on Windows, PLATFORM(WIN_OS) will also be defined. You may be able to avoid that problem by revising the #ifdefs to check for PLATFORM(QT) before checking for PLATFORM(WIN_OS). Also, the very last PLATFORM(WIN) in FileSystem.h might be best kept as PLATFORM(WIN). It looks like it is a declaration of additional functions that perhaps only make sense in the PLATFORM(WIN) port (i.e., Safari on Windows). 130304 5 fishd 2009-07-07 16:30:27 -0700 CC'ing folks who seemed to have been involved with the PLATFORM(QT) code in FileSystem.h. Guys, please see comment #4. Thanks! 130305 6 32401 dumi 2009-07-07 16:37:30 -0700 Created attachment 32401 patch done. 130309 7 32401 fishd 2009-07-07 17:07:38 -0700 Comment on attachment 32401 patch This looks like it will work. R=me 130521 8 fishd 2009-07-08 14:36:24 -0700 Landed as: http://trac.webkit.org/changeset/45640 32399 2009-07-07 16:00:03 -0700 2009-07-07 16:37:30 -0700 patch patch text/plain 1525 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTYxMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDctMDcgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBFeHRlbmRpbmcgdGhlIFBsYXRmb3JtRmlsZUhhbmRsZSBkZWZpbml0aW9uIGZyb20gUExBVEZP Uk0oV0lOKSB0bworICAgICAgICBhbGwgcG9ydHMgYnVpbHQgb24gYSBXaW5kb3dzIE9TLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzAxMworCisg ICAgICAgICogcGxhdGZvcm0vRmlsZVN5c3RlbS5oOgorCiAyMDA5LTA3LTA3ICBEYW4gQmVybnN0 ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2Vy LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9GaWxlU3lzdGVtLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9GaWxlU3lzdGVtLmgJKHJldmlzaW9uIDQ1NjEwKQorKysgV2ViQ29yZS9w bGF0Zm9ybS9GaWxlU3lzdGVtLmgJKHdvcmtpbmcgY29weSkKQEAgLTUzLDcgKzUzLDcgQEAKIAog dHlwZWRlZiBjb25zdCBzdHJ1Y3QgX19DRkRhdGEqIENGRGF0YVJlZjsKIAotI2lmIFBMQVRGT1JN KFdJTikKKyNpZiBQTEFURk9STShXSU5fT1MpCiAvLyBUaGVzZSBhcmUgdG8gYXZvaWQgaW5jbHVk aW5nIDx3aW5iYXNlLmg+IGluIGEgaGVhZGVyIGZvciBDaHJvbWl1bQogdHlwZWRlZiB2b2lkICpI QU5ETEU7CiAvLyBBc3N1bWluZyBTVFJJQ1QKQEAgLTY1LDcgKzY1LDcgQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogCiBjbGFzcyBDU3RyaW5nOwogCi0jaWYgUExBVEZPUk0oV0lOKQorI2lmIFBMQVRG T1JNKFdJTl9PUykKIHR5cGVkZWYgSEFORExFIFBsYXRmb3JtRmlsZUhhbmRsZTsKIHR5cGVkZWYg SE1PRFVMRSBQbGF0Zm9ybU1vZHVsZTsKIC8vIEZJWE1FOiAtMSBpcyBJTlZBTElEX0hBTkRMRV9W QUxVRSwgZGVmaW5lZCBpbiA8d2luYmFzZS5oPi4gQ2hyb21pdW0gdHJpZXMgdG8KQEAgLTE1Nyw3 ICsxNTcsNyBAQCBpbnQgd3JpdGVUb0ZpbGUoUGxhdGZvcm1GaWxlSGFuZGxlLCBjb25zCiAvLyBN ZXRob2RzIGZvciBkZWFsaW5nIHdpdGggbG9hZGFibGUgbW9kdWxlcwogYm9vbCB1bmxvYWRNb2R1 bGUoUGxhdGZvcm1Nb2R1bGUpOwogCi0jaWYgUExBVEZPUk0oV0lOKQorI2lmIFBMQVRGT1JNKFdJ Tl9PUykKIFN0cmluZyBsb2NhbFVzZXJTcGVjaWZpY1N0b3JhZ2VEaXJlY3RvcnkoKTsKIFN0cmlu ZyByb2FtaW5nVXNlclNwZWNpZmljU3RvcmFnZURpcmVjdG9yeSgpOwogCg== 32401 2009-07-07 16:37:30 -0700 2009-07-07 17:07:38 -0700 patch patch text/plain 2764 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTYxMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDctMDcgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBFeHRlbmRpbmcgdGhlIFBsYXRmb3JtRmlsZUhhbmRsZSBkZWZpbml0aW9uIGZyb20gUExBVEZP Uk0oV0lOKSB0bworICAgICAgICBhbGwgcG9ydHMgYnVpbHQgb24gYSBXaW5kb3dzIE9TLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzAxMworCisg ICAgICAgICogcGxhdGZvcm0vRmlsZVN5c3RlbS5oOgorCiAyMDA5LTA3LTA3ICBEYW4gQmVybnN0 ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2Vy LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9GaWxlU3lzdGVtLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wbGF0Zm9ybS9GaWxlU3lzdGVtLmgJKHJldmlzaW9uIDQ1NjEwKQorKysgV2ViQ29yZS9w bGF0Zm9ybS9GaWxlU3lzdGVtLmgJKHdvcmtpbmcgY29weSkKQEAgLTUzLDcgKzUzLDcgQEAKIAog dHlwZWRlZiBjb25zdCBzdHJ1Y3QgX19DRkRhdGEqIENGRGF0YVJlZjsKIAotI2lmIFBMQVRGT1JN KFdJTikKKyNpZiBQTEFURk9STShXSU5fT1MpCiAvLyBUaGVzZSBhcmUgdG8gYXZvaWQgaW5jbHVk aW5nIDx3aW5iYXNlLmg+IGluIGEgaGVhZGVyIGZvciBDaHJvbWl1bQogdHlwZWRlZiB2b2lkICpI QU5ETEU7CiAvLyBBc3N1bWluZyBTVFJJQ1QKQEAgLTY1LDEzICs2NSwxNSBAQCBuYW1lc3BhY2Ug V2ViQ29yZSB7CiAKIGNsYXNzIENTdHJpbmc7CiAKLSNpZiBQTEFURk9STShXSU4pCi10eXBlZGVm IEhBTkRMRSBQbGF0Zm9ybUZpbGVIYW5kbGU7Ci10eXBlZGVmIEhNT0RVTEUgUGxhdGZvcm1Nb2R1 bGU7Ci0vLyBGSVhNRTogLTEgaXMgSU5WQUxJRF9IQU5ETEVfVkFMVUUsIGRlZmluZWQgaW4gPHdp bmJhc2UuaD4uIENocm9taXVtIHRyaWVzIHRvCi0vLyBhdm9pZCB1c2luZyBXaW5kb3dzIGhlYWRl cnMgaW4gaGVhZGVycy4gIFdlJ2QgcmF0aGVyIG1vdmUgdGhpcyBpbnRvIHRoZSAuY3BwLgotY29u c3QgUGxhdGZvcm1GaWxlSGFuZGxlIGludmFsaWRQbGF0Zm9ybUZpbGVIYW5kbGUgPSByZWludGVy cHJldF9jYXN0PEhBTkRMRT4oLTEpOworI2lmIFBMQVRGT1JNKFFUKQogCit0eXBlZGVmIFFGaWxl KiBQbGF0Zm9ybUZpbGVIYW5kbGU7Citjb25zdCBQbGF0Zm9ybUZpbGVIYW5kbGUgaW52YWxpZFBs YXRmb3JtRmlsZUhhbmRsZSA9IDA7CisjaWYgZGVmaW5lZChRX1dTX01BQykKK3R5cGVkZWYgQ0ZC dW5kbGVSZWYgUGxhdGZvcm1Nb2R1bGU7Cit0eXBlZGVmIHVuc2lnbmVkIFBsYXRmb3JtTW9kdWxl VmVyc2lvbjsKKyNlbGlmIGRlZmluZWQoUV9PU19XSU4pCit0eXBlZGVmIEhNT0RVTEUgUGxhdGZv cm1Nb2R1bGU7CiBzdHJ1Y3QgUGxhdGZvcm1Nb2R1bGVWZXJzaW9uIHsKICAgICB1bnNpZ25lZCBs ZWFzdFNpZzsKICAgICB1bnNpZ25lZCBtb3N0U2lnOwpAQCAtODksMTUgKzkxLDE4IEBAIHN0cnVj dCBQbGF0Zm9ybU1vZHVsZVZlcnNpb24gewogICAgIH0KIAogfTsKLSNlbGlmIFBMQVRGT1JNKFFU KQotCi10eXBlZGVmIFFGaWxlKiBQbGF0Zm9ybUZpbGVIYW5kbGU7Ci1jb25zdCBQbGF0Zm9ybUZp bGVIYW5kbGUgaW52YWxpZFBsYXRmb3JtRmlsZUhhbmRsZSA9IDA7Ci0jaWYgZGVmaW5lZChRX1dT X01BQykKLXR5cGVkZWYgQ0ZCdW5kbGVSZWYgUGxhdGZvcm1Nb2R1bGU7CisjZWxzZQordHlwZWRl ZiBRTGlicmFyeSogUGxhdGZvcm1Nb2R1bGU7CiB0eXBlZGVmIHVuc2lnbmVkIFBsYXRmb3JtTW9k dWxlVmVyc2lvbjsKLSNlbGlmIGRlZmluZWQoUV9PU19XSU4pCisjZW5kaWYKKworI2VsaWYgUExB VEZPUk0oV0lOX09TKQordHlwZWRlZiBIQU5ETEUgUGxhdGZvcm1GaWxlSGFuZGxlOwogdHlwZWRl ZiBITU9EVUxFIFBsYXRmb3JtTW9kdWxlOworLy8gRklYTUU6IC0xIGlzIElOVkFMSURfSEFORExF X1ZBTFVFLCBkZWZpbmVkIGluIDx3aW5iYXNlLmg+LiBDaHJvbWl1bSB0cmllcyB0bworLy8gYXZv aWQgdXNpbmcgV2luZG93cyBoZWFkZXJzIGluIGhlYWRlcnMuICBXZSdkIHJhdGhlciBtb3ZlIHRo aXMgaW50byB0aGUgLmNwcC4KK2NvbnN0IFBsYXRmb3JtRmlsZUhhbmRsZSBpbnZhbGlkUGxhdGZv cm1GaWxlSGFuZGxlID0gcmVpbnRlcnByZXRfY2FzdDxIQU5ETEU+KC0xKTsKKwogc3RydWN0IFBs YXRmb3JtTW9kdWxlVmVyc2lvbiB7CiAgICAgdW5zaWduZWQgbGVhc3RTaWc7CiAgICAgdW5zaWdu ZWQgbW9zdFNpZzsKQEAgLTExNiwxMSArMTIxLDYgQEAgc3RydWN0IFBsYXRmb3JtTW9kdWxlVmVy c2lvbiB7CiAKIH07CiAjZWxzZQotdHlwZWRlZiBRTGlicmFyeSogUGxhdGZvcm1Nb2R1bGU7Ci10 eXBlZGVmIHVuc2lnbmVkIFBsYXRmb3JtTW9kdWxlVmVyc2lvbjsKLSNlbmRpZgotCi0jZWxzZQog dHlwZWRlZiBpbnQgUGxhdGZvcm1GaWxlSGFuZGxlOwogI2lmIFBMQVRGT1JNKEdUSykKIHR5cGVk ZWYgR01vZHVsZSogUGxhdGZvcm1Nb2R1bGU7Cg==