27010 2009-07-06 15:24:09 -0700 Need to remove UsesManualToJSImplementation() in favor of CustomToJS 2009-07-10 12:15:30 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson atwilson dimich oldest_to_newest 130036 0 atwilson 2009-07-06 15:24:09 -0700 CodeGeneratorJS.pm has some hard-coded logic which determines whether a toJS() function should be defined in the JS binding header file, and whether an implementation should be automatically generated. This logic is: .h file: define toJS() if the class in question is a base class (no parent class) or if it has the GenerateToJS custom attribute. .cpp file: automatically generate implementation of toJS() if the class in question is a base class, but is not a member of a hardcoded list in UsesManualToJSImplementation() We should get rid of UsesManualToJSImplementation() in favor of a CustomToJS attribute - the presence of this attribute will cause the code generator to emit a toJS() definition in the generated .h file, but will not automatically generate an implementation in the .cpp file. 130057 1 32334 atwilson 2009-07-06 17:18:57 -0700 Created attachment 32334 Proposed patch 130059 2 32334 darin 2009-07-06 17:26:02 -0700 Comment on attachment 32334 Proposed patch r=me assuming it build and tests pass 130912 3 dimich 2009-07-10 12:15:30 -0700 Landed: http://trac.webkit.org/changeset/45714 32334 2009-07-06 17:18:57 -0700 2009-07-06 17:26:01 -0700 Proposed patch patch.txt text/plain 6722 atwilson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTU1MjlkZS4uNjMzOTc4ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAwOS0wNy0wNiAgRHJldyBXaWxzb24g IDxhdHdpbHNvbkBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5lZWQgdG8gcmVtb3ZlIFVzZXNNYW51YWxUb0pTSW1wbGVtZW50YXRp b24oKSBpbiBmYXZvciBvZiBDdXN0b21Ub0pTCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yNzAxMAorCisgICAgICAgIEFkZGVkIHN1cHBvcnQgZm9yIEN1 c3RvbVRvSlMgSURMIGF0dHJpYnV0ZSB0byByZXBsYWNlIHRoZSBoYXJkLWNvZGVkIGNsYXNzIGxp c3QgaW4gVXNlc01hbnVhbFRvSlNJbXBsZW1lbnRhdGlvbigpLgorCisgICAgICAgIFRoaXMgaXMg anVzdCBhIGNsZWFudXAgb2YgZXhpc3RpbmcgZnVuY3Rpb25hbGl0eSwgc28gZXhpc3RpbmcgTGF5 b3V0VGVzdHMgYWRlcXVhdGVseSBjb3ZlciB0aGlzIHBhdGNoLgorCisgICAgICAgICogYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgIFJlbW92ZWQgVXNlc01hbnVh bFRvSlNJbXBsZW1lbnRhdGlvbigpLCBhZGRlZCBzdXBwb3J0IGZvciBDdXN0b21Ub0pTIGF0dHJp YnV0ZS4KKyAgICAgICAgKiBjc3MvQ1NTUnVsZS5pZGw6CisgICAgICAgICogY3NzL0NTU1ZhbHVl LmlkbDoKKyAgICAgICAgKiBjc3MvU3R5bGVTaGVldC5pZGw6CisgICAgICAgICogZG9tL0RvY3Vt ZW50LmlkbDoKKyAgICAgICAgKiBkb20vRXZlbnQuaWRsOgorICAgICAgICAqIGRvbS9Ob2RlLmlk bDoKKyAgICAgICAgKiBodG1sL0ltYWdlRGF0YS5pZGw6CisgICAgICAgICogc3ZnL1NWR0VsZW1l bnRJbnN0YW5jZS5pZGw6CisgICAgICAgICogc3ZnL1NWR1BhdGhTZWcuaWRsOgorICAgICAgICBB ZGRlZCBDdXN0b21Ub0pTIGF0dHJpYnV0ZSB0byBhbGwgdGhlIGFib3ZlIElETCBmaWxlcy4KKwog MjAwOS0wNy0wMiAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtIGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0Nv ZGVHZW5lcmF0b3JKUy5wbQppbmRleCA0ZjlhYTFhLi44M2VjOGM2IDEwMDY0NAotLS0gYS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCisrKyBiL1dlYkNvcmUvYmlu ZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KQEAgLTE0MCwxNCArMTQwLDYgQEAgc3Vi IEF2b2lkSW5jbHVzaW9uT2ZUeXBlCiAgICAgcmV0dXJuIDA7CiB9CiAKLXN1YiBVc2VzTWFudWFs VG9KU0ltcGxlbWVudGF0aW9uCi17Ci0gICAgbXkgJHR5cGUgPSBzaGlmdDsKLQotICAgIHJldHVy biAxIGlmICR0eXBlIGVxICJOb2RlIiBvciAkdHlwZSBlcSAiRG9jdW1lbnQiIG9yICR0eXBlIGVx ICJIVE1MQ29sbGVjdGlvbiIgb3IgJHR5cGUgZXEgIlNWR1BhdGhTZWciIG9yICR0eXBlIGVxICJT dHlsZVNoZWV0IiBvciAkdHlwZSBlcSAiQ1NTUnVsZSIgb3IgJHR5cGUgZXEgIkNTU1ZhbHVlIiBv ciAkdHlwZSBlcSAiRXZlbnQiIG9yICR0eXBlIGVxICJJbWFnZURhdGEiIG9yICR0eXBlIGVxICJF bGVtZW50IiBvciAkdHlwZSBlcSAiVGV4dCIgb3IgJHR5cGUgZXEgIlNWR0VsZW1lbnRJbnN0YW5j ZSI7Ci0gICAgcmV0dXJuIDA7Ci19Ci0KIHN1YiBJbmRleEdldHRlclJldHVybnNTdHJpbmdzCiB7 CiAgICAgbXkgJHR5cGUgPSBzaGlmdDsKQEAgLTYyOSw3ICs2MjEsNyBAQCBzdWIgR2VuZXJhdGVI ZWFkZXIKICAgICAgICAgcHVzaChAaGVhZGVyQ29udGVudCwgIn1cblxuIik7CiAgICAgfQogCi0g ICAgaWYgKCEkaGFzUGFyZW50IHx8ICRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57Ikdl bmVyYXRlVG9KUyJ9KSB7CisgICAgaWYgKCEkaGFzUGFyZW50IHx8ICRkYXRhTm9kZS0+ZXh0ZW5k ZWRBdHRyaWJ1dGVzLT57IkdlbmVyYXRlVG9KUyJ9IHx8ICRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRy aWJ1dGVzLT57IkN1c3RvbVRvSlMifSkgewogICAgICAgICBpZiAoJHBvZFR5cGUpIHsKICAgICAg ICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICJKU0M6OkpTVmFsdWUgdG9KUyhKU0M6OkV4ZWNT dGF0ZSosIEpTU1ZHUE9EVHlwZVdyYXBwZXI8JHBvZFR5cGU+KiwgU1ZHRWxlbWVudCogY29udGV4 dCk7XG4iKTsKICAgICAgICAgfSBlbHNpZiAoSXNTVkdUeXBlTmVlZGluZ0NvbnRleHRQYXJhbWV0 ZXIoJGltcGxDbGFzc05hbWUpKSB7CkBAIC0xNTA1LDcgKzE0OTcsNyBAQCBzdWIgR2VuZXJhdGVJ bXBsZW1lbnRhdGlvbgogICAgICAgICB9CiAgICAgfQogCi0gICAgaWYgKCghJGhhc1BhcmVudCBv ciAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJHZW5lcmF0ZVRvSlMifSkgYW5kICFV c2VzTWFudWFsVG9KU0ltcGxlbWVudGF0aW9uKCRpbXBsQ2xhc3NOYW1lKSkgeworICAgIGlmICgo ISRoYXNQYXJlbnQgb3IgJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiR2VuZXJhdGVU b0pTIn0pIGFuZCAhJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ3VzdG9tVG9KUyJ9 KSB7CiAgICAgICAgIGlmICgkcG9kVHlwZSkgewogICAgICAgICAgICAgcHVzaChAaW1wbENvbnRl bnQsICJKU0M6OkpTVmFsdWUgdG9KUyhKU0M6OkV4ZWNTdGF0ZSogZXhlYywgSlNTVkdQT0RUeXBl V3JhcHBlcjwkcG9kVHlwZT4qIG9iamVjdCwgU1ZHRWxlbWVudCogY29udGV4dClcbiIpOwogICAg ICAgICB9IGVsc2lmIChJc1NWR1R5cGVOZWVkaW5nQ29udGV4dFBhcmFtZXRlcigkaW1wbENsYXNz TmFtZSkpIHsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvY3NzL0NTU1J1bGUuaWRsIGIvV2ViQ29yZS9j c3MvQ1NTUnVsZS5pZGwKaW5kZXggZjEzZjI5My4uYmM1N2U1NSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9jc3MvQ1NTUnVsZS5pZGwKKysrIGIvV2ViQ29yZS9jc3MvQ1NTUnVsZS5pZGwKQEAgLTIyLDYg KzIyLDcgQEAgbW9kdWxlIGNzcyB7CiAKICAgICAvLyBJbnRyb2R1Y2VkIGluIERPTSBMZXZlbCAy OgogICAgIGludGVyZmFjZSBbCisgICAgICAgIEN1c3RvbVRvSlMsCiAgICAgICAgIEdlbmVyYXRl Q29uc3RydWN0b3IsCiAgICAgICAgIFBvbHltb3JwaGljLAogICAgICAgICBJbnRlcmZhY2VVVUlE PTU0ODEzOWI0LTMxYWItNDk3OC1iMWQ1LWNmY2ZkZmJhZWEwZSwKZGlmZiAtLWdpdCBhL1dlYkNv cmUvY3NzL0NTU1ZhbHVlLmlkbCBiL1dlYkNvcmUvY3NzL0NTU1ZhbHVlLmlkbAppbmRleCA4NzVk MTJlLi5lZTgyYjBjIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZS5pZGwKKysrIGIv V2ViQ29yZS9jc3MvQ1NTVmFsdWUuaWRsCkBAIC0yMSw2ICsyMSw3IEBACiBtb2R1bGUgY3NzIHsK IAogICAgIGludGVyZmFjZSBbCisgICAgICAgIEN1c3RvbVRvSlMsCiAgICAgICAgIEdlbmVyYXRl Q29uc3RydWN0b3IsCiAgICAgICAgIFBvbHltb3JwaGljLAogICAgICAgICBJbnRlcmZhY2VVVUlE PTlmZDYyYTdiLTUzOWQtNDUwMC1iZDZjLWVjMDc1YWJiYzQwNCwKZGlmZiAtLWdpdCBhL1dlYkNv cmUvY3NzL1N0eWxlU2hlZXQuaWRsIGIvV2ViQ29yZS9jc3MvU3R5bGVTaGVldC5pZGwKaW5kZXgg M2EyNmYyMC4uZTRmNDA5MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9jc3MvU3R5bGVTaGVldC5pZGwK KysrIGIvV2ViQ29yZS9jc3MvU3R5bGVTaGVldC5pZGwKQEAgLTIzLDYgKzIzLDcgQEAgbW9kdWxl IHN0eWxlc2hlZXRzIHsKICAgICAvLyBJbnRyb2R1Y2VkIGluIERPTSBMZXZlbCAyOgogICAgIGlu dGVyZmFjZSBbCiAgICAgICAgIEN1c3RvbU1hcmtGdW5jdGlvbiwKKyAgICAgICAgQ3VzdG9tVG9K UywKICAgICAgICAgR2VuZXJhdGVDb25zdHJ1Y3RvciwKICAgICAgICAgUG9seW1vcnBoaWMsCiAg ICAgICAgIEludGVyZmFjZVVVSUQ9MmJkMmRiNWYtYWFhYi00NDIyLTk2YTAtZTA1NDU1MzEzZjM1 LApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vRG9jdW1lbnQuaWRsIGIvV2ViQ29yZS9kb20vRG9j dW1lbnQuaWRsCmluZGV4IGFjNmRkMGUuLmFkNDEwNTcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9t L0RvY3VtZW50LmlkbAorKysgYi9XZWJDb3JlL2RvbS9Eb2N1bWVudC5pZGwKQEAgLTIxLDggKzIx LDggQEAKIG1vZHVsZSBjb3JlIHsKIAogICAgIGludGVyZmFjZSBbCisgICAgICAgIEN1c3RvbVRv SlMsCiAgICAgICAgIEdlbmVyYXRlQ29uc3RydWN0b3IsCi0gICAgICAgIEdlbmVyYXRlVG9KUywK ICAgICAgICAgR2VuZXJhdGVOYXRpdmVDb252ZXJ0ZXIsCiAgICAgICAgIEN1c3RvbU1hcmtGdW5j dGlvbiwKICAgICAgICAgSW5saW5lR2V0T3duUHJvcGVydHlTbG90LApkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9kb20vRXZlbnQuaWRsIGIvV2ViQ29yZS9kb20vRXZlbnQuaWRsCmluZGV4IDVhYzllMGMu Ljc1YjZiNWYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL0V2ZW50LmlkbAorKysgYi9XZWJDb3Jl L2RvbS9FdmVudC5pZGwKQEAgLTIyLDYgKzIyLDcgQEAgbW9kdWxlIGV2ZW50cyB7CiAKICAgICAv LyBJbnRyb2R1Y2VkIGluIERPTSBMZXZlbCAyOgogICAgIGludGVyZmFjZSBbCisgICAgICAgIEN1 c3RvbVRvSlMsCiAgICAgICAgIEdlbmVyYXRlQ29uc3RydWN0b3IsCiAgICAgICAgIE5vU3RhdGlj VGFibGVzLAogICAgICAgICBQb2x5bW9ycGhpYywKZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL05v ZGUuaWRsIGIvV2ViQ29yZS9kb20vTm9kZS5pZGwKaW5kZXggYmNmYjIyNi4uMWUzMWFlYSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9kb20vTm9kZS5pZGwKKysrIGIvV2ViQ29yZS9kb20vTm9kZS5pZGwK QEAgLTIzLDkgKzIzLDkgQEAgbW9kdWxlIGNvcmUgewogICAgIGludGVyZmFjZSBbCiAgICAgICAg IEN1c3RvbU1hcmtGdW5jdGlvbiwKICAgICAgICAgQ3VzdG9tUHVzaEV2ZW50SGFuZGxlclNjb3Bl LAorICAgICAgICBDdXN0b21Ub0pTLAogICAgICAgICBHZW5lcmF0ZUNvbnN0cnVjdG9yLAogICAg ICAgICBHZW5lcmF0ZU5hdGl2ZUNvbnZlcnRlciwKLSAgICAgICAgR2VuZXJhdGVUb0pTLAogICAg ICAgICBJbmxpbmVHZXRPd25Qcm9wZXJ0eVNsb3QsCiAgICAgICAgIFBvbHltb3JwaGljLAogICAg ICAgICBJbnRlcmZhY2VVVUlEPTg0QkEwRDdBLTdFM0UtNGE3Yi1CNkZCLTc2NTNFOEZCNTRFRCwK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9JbWFnZURhdGEuaWRsIGIvV2ViQ29yZS9odG1sL0lt YWdlRGF0YS5pZGwKaW5kZXggN2YzN2I1Mi4uODAyNWRlMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9o dG1sL0ltYWdlRGF0YS5pZGwKKysrIGIvV2ViQ29yZS9odG1sL0ltYWdlRGF0YS5pZGwKQEAgLTI5 LDggKzI5LDggQEAKIG1vZHVsZSBodG1sIHsKIAogICAgIGludGVyZmFjZSBbCisgICAgICAgIEN1 c3RvbVRvSlMsCiAgICAgICAgIEdlbmVyYXRlQ29uc3RydWN0b3IsCi0gICAgICAgIEdlbmVyYXRl VG9KUwogICAgIF0gSW1hZ2VEYXRhIHsKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGxvbmcg d2lkdGg7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBsb25nIGhlaWdodDsKZGlmZiAtLWdp dCBhL1dlYkNvcmUvc3ZnL1NWR0VsZW1lbnRJbnN0YW5jZS5pZGwgYi9XZWJDb3JlL3N2Zy9TVkdF bGVtZW50SW5zdGFuY2UuaWRsCmluZGV4IDNkODgxNzguLmNkNDIxM2MgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvc3ZnL1NWR0VsZW1lbnRJbnN0YW5jZS5pZGwKKysrIGIvV2ViQ29yZS9zdmcvU1ZHRWxl bWVudEluc3RhbmNlLmlkbApAQCAtMzEsNyArMzEsNyBAQCBtb2R1bGUgc3ZnIHsKICAgICAgICAg Q3VzdG9tTGlzdGVuZXJzLAogICAgICAgICBDdXN0b21NYXJrRnVuY3Rpb24sCiAgICAgICAgIEN1 c3RvbVB1c2hFdmVudEhhbmRsZXJTY29wZSwKLSAgICAgICAgR2VuZXJhdGVUb0pTLAorICAgICAg ICBDdXN0b21Ub0pTLAogICAgICAgICBHZW5lcmF0ZU5hdGl2ZUNvbnZlcnRlcgogICAgIF0gU1ZH RWxlbWVudEluc3RhbmNlCiAjaWYgZGVmaW5lZChMQU5HVUFHRV9PQkpFQ1RJVkVfQykgJiYgTEFO R1VBR0VfT0JKRUNUSVZFX0MKZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3ZnL1NWR1BhdGhTZWcuaWRs IGIvV2ViQ29yZS9zdmcvU1ZHUGF0aFNlZy5pZGwKaW5kZXggNTk3YjAxZC4uNjc1NGQyYSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9zdmcvU1ZHUGF0aFNlZy5pZGwKKysrIGIvV2ViQ29yZS9zdmcvU1ZH UGF0aFNlZy5pZGwKQEAgLTI2LDcgKzI2LDcgQEAKIAogbW9kdWxlIHN2ZyB7CiAKLSAgICBpbnRl cmZhY2UgW0NvbmRpdGlvbmFsPVNWRywgR2VuZXJhdGVDb25zdHJ1Y3RvciwgUG9seW1vcnBoaWNd IFNWR1BhdGhTZWcgeworICAgIGludGVyZmFjZSBbQ29uZGl0aW9uYWw9U1ZHLCBDdXN0b21Ub0pT LCBHZW5lcmF0ZUNvbnN0cnVjdG9yLCBQb2x5bW9ycGhpY10gU1ZHUGF0aFNlZyB7CiAgICAgICAg IC8vIFBhdGggU2VnbWVudCBUeXBlcwogICAgICAgICBjb25zdCB1bnNpZ25lZCBzaG9ydCBQQVRI U0VHX1VOS05PV04gICAgICAgICAgICAgICAgICAgICAgPSAwOwogICAgICAgICBjb25zdCB1bnNp Z25lZCBzaG9ydCBQQVRIU0VHX0NMT1NFUEFUSCAgICAgICAgICAgICAgICAgICAgPSAxOwo=